[Jmap] draft-ietf-jmap-blob-05 Review

Joris Baum <joris@audriga.com> Wed, 03 November 2021 13:13 UTC

Return-Path: <joris@audriga.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44B503A1243 for <jmap@ietfa.amsl.com>; Wed, 3 Nov 2021 06:13:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tKrYhL2mnig8 for <jmap@ietfa.amsl.com>; Wed, 3 Nov 2021 06:13:25 -0700 (PDT)
Received: from mail.audriga.com (mail.audriga.com [176.221.42.35]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89F703A1153 for <jmap@ietf.org>; Wed, 3 Nov 2021 06:13:25 -0700 (PDT)
Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.audriga.com (Postfix) with ESMTP id C91BAA149 for <jmap@ietf.org>; Wed, 3 Nov 2021 14:13:21 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at mail.audriga.com
Received: from mail.audriga.com ([127.0.0.1]) by localhost (mail.audriga.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NXJXGGgDb9k8 for <jmap@ietf.org>; Wed, 3 Nov 2021 14:12:57 +0100 (CET)
Received: from [192.168.10.127] (b2b-109-90-161-242.unitymedia.biz [109.90.161.242]) (Authenticated sender: joris@audriga.com) by mail.audriga.com (Postfix) with ESMTPSA id A361AA178 for <jmap@ietf.org>; Wed, 3 Nov 2021 14:12:57 +0100 (CET)
Message-ID: <681c1851-a9e9-4cec-81a5-5d80f43f7c3e@audriga.com>
Date: Wed, 03 Nov 2021 14:12:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1
Content-Language: en-US
To: IETF JMAP Mailing List <jmap@ietf.org>
From: Joris Baum <joris@audriga.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/LJ1vbZ6LY3_4qQLTLyxdyWvtkqI>
Subject: [Jmap] draft-ietf-jmap-blob-05 Review
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Nov 2021 13:13:30 -0000

Looks good to me as well.

The examples make sense to me in general, look good and are probably 
sufficient.

One thing I noticed / that confuses me is the "expires" property in the 
concatenate example (Section 4.1.3 
https://www.ietf.org/archive/id/draft-ietf-jmap-blob-05.html#name-destroy 
) . As far as I can see there is no mention of it in the upload section 
6.1 of RFC 8620 ( 
https://datatracker.ietf.org/doc/html/rfc8620#section-6.1 ) nor in the 
JMAP Blob management extension spec. It looks like it is 
PushSubscription-specific and should not be in the example.

Regards,

Joris

-- 
Joris Baum
Tel: +49 721 170293 16
Fax: +49 721 170293 179

http://www.audriga.com | http://www.twitter.com/audriga

--------------------------------------------------------------------------
audriga GmbH | Durlacher Allee 47 | 76131 Karlsruhe
Sitz der Gesellschaft: Karlsruhe - Amtsgericht Mannheim - HRB 713034
Geschäftsführer: Dr. Frank Dengler, Dr.-Ing. Hans-Jörg Happel
--------------------------------------------------------------------------