[Jmap] Re: Artart telechat review of draft-ietf-jmap-contacts-09

Tim Bray <tbray@textuality.com> Fri, 07 June 2024 04:42 UTC

Return-Path: <tbray@textuality.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78A59C1519B2 for <jmap@ietfa.amsl.com>; Thu, 6 Jun 2024 21:42:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=textuality.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nrrYjjUgYWEI for <jmap@ietfa.amsl.com>; Thu, 6 Jun 2024 21:42:15 -0700 (PDT)
Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1AEFEC14F61E for <jmap@ietf.org>; Thu, 6 Jun 2024 21:42:15 -0700 (PDT)
Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-681ad26f4a5so914479a12.2 for <jmap@ietf.org>; Thu, 06 Jun 2024 21:42:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=textuality.com; s=google; t=1717735334; x=1718340134; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BkrYThVczqq3W3Eru3mLxvwxh9zHOw5yOMqcJF0dpxU=; b=AH1d3mnKvClVX4ZBFO1/90/U0Qx2BfjoAB0oNzF73WhhvZcuC4B4mC18c+A9CMHhAn iYrdnOSuCgtHYNPuD561JUQ7ivDEPAW/zGOW76mtya3pnkSZKUIIjoPWEuiSn2+6uj1y wdnSmrsO0F9E007I7M23TAbVCkyJJDwJaD51E=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717735334; x=1718340134; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BkrYThVczqq3W3Eru3mLxvwxh9zHOw5yOMqcJF0dpxU=; b=C/WrX6FNSSsYnLM1e3ON+ZAsnxd72Gi0cemoDbO72kik7kiRTBRumi6XBjtzUrV9iA BBehd7Iie9IfBAVdoz+P7bwYYlVk6/Y4Dupo0HzMe6rjQSL2XgQZaAC+jplOUCBN6hbs NLxtYWCvFYMIQC9ei3T6E4P1a+TcV53bzvzbmIkUNMDDR4/l1kbDSJ0Xw6h/RoIeZ3rj 2PkX7CDV+JNqpgcmgdPTzT3Sn8yn2RVJK713gtfhKRCS0absMiOGYIlZTrHjY+h/KNZv 9eHaSjbLg9zV56bf4uWWSEz4jMGZE01Xzuh8CRc99dgF2QcK5+u4PgmqYZbtaeL82+i5 CfyA==
X-Forwarded-Encrypted: i=1; AJvYcCWECUiq0li+yXBoOAJ2CY2NgLfO+42mB2a6msSWUCfV1tM7k7RN5VzbnWyy1Qu85I2JH/3HajiRggHZypUm
X-Gm-Message-State: AOJu0YyZSPox/4huaZgQLPkFf0RY9voZmy1dH7sSkqLeUGp0Tuq1CMcF hDbXc7xsOesi6GsBwH1clb1N7ozAD+XGM27U9J12pmOJk26TcKwDLWHG4DuJWlu3WVsVvhaH+qj 6OIrd5r0Kuo2Kksm1QVKCRW74jSLolzMql+oGxA==
X-Google-Smtp-Source: AGHT+IFrDWB+JOOJBKKLSULoJoQn0lZ/CiycoTZGdfXMrfHsHbFMRZm1ymrs8d3n2GasFa4+XE3hcKBskBSch0B13bM=
X-Received: by 2002:a05:6a20:2583:b0:1b2:c459:8ab3 with SMTP id adf61e73a8af0-1b2f9a60bf4mr1661496637.33.1717735334109; Thu, 06 Jun 2024 21:42:14 -0700 (PDT)
Received: from 1064022179695 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 Jun 2024 04:42:13 +0000
Received: from 1064022179695 named unknown by gmailapi.google.com with HTTPREST; Thu, 6 Jun 2024 21:42:10 -0700
MIME-Version: 1.0 (Mimestream 1.3.2)
References: <171605695839.29495.8129547067232508808@ietfa.amsl.com> <9fc4a3f9-86d7-47c6-ac00-302d05a99adc@dogfoodapp.fastmail.com>
In-Reply-To: <9fc4a3f9-86d7-47c6-ac00-302d05a99adc@dogfoodapp.fastmail.com>
From: Tim Bray <tbray@textuality.com>
Date: Fri, 07 Jun 2024 04:42:13 +0000
Message-ID: <CAHBU6ius6_N_pcM5wr+Raw76-9a23U1gV7LyhLRTXX1nx0=jhA@mail.gmail.com>
To: Neil Jenkins <neilj@fastmailteam.com>
Content-Type: multipart/alternative; boundary="000000000000687ae8061a456c45"
Message-ID-Hash: KJMUFJVC5SGRJUFVTPBXEFADA4NDONKC
X-Message-ID-Hash: KJMUFJVC5SGRJUFVTPBXEFADA4NDONKC
X-MailFrom: tbray@textuality.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-jmap.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-jmap-contacts.all@ietf.org, IETF JMAP Mailing List <jmap@ietf.org>, last-call@ietf.org, art@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Jmap] Re: Artart telechat review of draft-ietf-jmap-contacts-09
List-Id: JSON Message Access Protocol <jmap.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/P06e7FxiiWDSNmcNsg7BeJYuE1s>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Owner: <mailto:jmap-owner@ietf.org>
List-Post: <mailto:jmap@ietf.org>
List-Subscribe: <mailto:jmap-join@ietf.org>
List-Unsubscribe: <mailto:jmap-leave@ietf.org>

 I still think it’d be a good idea to reference 9413, but this section is
OK by me. Thanks!  -Tim

On Jun 6, 2024 at 6:51:16 PM, Neil Jenkins <neilj@fastmailteam.com> wrote:

> Hi Tim,
>
> Thank you for your review.
>
> On Sun, 19 May 2024, at 04:29, Tim Bray via Datatracker wrote:
>
> 1. There is a reference to "control characters" without any citation, and
> the
> definition is not as obvious as one might think. A good reference is
> [UNICODE]
> section 23.1, which may be summarized as "65 code points in the ranges
> U+0000-U+001F ("C0 Controls") and U+0080-U+009F (“C1 Controls”), plus
> U+007F,
> "DEL"
>
> 2. This section might benefit from a reference to RFC9413, which has a
> thorough discussion of dealing with input data that is invalid for some
> reason.
>
> 3. There are 3 options when receiving a message with invalid characters:
> delete
> them, replace them (Unicode provides U+FFFD for this purpose), or reject
> the
> message. The draft mentions two of these but not the replacement option.
> Is it
> never appropriate in the JMAP context?
>
>
> Right, this is also a valid option. I have updated the
> Internationalisation Considerations section to read:
>
> Experience has shown that unrestricted use of Unicode can lead to problems
> such as inconsistent rendering, users reading text and interpreting it
> differently than intended, and unexpected results when copying text from
> one location to another. Servers MAY choose to mitigate this by restricting
> the set of characters allowed in otherwise unconstrained String fields. The
> FreeformClass, as documented in [RFC8264
> <https://www.rfc-editor.org/rfc/rfc8264>], Section 4.3 might be a good
> starting point for this.
>
> Attempts to set a value containing code points outside of the permissible
> set can be handled in a few ways by the server. The server could choose to
> strip the forbidden characters, or replace them with U+FFFD (the Unicode
> replacement character), and store the resulting string. This is likely to
> be appropriate for non-printable characters — such as the "Control Codes"
> defined in [UNICODE <http://www.unicode.org/versions/latest/>] Section
> 23.1, excluding newline (U+000A), carriage return (U+000D), and tab
> (U+0009) — which can end up in data accidentally due to copy-and-paste
> issues, but are invisible to the end user. JMAP allows the server to
> transform data on create/update, as long as any changed properties are
> returned to the client in the /set response, so it knows what has changed,
> as per [RFC8620 <https://www.rfc-editor.org/rfc/rfc8620.html>], Section
> 5.3. Alternatively, the server MAY just reject the create/update with an
> invalidProperties SetError.
>
> Cheers,
> Neil.
>