Re: [Jmap] Blob draft updates - please have a look at -04 before the interim

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 18 October 2021 20:01 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7A9213A08DA for <jmap@ietfa.amsl.com>; Mon, 18 Oct 2021 13:01:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 542cyNeI0JXb for <jmap@ietfa.amsl.com>; Mon, 18 Oct 2021 13:01:28 -0700 (PDT)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id CA5023A08DE for <jmap@ietf.org>; Mon, 18 Oct 2021 13:01:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1634587284; d=isode.com; s=june2016; i=@isode.com; bh=J0qrLcElv3LFZHuOl27KBGISMiCJEMRZukw2WapJKW0=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=gQ+Ala1j+7PYqNEaDMAbxv2x7gyxCf682nsal2J9K782EkXdAO0cX92TJFIMXXHbdDfGpc RSqHpzcfKUOCpI53ds+R6TAIJRllMzLEyCvynfiSddvoVkiQaFZTcj4W1r5gwIP5J+jqVb soPZQedlbBcqiYlYlONc5jSJq3Q/ZFQ=;
Received: from [192.168.0.5] ((unknown) [94.3.228.58]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <YW3SkwALZJsv@statler.isode.com>; Mon, 18 Oct 2021 21:01:23 +0100
X-SMTP-Protocol-Errors: NORDNS
To: Bron Gondwana <brong@fastmailteam.com>, jmap@ietf.org
References: <119ef5f3-ad8d-4423-b019-38454a5be2b6@dogfood.fastmail.com>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <b986d71e-dcc9-a393-4e19-e30e4b0186dc@isode.com>
Date: Mon, 18 Oct 2021 21:01:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <119ef5f3-ad8d-4423-b019-38454a5be2b6@dogfood.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------A9E71B79ECA2FCC322802B11"
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/Xj7j2kDp5IVSv0atIkP1ejvHVaQ>
Subject: Re: [Jmap] Blob draft updates - please have a look at -04 before the interim
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Oct 2021 20:01:33 -0000

Hi Bron,

On 16/10/2021 13:09, Bron Gondwana wrote:
> Sorry for the two versions in quick succession!  I realised I hadn't 
> put anything in security considerations about virus checking blobs 
> created by `catenate` the same way you might check blobs injected via 
> `upload`.
> *
> *
> *I've just posted draft-ietf-jmap-blob-04, which resolves a bunch of 
> issues:*
>
>   * https://github.com/brong/draft-gondwana-jmap-blob/issues/1
>     <https://github.com/brong/draft-gondwana-jmap-blob/issues/1>
>       o using |typeNames| in the request and |matchedIds| in the
>         response for lookup
>   * https://github.com/brong/draft-gondwana-jmap-blob/issues/2
>     <https://github.com/brong/draft-gondwana-jmap-blob/issues/2>
>       o if |data:asText| is requested and the selected octet range is
>         not valid utf-8, then we add an |isEncodingProblem: true|
>         property like in RFC8621.
>       o also, if the selected range can't be entirely satisfied
>         (length past the end of the blob) we set an|isTruncated: true|
>         property in the response.
>   * https://github.com/brong/draft-gondwana-jmap-blob/issues/3
>     <https://github.com/brong/draft-gondwana-jmap-blob/issues/3>
>       o added a |maxCatenateItems| capability field (suggested minimum 64)
>   * https://github.com/brong/draft-gondwana-jmap-blob/issues/4
>     <https://github.com/brong/draft-gondwana-jmap-blob/issues/4>
>       o added Security Considerations around scanning the resulting
>         blobs created by Blob/set the same way you would scan uploads.
>
> *Yet again, I'm asking for your reviews!*

I've checked recent changes and they look reasonable to me.

Best Regards,

Alexey*
*

>
> This is all implemented in the Cyrus IMAP server at 
> https://github.com/cyrusimap/cyrus-imapd/pull/3685 
> <https://github.com/cyrusimap/cyrus-imapd/pull/3685> - which I'm 
> planning to rebase and neaten up once we're happy with this draft, and 
> ready to do a working group last call.
>
> We'll talk about it at the interim meeting with CalConnect next week, 
> and I'm probably going to ask Jim for a working group last call after 
> that unless there are any changes that people still want!
>
> Cheers,
>
> Bron.
>
>
> P.S. ... and yes, I probably WILL come back after this with yet 
> another document or two for server-side-coding and 
> server-side-digests, but that's different enough not to merge into 
> this one!
>