Re: [Jmap] Murray Kucherawy's No Objection on draft-ietf-jmap-mdn-15: (with COMMENT)

Raphaël Ouazana <rouazana@linagora.com> Thu, 10 December 2020 18:31 UTC

Return-Path: <rouazana@linagora.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEF293A118B; Thu, 10 Dec 2020 10:31:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qyFB2-yFyupl; Thu, 10 Dec 2020 10:31:00 -0800 (PST)
Received: from smtp.linagora.com (smtp.linagora.com [54.36.8.78]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDCB03A1190; Thu, 10 Dec 2020 10:30:59 -0800 (PST)
Received: from [192.168.0.37] (91-168-246-100.subs.proxad.net [91.168.246.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.linagora.com (Postfix) with ESMTPSA id CC141484B0; Thu, 10 Dec 2020 19:24:37 +0100 (CET)
To: Murray Kucherawy <superuser@gmail.com>, The IESG <iesg@ietf.org>
Cc: jmap@ietf.org, Bron Gondwana <brong@fastmailteam.com>, draft-ietf-jmap-mdn@ietf.org, jmap-chairs@ietf.org
References: <160139528034.2924.9672441697416964848@ietfa.amsl.com>
X-LINAGORA-Copy-Delivery-Done: 1
From: Raphaël Ouazana <rouazana@linagora.com>
Message-ID: <69d3b12b-fef6-52a2-7420-9dc344e1a5b5@linagora.com>
Date: Thu, 10 Dec 2020 19:24:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <160139528034.2924.9672441697416964848@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/ogRQqmmyb25wIdH1ckobSGQ70KY>
Subject: Re: [Jmap] Murray Kucherawy's No Objection on draft-ietf-jmap-mdn-15: (with COMMENT)
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2020 18:31:02 -0000

> There are several places in the document where "header" should be changed to
> "header field".
Done
>
> In Section 2.1, I think this could be a bit clearer:
>
> OLD:
>
> The following already registered SetError would mean:
>
> NEW:
>
> In this context, the existing SetError values defined in [reference] are
> interpreted as follows:
Done
>
> In Sections 2.1 and 2.2:
>
> This is totally a personal nit, and you're free to ignore me, but since I keep
> tripping on it I'll mention it: In various places, "id" is used as a word
> rather than an initialism, as in "The id of the account to use."  I keep
> reading this as the English term from psychoanalysis rather than a truncation
> of "identifier".  I'd probably be happier if the full word was used.  Also, in
> the first bullet of Section 2, it's capitalized as "Id"; we should probably be
> consistent.
"id" is used everywhere in the RFC8620 and RFC8621 so I prefer to keep 
it for consistency. I have replaced some "Id" which should mean the Id 
data type by "id" where appropriate.
>
> In Section 3:
>
> a) s/guaranty/guarantee/ (multiple instances)
Not fixing it, as it has the old meaning and it's taken from an example 
of RFC8098.
>
> b) There's an extension in Section 3.1 starting with "X-" that should probably
> be revisited given BCP 178.
Fixed;