[Jmap] Benjamin Schwartz comments on draft-ietf-jmap-websocket-05

"Alexey Melnikov" <aamelnikov@fastmail.fm> Fri, 21 February 2020 12:46 UTC

Return-Path: <aamelnikov@fastmail.fm>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 34F7D120828 for <jmap@ietfa.amsl.com>; Fri, 21 Feb 2020 04:46:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmail.fm header.b=Ep4oDM+Y; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=S4bl+UoO
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n4hLZ63JsTbn for <jmap@ietfa.amsl.com>; Fri, 21 Feb 2020 04:46:01 -0800 (PST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 73F631200D6 for <jmap@ietf.org>; Fri, 21 Feb 2020 04:46:01 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A414921EC3; Fri, 21 Feb 2020 07:46:00 -0500 (EST)
Received: from imap21 ([10.202.2.71]) by compute7.internal (MEProxy); Fri, 21 Feb 2020 07:46:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= mime-version:message-id:date:from:to:cc:subject:content-type :content-transfer-encoding; s=fm2; bh=C0obK5UvuqDhtzM+EaUT9z7xBu ZVhyixN4wdAiiRJn4=; b=Ep4oDM+YfFc6jGLW+AGaC6xzUmPHF9+cpDeRlfTzB/ B7r7p2EwpSn1HJw+5hbU+WBtNtKIuVrxm+3qKhn4F9TOyA7wCp7vCwC2mNkuLaXr L5qQiYJc0JBdZXoHupbG8fXa8LNuIZ4RGFogXIMaTaoEHeeSLaK4GGM5jpvXU73o PbCjHD1ZAJ8JnEahNoA4ODLU7Q23s6Z9dgnvNTKYZPdmfxg1/IhW90/Pc6c8DVrX rf4/sub3RGe/hKB5DcPODTKQnMaevuwfd0yfOUnJhjHycsiZEI5+InpTOT0uT/Xf vUWxy77RK6uSuOCGOP9bvEBfDzV5C7PuNWMuOqHMW86A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=C0obK5 UvuqDhtzM+EaUT9z7xBuZVhyixN4wdAiiRJn4=; b=S4bl+UoOTZF/etzU24Ted+ 0/g8kYR/c2PZ0MObdnnA40hl88nyX+o7aj1NvgGVS4tSqixodbnb794gI7q+CS3Q h1QVJ6MkHVHqqXAwD8htDj8sTK4iEUkcGXag012HgJ988S14JJrflE+OOuZKzYb8 gdSXlLVXz7TwNcsVFEcAGlp3SmuEvHrTUa0mWTWdrUiZ90sX71kMEuTuiolxzSmS lSSUabqt5t+bWr/iizBSZgGZ5DOPGQhePDiSSOfYAWpLm0A5EDmlMMx8UeHzBUBu GbHB1AOGDQXtqFl9NtkXRgdRDN++nhx+Di5kLy2fijHq/OF31UAkjQLrztvHPacQ ==
X-ME-Sender: <xms:CNFPXjflZcfFdEmNBePVGdqr3wBTicDPo8DGRZZdjmsi-VaREMz4kA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkeeggdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdetlhgvgigv hicuofgvlhhnihhkohhvfdcuoegrrghmvghlnhhikhhovhesfhgrshhtmhgrihhlrdhfmh eqnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprggr mhgvlhhnihhkohhvsehfrghsthhmrghilhdrfhhm
X-ME-Proxy: <xmx:CNFPXvN5CEz8hO6i3pxRzef7I19SigFreg9Xw22ZwXTeLK_RmH1wTg> <xmx:CNFPXnWn8LZfvO9D24zdSZUD2pZhCmOzhgW7P_LtEQ13A-jvfUYlXQ> <xmx:CNFPXnx7OLPvOS3JrSDDRg9h9ZiSJMO4UhOmAwy1EhD2wtzr1ypopw> <xmx:CNFPXlO17vHPUXYS0PfPU4pobD4m6q1SQDhLTEwkOyQQlIpeoRqGnw>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6659B660069; Fri, 21 Feb 2020 07:46:00 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-802-g7a41c81-fmstable-20200203v1
Mime-Version: 1.0
Message-Id: <0f7388d8-b420-469f-8d5a-da5fb0bcf27a@www.fastmail.com>
Date: Fri, 21 Feb 2020 12:45:20 +0000
From: Alexey Melnikov <aamelnikov@fastmail.fm>
To: Ken Murchison <murch@fastmail.com>, Benjamin Schwartz <bemasc@google.com>
Cc: jmap@ietf.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/r-nan1Tl9juqEirB9rgwEWA2jag>
Subject: [Jmap] Benjamin Schwartz comments on draft-ietf-jmap-websocket-05
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 12:46:11 -0000

Hi,

**********************************************************************
* Note, that I am conducting an experiment when people aspiring to be*
* Area Directors get exposed to AD work ("AD shadowing experiment"). *
* As a part of this experiment they get to review documents on IESG  *
* telechats according to IESG Discuss criteria document and their    *
* comments get relayed pretty much verbatim to relevant editors/WGs. *
* As an AD I retain responsibility in defending their position when  *
* I agree with it.                                                   *
* Recipients of these reviews are encouraged to reply to me directly * 
* about perceived successes or failures of this experiment.          *
**********************************************************************

I also have some comments on Benjamin's comments below marked with "[[Alexey]]:"


The following comments were provided by Benjamin Schwartz <bemasc@google.com>:

Benjamin would have balloted *YES* on this document. He wrote:

## Section 3


Consider removing “webSocket” from the parameter names.  It is redundant within this context.


## Section 4


   Binary data MUST NOT be uploaded or downloaded
   through a WebSocket JMAP connection.


Please provide a motivation for this restriction.

[[Alexey: In standard JMAP these operations are performed on special HTTPS endpoints, so no JMAP objects are exchanged there. This document just does the same.]]

## Section 4.1


I would suggest replacing this MUST with a simple reference to Section 8.2, which can contain its own normative language.

[[Alexey: Ben, can you clarify why you suggest pointing to Section 8.2? Is this in another RFC?]]

## Section 4.3.2


Is “@type” now required on all Request/Response/Problem Details objects everywhere?  Does this update RFC 8620?

---------------------

Best Regards,
Alexey