[jose] AD review of draft-ietf-jose-jwk-thumbprint-04
Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com> Mon, 20 April 2015 19:23 UTC
Return-Path: <kathleen.moriarty.ietf@gmail.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF14C1B310C for <jose@ietfa.amsl.com>; Mon, 20 Apr 2015 12:23:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3qIzZPg7WZFP for <jose@ietfa.amsl.com>; Mon, 20 Apr 2015 12:23:43 -0700 (PDT)
Received: from mail-lb0-x232.google.com (mail-lb0-x232.google.com [IPv6:2a00:1450:4010:c04::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 094D61B3108 for <jose@ietf.org>; Mon, 20 Apr 2015 12:23:43 -0700 (PDT)
Received: by lbcga7 with SMTP id ga7so138807636lbc.1 for <jose@ietf.org>; Mon, 20 Apr 2015 12:23:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Yd108CMPBETa28UZf76Jpx+3ynER9DP1MeYR9bvswIQ=; b=kcukd58BTGIX5dz+QkIZ/Pw87WeS7yv/uldrd21POk9h4IHR+1K+2gdrmjAxviG6dh caXuXnynIL3QR8Y068tCvLYX8cmLylsH+vHcSeHb5bxJUsXvfYCdKxrb9dGoI7LS82xM YOaxtMp5dlgYoZ4B9xj8wy9oCETOPXSF7a0tZTLqXSVckz01mDB34SWBP4tGxutpp0Yc aoP7pjLzdB1x65rLvX2q9Lv1Z3ffMUsH5V42DM/ewU0SkzjcRacRtypHKFTvC726NhfH wA7W8dMhtlkNuKRmmgBdc1TQXFiYavo8vF6hwtQmOwzuwZGPtgV6iHj5Te0C0szRFmlg dfMw==
MIME-Version: 1.0
X-Received: by 10.152.121.42 with SMTP id lh10mr17409582lab.0.1429557821436; Mon, 20 Apr 2015 12:23:41 -0700 (PDT)
Received: by 10.112.11.199 with HTTP; Mon, 20 Apr 2015 12:23:41 -0700 (PDT)
Date: Mon, 20 Apr 2015 15:23:41 -0400
Message-ID: <CAHbuEH4UfvUJtRE8Nj3vQv2B+yGKjPqi10+vSZoTvE4KYu79og@mail.gmail.com>
From: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
To: "jose@ietf.org" <jose@ietf.org>
Content-Type: multipart/alternative; boundary="089e0117748521fd5d05142cdece"
Archived-At: <http://mailarchive.ietf.org/arch/msg/jose/5L7oFJKALv_W7zEGZvCHcqSLncE>
Subject: [jose] AD review of draft-ietf-jose-jwk-thumbprint-04
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Apr 2015 19:23:45 -0000
Hi, Thanks for your work on draft-ietf-jose-jwk-thumbprint-04. This is the last one, right? Great job getting through the JOSE work! I read through the draft and have mostly editorial comments that I'd like to see if we can fix. Section 2: The definition needs some tweaking: JWK Thumbprint The digest value for a key that is the subject of this specification. "the subject of this specification" should not part of text for a definition. The definition needs to clearly explain the term without having to read the whole specification. Can you suggest something else? Section 4: Can you break this sentence into 2: However, if new JWK members are defined that use non-ASCII member names, their definitions should specify the exact Unicode code point sequences used to represent them, particularly in cases in which Unicode normalization could result in the transformation of one set of code points into another under any circumstances. Can you get rid of the parens around the second sentence? Use of escaped characters in JWKs for which JWK Thumbprints will be computed should be avoided. (Use of escaped characters in the hash input JWKs derived from these original JWKs is prohibited.) Can you reword this sentence/paragraph? I had to read it multiple times. While I understand what you are saying, it could be easier to read. While there is a natural representation to use for numeric values that are integers, this specification does not attempt to define a standard representation for numbers that are not integers or that contain an exponent component. This is not expected to be a problem in practice, as the required members of JWK representations are not expected to use numbers that are not integers. General comment, the use of long sentences and frequency of parens make the draft more difficult to read. Thanks! -- Best regards, Kathleen
- [jose] AD review of draft-ietf-jose-jwk-thumbprin… Kathleen Moriarty
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Kathleen Moriarty
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Mike Jones
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Kathleen Moriarty
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Jim Schaad
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Kathleen Moriarty
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Mike Jones
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Kathleen Moriarty
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Jim Schaad
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Stephen Farrell
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Kathleen Moriarty
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Mike Jones
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Jim Schaad
- Re: [jose] AD review of draft-ietf-jose-jwk-thumb… Kathleen Moriarty