Re: [jose] Secdir review of draft-ietf-jose-json-web-signature-31

Mike Jones <Michael.Jones@microsoft.com> Tue, 23 September 2014 23:43 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EA0A71A6F2A; Tue, 23 Sep 2014 16:43:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f2IhxXH8tXZ4; Tue, 23 Sep 2014 16:43:23 -0700 (PDT)
Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0148.outbound.protection.outlook.com [207.46.100.148]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50F791A6F1E; Tue, 23 Sep 2014 16:43:23 -0700 (PDT)
Received: from CO2PR03CA0016.namprd03.prod.outlook.com (10.141.194.143) by DM2PR03MB398.namprd03.prod.outlook.com (10.141.84.140) with Microsoft SMTP Server (TLS) id 15.0.1034.13; Tue, 23 Sep 2014 23:43:22 +0000
Received: from BN1AFFO11FD033.protection.gbl (2a01:111:f400:7c10::179) by CO2PR03CA0016.outlook.office365.com (2a01:111:e400:1414::15) with Microsoft SMTP Server (TLS) id 15.0.1034.13 via Frontend Transport; Tue, 23 Sep 2014 23:43:22 +0000
Received: from mail.microsoft.com (131.107.125.37) by BN1AFFO11FD033.mail.protection.outlook.com (10.58.52.246) with Microsoft SMTP Server (TLS) id 15.0.1029.15 via Frontend Transport; Tue, 23 Sep 2014 23:43:21 +0000
Received: from TK5EX14MBXC286.redmond.corp.microsoft.com ([169.254.1.23]) by TK5EX14HUBC107.redmond.corp.microsoft.com ([157.54.80.67]) with mapi id 14.03.0195.002; Tue, 23 Sep 2014 23:43:12 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Tero Kivinen <kivinen@iki.fi>
Thread-Topic: Secdir review of draft-ietf-jose-json-web-signature-31
Thread-Index: AQHPyDgrWdMUgOdf8EqNa4N9Ytbe4ZvzQwoggARGNkCADAcqAIAFVMkQgARgVwCAAjoeEA==
Date: Tue, 23 Sep 2014 23:43:11 +0000
Message-ID: <4E1F6AAD24975D4BA5B16804296739439BA6F684@TK5EX14MBXC286.redmond.corp.microsoft.com>
References: <21512.21725.209461.976375@fireball.kivinen.iki.fi> <4E1F6AAD24975D4BA5B16804296739439AEABA21@TK5EX14MBXC292.redmond.corp.microsoft.com> <21528.638.485017.482257@fireball.kivinen.iki.fi> <4E1F6AAD24975D4BA5B16804296739439BA5A04D@TK5EX14MBXC286.redmond.corp.microsoft.com> <21536.10026.506235.155913@fireball.kivinen.iki.fi>
In-Reply-To: <21536.10026.506235.155913@fireball.kivinen.iki.fi>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [157.54.51.78]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:131.107.125.37; CTRY:US; IPV:NLI; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(438002)(13464003)(189002)(199003)(377454003)(85306004)(77982003)(47776003)(46102003)(81156004)(50466002)(106116001)(90102001)(106466001)(21056001)(31966008)(85852003)(110136001)(120916001)(20776003)(107046002)(93886004)(46406003)(77096002)(76482002)(230783001)(86612001)(80022003)(4396001)(97736003)(2656002)(85806002)(92566001)(87936001)(84676001)(44976005)(92726001)(99396002)(104016003)(33656002)(55846006)(66066001)(6806004)(95666004)(50986999)(79102003)(81542003)(68736004)(86362001)(19580395003)(19580405001)(74502003)(74662003)(23726002)(76176999)(83072002)(10300001)(69596002)(64706001)(54356999)(97756001)(81342003)(83322001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR03MB398; H:mail.microsoft.com; FPR:; MLV:sfv; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en;
X-Microsoft-Antispam: UriScan:;
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB398;
X-O365ENT-EOP-Header: Message processed by - O365_ENT: Allow from ranges (Engineering ONLY)
X-Forefront-PRVS: 0343AC1D30
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates 131.107.125.37 as permitted sender) receiver=protection.outlook.com; client-ip=131.107.125.37; helo=mail.microsoft.com;
Authentication-Results: spf=pass (sender IP is 131.107.125.37) smtp.mailfrom=Michael.Jones@microsoft.com;
X-OriginatorOrg: microsoft.onmicrosoft.com
Archived-At: http://mailarchive.ietf.org/arch/msg/jose/J5mJdOznV-kMDP0KKT4qS4MOVr4
Cc: "jose@ietf.org" <jose@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "iesg@ietf.org" <iesg@ietf.org>, "draft-ietf-jose-json-web-signature.all@tools.ietf.org" <draft-ietf-jose-json-web-signature.all@tools.ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Subject: Re: [jose] Secdir review of draft-ietf-jose-json-web-signature-31
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Sep 2014 23:43:26 -0000

Thanks again for your review, Tero.  The resolutions discussed in this thread have been applied to the -32 draft.

				-- Mike

-----Original Message-----
From: Tero Kivinen [mailto:kivinen@iki.fi] 
Sent: Monday, September 22, 2014 6:42 AM
To: Mike Jones
Cc: iesg@ietf.org; secdir@ietf.org; ietf@ietf.org; draft-ietf-jose-json-web-signature.all@tools.ietf.org; jose@ietf.org
Subject: RE: Secdir review of draft-ietf-jose-json-web-signature-31

Mike Jones writes:
> Tero - for your point "2) Hash inside "alg" and inside the signature", 
> could you please write proposed security considerations text 
> addressing this issue?  I'd think it should describe the need for 
> implementations to ensure that signature verification is done for the 
> exact algorithm specified in the "alg" header parameter, no matter 
> what algorithm information may (or may not) have been encoded into the 
> signature value in an algorithm-specific manner.

Something like this:

  In case of algorithms where there is algorithm parameters specified
  also inside the actual signature, the implementations MUST verify
  that the parameters inside the signature and the parameters
  specified by the "alg" Header Parameter match. This includes for
  example the RSASSA-PKCS-v1_5 algorithms ("RS*") where the signature
  contains the hash algorithm and most libraries actually use the hash
  algorithm specified inside the signature when verifying the
  signature. This test is required as the steps in the section 5.2
  verify that algorithms specified by the "alg" Header Parameter are
  acceptable, and if those algorithms could be different the attacker
  could be able to claim to use strong hash algorithm while actually
  using weak one inside the signature. 

> For your point "3) There is no explicit warning about the "alg"
> "none"", I plan to add the additional step that you suggested.

In my text above I assumed you had already added step in section 5.2 to verify that "alg" is acceptable. 

> For your point "4) Thumbprint formats" if you or someone else wants to 
> define an additional thumbprint format for use in IoT contexts (or any 
> other contexts), I encourage you to write an Internet Draft that does 
> so, registering the new header parameter defined in the JSON Web 
> Signature and Encryption Header Parameters registry.

That can of course be done, but I would have hoped the initial version of the specification would also be usable in the IoT context, where the use of raw public keys will most likely arise.
--
kivinen@iki.fi