Re: [jose] Gen-ART LC review of draft-ietf-jose-json-web-algorithms-31

Mike Jones <Michael.Jones@microsoft.com> Thu, 04 September 2014 19:31 UTC

From: Mike Jones <Michael.Jones@microsoft.com>
To: Roni Even <ron.even.tlv@gmail.com>, "draft-ietf-jose-json-web-algorithms.all@tools.ietf.org" <draft-ietf-jose-json-web-algorithms.all@tools.ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART LC review of draft-ietf-jose-json-web-algorithms-31
Thread-Index: Ac/F2mpuDG6JcxI/SbuImTKmZa3+rwCmp0KQ
Date: Thu, 04 Sep 2014 19:30:57 +0000
Message-ID: <4E1F6AAD24975D4BA5B16804296739439AE82354@TK5EX14MBXC294.redmond.corp.microsoft.com>
References: <013201cfc5da$6c34dd60$449e9820$@gmail.com>
In-Reply-To: <013201cfc5da$6c34dd60$449e9820$@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/alternative; boundary="_000_4E1F6AAD24975D4BA5B16804296739439AE82354TK5EX14MBXC294r_"
MIME-Version: 1.0
Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates 131.107.125.37 as permitted sender) receiver=protection.outlook.com; client-ip=131.107.125.37; helo=mail.microsoft.com;
Archived-At: http://mailarchive.ietf.org/arch/msg/jose/eYYx_YdhrA0S2k_lyBL0wXBV8do
Cc: "ietf@ietf.org" <ietf@ietf.org>, "jose@ietf.org" <jose@ietf.org>
Subject: Re: [jose] Gen-ART LC review of draft-ietf-jose-json-web-algorithms-31
Precedence: list

Thanks for the review, Roni.  I'm also cc'ing the working group so they're aware of your review.  Replies are inline below...

From: Roni Even [mailto:ron.even.tlv@gmail.com]
Sent: Monday, September 01, 2014 4:47 AM
To: draft-ietf-jose-json-web-algorithms.all@tools.ietf.org; gen-art@ietf.org
Cc: ietf@ietf.org
Subject: Gen-ART LC review of draft-ietf-jose-json-web-algorithms-31

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
Please resolve these comments along with any other Last Call comments you may receive.

Document:  draft-ietf-jose-json-web-algorithms-31

Reviewer: Roni Even

Review Date:2014-9-1

IETF LC End Date: 2014-9-3

IESG Telechat date:

Summary: This draft is ready for publication as a standard track RFC.

Major issues:

Minor issues:

Nits/editorial comments:

  1.  Section 4.8 "This section defines the specifies" should be "specifics"

Thanks

  1.  Section 5.2.2 "Section 5.2.3 and Section 5.2.5" should be "through" since 5.2.4 also defines instances.

Agreed

  1.  Section 5.2.2.1 in bullet 1 "the values of these parameters are specified by the AEAD algorithms (in Section 5.2.3 and Section 5.2.5)". Did you mean AEAD in which case is should be expanded and a reference is probably needed or do you need to change it to Authenticated Encryption? Also the "and" should be "through" same as previous comment.

Yes, the "AEAD" should become "Authenticated Encryption" to be consistent with the rest of the spec.  And agreed about "through".

  1.  In section 5.2.2.1 bullet 4 for "number of bits in A" I had to go to bullet 5 to see what A is. Maybe add also here "additional authenticated data"

"A" is defined in the first sentence of 5.2.2.1 as "additional authenticated data".  But there would be no harm the addition you propose.  Knowing that it's defined in the first sentence, do you still want to see the addition?

                                                                Thanks again,
                                                                -- Mike

Re: [jose] Gen-ART LC review of draft-ietf-jose-j… Mike Jones
Re: [jose] Gen-ART LC review of draft-ietf-jose-j… Roni Even
Re: [jose] Gen-ART LC review of draft-ietf-jose-j… Mike Jones
Re: [jose] [Gen-art] Gen-ART LC review of draft-i… Jari Arkko