[jose] AD Review of draft-ietf-jose-cfrg-curves

Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com> Fri, 29 July 2016 01:34 UTC

Return-Path: <kathleen.moriarty.ietf@gmail.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAC2812B059 for <jose@ietfa.amsl.com>; Thu, 28 Jul 2016 18:34:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0YJL7eWx6tpO for <jose@ietfa.amsl.com>; Thu, 28 Jul 2016 18:34:02 -0700 (PDT)
Received: from mail-ua0-x235.google.com (mail-ua0-x235.google.com [IPv6:2607:f8b0:400c:c08::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 72E7512B02A for <jose@ietf.org>; Thu, 28 Jul 2016 18:34:02 -0700 (PDT)
Received: by mail-ua0-x235.google.com with SMTP id j59so52171898uaj.3 for <jose@ietf.org>; Thu, 28 Jul 2016 18:34:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=8DewkUyPp/rIgIPlcdvOWgLse6RrXIK0y1HwV+PDrdI=; b=TAqI8+hNPyJ2nr8VmBc41PvmlNBKUWwscLW5trOQ+CoRkU+WCYMQA8VOy62o9VMnFy QMi7AbtoiC/6bkcMAnlCYcQ7p24e78TkArH+gCMDYdP3RagIF6kLdHjA8NsZDHUYjyIF qsUWnboiI2u74lrCUnPhY8FdZjhALIfVL0r5h48wKZo+XYu1/v3v24r6tMHKfm+7Y1+r ygYIHGst+LHxRzv73dUsoBnaOodfwYYQm2PvuYTaIf1zig7cdGjZhBSwdOiO8W9w/T6y IAOrA87ssRTJcWHrKdII34eNp70rTAvieCysQvcryNbeCO9C0JOuAPB94kF/h1oc0awV +Yww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8DewkUyPp/rIgIPlcdvOWgLse6RrXIK0y1HwV+PDrdI=; b=h/XulrMuUJ2KiAGTnVqygVuIGdH32OT0H3kOnbzWdfivHaEOhzcDvhoJhQNpneJyE+ c7J9XSgA/ajrpAzNTHNfIqb6a4/YK7QS2Yh7DEbJQQti383vkJBKhwEiiW5FG6+q4bxp YQFFrGHX/jkW6alPAPP3LVRuPgfG9nSaGJ9yrJ7kH1V5aEG23OAl6CpXJo7tq8vb4ZwN 1tpyE3sl50st9erb1H/EK49CmzvOfN/4iVHoSoPmW7t4+p2XBA20WTAGOI7nafiWrgw0 tSmlgMw0aIR/tng/f/iOtVy/fKzjfw+8XKftAIYZWnO21ZLHHgT94dLjr9ht7yqFIsXu ppuQ==
X-Gm-Message-State: AEkooutN/sdDjL0tpCSXEYD9BUp7xOSws8bS7uIbig0+y4s30vVakJqQHN12ttG00cdO3vXm/FJbd0mSInU5jg==
X-Received: by 10.159.33.248 with SMTP id 111mr14260455uac.99.1469756041434; Thu, 28 Jul 2016 18:34:01 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.159.37.104 with HTTP; Thu, 28 Jul 2016 18:34:01 -0700 (PDT)
From: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
Date: Thu, 28 Jul 2016 21:34:01 -0400
Message-ID: <CAHbuEH5Ctht=acuh+84G8_uF+y-8-OJ17PPbzD5e7bEKD_6u=A@mail.gmail.com>
To: "jose@ietf.org" <jose@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/jose/xQ6uVDxOgxBHbG93iQ6laA77ad8>
Subject: [jose] AD Review of draft-ietf-jose-cfrg-curves
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2016 01:34:04 -0000

Hello,

Thank you for your work on draft-ietf-jose-cfrg-curves.  The draft
looks good, so I only have a couple of comments.

I just found a couple of nits that should be resolved.  I will kick
off IETF last call and these can be resolved along with IETF last call
comments.  I'll put this on the telechat 3 weeks from today, so any
changes will need to be made right as IETF last call ends before IESG
members start to review drafts.


Introduction, first paragraph, last sentence Nit:
   This
   document defines how those algorithms are to be used in JOSE in
   interoperable manner.
s/in interoperable manner/in an interoperable manner/

Second to last paragraph: I think you can leave this sentence out:
   (Trying to apply ECDSA
   to those curves leads to nasty corner-cases and produces odd
   results.)


Thank you!
-- 

Best regards,
Kathleen