Re: [jose] Deployed Code (was: Re: #23: Make crypto independent of binary encoding (base64))

Phil Hunt <phil.hunt@oracle.com> Thu, 13 June 2013 16:06 UTC

Return-Path: <phil.hunt@oracle.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E672721F9A10 for <jose@ietfa.amsl.com>; Thu, 13 Jun 2013 09:06:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.611
X-Spam-Level:
X-Spam-Status: No, score=-5.611 tagged_above=-999 required=5 tests=[AWL=-0.409, BAYES_00=-2.599, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=1.396, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vACi5qNNo6nn for <jose@ietfa.amsl.com>; Thu, 13 Jun 2013 09:06:13 -0700 (PDT)
Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by ietfa.amsl.com (Postfix) with ESMTP id 740E221F8617 for <jose@ietf.org>; Thu, 13 Jun 2013 09:06:13 -0700 (PDT)
Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5DG67f0001157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Jun 2013 16:06:08 GMT
Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5DG66aH008657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Jun 2013 16:06:07 GMT
Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5DG661d025442; Thu, 13 Jun 2013 16:06:06 GMT
Received: from [192.168.1.125] (/24.86.29.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 13 Jun 2013 09:06:05 -0700
References: <CAL02cgRLGaSGFqg6PUoz1KX+7jEjU7rwt-t7B=U0FvEqYZrU-w@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CAL02cgRLGaSGFqg6PUoz1KX+7jEjU7rwt-t7B=U0FvEqYZrU-w@mail.gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail-30371A70-891E-4035-977F-563CF030E073"
Content-Transfer-Encoding: 7bit
Message-Id: <C2C21851-DB8D-4B0A-B134-7C0686192270@oracle.com>
X-Mailer: iPhone Mail (10B329)
From: Phil Hunt <phil.hunt@oracle.com>
Date: Thu, 13 Jun 2013 09:06:04 -0700
To: Richard Barnes <rlb@ipv.sx>
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Cc: Mike Jones <Michael.Jones@microsoft.com>, "jose-chairs@tools.ietf.org" <jose-chairs@tools.ietf.org>, "<jose@ietf.org>" <jose@ietf.org>, George Fletcher <gffletch@aol.com>
Subject: Re: [jose] Deployed Code (was: Re: #23: Make crypto independent of binary encoding (base64))
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/jose>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jun 2013 16:06:20 -0000

Seems like many these days are in a rush. They call for consensus before discussing the issue. 

Isn't it up to the chair?

This isn't unique to this WG. 

Too many times the explanation for keeping an apparent 'feature/flaw' is 'because we don't want change'. Yet often the group can't explain it. Or worse, the group just says "we know the emperor has no clothes, we just don't feel the need to comment." This is where alarm bells go off for me. 

Phil

On 2013-06-13, at 7:35, Richard Barnes <rlb@ipv.sx> wrote:

> This would have been a nice discussion to have had 18 months ago, when we were getting started.
> 
> I don't think it's compatible with the IETF ethos to say "Changes to this document MUST NOT break existing code."  Otherwise, we're not doing engineering here, we're cleaning up documentation and rubber-stamping.
> 
> What would be acceptable is to say "Changes must break cleanly with existing code".  That is, it should be possible for a JWT implementation to, say, process both "legacy" JWS syntax and whatever comes out of this group.  That way, we could come to consensus on the best solution, incorporating lessons learned from earlier work without being hindered by them.
> 
> Would participants here consider it a acceptable for the output of this working group to be incompatible with existing JWT implementations, as long as it had the property that JW* objects in the new format could be clearly distinguished from "legacy" JW* objects, so that implementations could adapt their processing?
> 
> --Richard
> 
> 
> 
> 
> On Thu, Jun 13, 2013 at 10:24 AM, George Fletcher <gffletch@aol.com> wrote:
>> +1
>> 
>> Breaking deployed code as raised by Brian, Naveen and others is a critical consideration.
>> 
>> Thanks,
>> George
>> 
>> On 6/13/13 10:19 AM, Mike Jones wrote:
>>> Jim and Karen, could you please do as Richard suggests and close this issue as “won’t fix”.
>>> 
>>>  
>>> 
>>>                                                             Thank you,
>>> 
>>>                                                             -- Mike
>>> 
>>>  
>>> 
>>> From: Richard Barnes [mailto:rlb@ipv.sx] 
>>> Sent: Wednesday, June 12, 2013 1:57 PM
>>> To: jose-chairs@tools.ietf.org; Mike Jones
>>> Subject: Fwd: [jose] #23: Make crypto independent of binary encoding (base64)
>>> 
>>>  
>>> 
>>> In other words: Chairs, feel free to             close/wontfix :)
>>> 
>>>  
>>> 
>>> ---------- Forwarded message ----------
>>> From: Richard Barnes <rlb@ipv.sx>
>>> Date: Wed, Jun 12, 2013 at 4:55 PM
>>> Subject: Re: [jose] #23: Make crypto independent of binary encoding (base64)
>>> To: "Matt Miller (mamille2)" <mamille2@cisco.com>
>>> Cc: jose issue tracker <trac+jose@trac.tools.ietf.org>, "<draft-ietf-jose-json-web-encryption@tools.ietf.org>" <draft-ietf-jose-json-web-encryption@tools.ietf.org>, "<michael.jones@microsoft.com>" <michael.jones@microsoft.com>, "<jose@ietf.org>" <jose@ietf.org>
>>> 
>>> 
>>> To be clear, I structured my message in two parts for a reason, to separate the analysis from the opinion.  I acknowledge that I am but one voice here, and I'm increasingly hearing how alone I am :)
>>> 
>>>  
>>> 
>>> On Wed, Jun 12, 2013 at 4:23 PM, Richard Barnes <rlb@ipv.sx> wrote:
>>> 
>>> <impartial-analysis>
>>> 
>>> So just to be clear on the trade-off the WG has to make:
>>> 
>>>  
>>> 
>>> On the one hand: Breaking every existing JWT implementation in the world
>>> 
>>> On the other hand: Eternally binding ourselves to base64 encoding, even if binary-safe encodings become available (CBOR, MsgPack, etc.)
>>> 
>>> </impartial-analysis >
>>> 
>>>  
>>> 
>>> <personal-opinion>
>>> 
>>> I have some sympathy with JWT implementors.  It sucks to have to refactor code.  But I think we're literally talking about something like a 5-line patch.  And early JWT implementors knew or should have known (to use a DC phrase) that they were dealing with a draft spec.  As the W3C editor's draft template says, in big bold red print, "Implementors who are not taking part in the discussions are likely to find the specification changing out from under them in incompatible ways."
>>> 
>>>  
>>> 
>>> As PHB pointed out in the other thread, it would be nice to use JWS and JWE in place of CMS one day, without the base64 hit.  We should incur the implementation pain now, and get the design right for the long run.  Base64 is a hack around JSON; we should build the system so that when we no longer need that hack, it can go away.
>>> 
>>> </personal-opinion>
>>> 
>>>  
>>> 
>>> --Richard
>>> 
>>>  
>>> 
>>>  
>>> 
>>>  
>>> 
>>> On Wed, Jun 12, 2013 at 10:27 AM, Matt Miller (mamille2) <mamille2@cisco.com> wrote:
>>> 
>>> I did at first find it curious why the cryptographic operations were over the base64url-enccoded values, but I was also very focused on JWE, where I think the field separation problem is less of an issue (at least now).  For JWS, this would certainly cause problems without some manner of unambiguous field parameterization.
>>> 
>>> I will note that unescaped NULL is not valid in JSON, so it could be used as a separator between the encoded header and the payload.  I do find it interesting if JOSE could more easily and efficiently support other encodings.  However, I think that                                   while this is an interesting thought experiment, it seems we're too far down the path to seriously consider it unless the current state were shown to be horribly broken.
>>> 
>>> 
>>> - m&m
>>> 
>>> Matt Miller < mamille2@cisco.com >
>>> Cisco Systems, Inc.
>>> 
>>> 
>>> On Jun 11, 2013, at 6:01 PM, jose issue tracker <trac+jose@trac.tools.ietf.org> wrote:
>>> 
>>> > #23: Make crypto independent                                       of binary encoding (base64)
>>> >
>>> >
>>> > Comment (by michael.jones@microsoft.com):
>>> >
>>> > For both serializations, you already need the base64url encoded versions
>>> > of the JWS Header and the JWS Payload to preserve them in transmission, so
>>> > computing them isn't an extra burden.  In the JWS Compact Serialization,
>>> > you already need the concatenation of the Encoded JWS Header, a period
>>> > character, and the Encoded JWS Payload, so computing that                                       concatenation
>>> > isn't an extra burden.  Given you already have that quantity, computing
>>> > the signature over it is the easiest thing for developers to do, and it's
>>> > been shown to work well in practice.  There's no compelling reason to make
>>> > this change.
>>> >
>>> > Even for the JSON Serialization, the only "extra" step that's required to
>>> > compute the signature is the concatenation with the period character - to
>>> > prevent shifting of data from one field to the other, as described by Jim
>>> > Schaad in the e-mail thread.  So this step isn't actually "extra" at all -
>>> > it's necessary.  It's also highly advantageous to use exactly the same
>>> > computation for both serializations, which is currently the case.
>>> >
>>> > Since there is no compelling reason to make this change, and                                       since making
>>> > it could enable the "shifting" problem identified by Jim, it should not be
>>> > made.
>>> >
>>> > --
>>> > -------------------------+-------------------------------------------------
>>> > Reporter:  rlb@ipv.sx   |       Owner:  draft-ietf-jose-json-web-
>>> >     Type:  defect       |  encryption@tools.ietf.org
>>> > Priority:  major        |      Status:  new
>>> > Component:  json-web-    |   Milestone:
>>> >  encryption             |     Version:
>>> > Severity:  -            |  Resolution:
>>> > Keywords:               |
>>> > -------------------------+-------------------------------------------------
>>> >
>>> > Ticket URL: <http://trac.tools.ietf.org/wg/jose/trac/ticket/23#comment:2>
>>> > jose <http://tools.ietf.org/jose/>
>>> >
>>> 
>>> > _______________________________________________
>>> > jose mailing list
>>> > jose@ietf.org
>>> > https://www.ietf.org/mailman/listinfo/jose
>>> 
>>>  
>>> 
>>>  
>>> 
>>>  
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> jose mailing list
>>> jose@ietf.org
>>> https://www.ietf.org/mailman/listinfo/jose
>> 
>> -- 
>> <XeC>
> 
> _______________________________________________
> jose mailing list
> jose@ietf.org
> https://www.ietf.org/mailman/listinfo/jose