Re: [Json-canon] JSON Subtype handling. Re: Review of draft-rundgren-json-canonicalization-scheme-03

Jim Schaad <ietf@augustcellars.com> Sat, 09 February 2019 05:11 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: json-canon@ietfa.amsl.com
Delivered-To: json-canon@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E584913115A; Fri, 8 Feb 2019 21:11:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Yux3PtK_c8jA; Fri, 8 Feb 2019 21:10:59 -0800 (PST)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C2D48131151; Fri, 8 Feb 2019 21:10:58 -0800 (PST)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 8 Feb 2019 21:10:51 -0800
From: Jim Schaad <ietf@augustcellars.com>
To: 'Anders Rundgren' <anders.rundgren.net@gmail.com>
CC: draft-rundgren-json-canonicalization-scheme@ietf.org, 'Mark Nottingham' <mnot@mnot.net>, 'Samuel Erdtman' <samuel@erdtman.se>, 'Bret Jordan' <jordan.ietf@gmail.com>, json-canon@ietf.org
References: <00dc01d4b51c$618cdbc0$24a69340$@augustcellars.com> <f4b64343-e8db-57cf-152e-aeba44dc4863@gmail.com>
In-Reply-To: <f4b64343-e8db-57cf-152e-aeba44dc4863@gmail.com>
Date: Fri, 08 Feb 2019 21:10:48 -0800
Message-ID: <060401d4c035$d35d3e10$7a17ba30$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKM6YQQYC7r3DsdqZf77BCrHHAS2AJANXPspFSVrIA=
Content-Language: en-us
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/json-canon/agF4SSnBZI6RqwRqBBufiw3vcF0>
Subject: Re: [Json-canon] JSON Subtype handling. Re: Review of draft-rundgren-json-canonicalization-scheme-03
X-BeenThere: json-canon@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Canonicalization <json-canon.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/json-canon>, <mailto:json-canon-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/json-canon/>
List-Post: <mailto:json-canon@ietf.org>
List-Help: <mailto:json-canon-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/json-canon>, <mailto:json-canon-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Feb 2019 05:11:01 -0000

Anders,

Two items.  First note that I changed the address of the IETF mailing list as the "-request" should be omitted.  This sends mail to the administrator not to the list.

Second.  I like the text that you have placed in Appendix E as it seems to do a good job of both describing the problem and providing a solution.  The problem is that it provides two different solutions and the reference from section 3.1 does not state which of the two methods to use.  I think you probably want to state - "Use Appendix E.2 for creation of new items, but use Appendix E.1 when parsing and checking an existing JSON serialization."

Jim


> -----Original Message-----
> From: Anders Rundgren <anders.rundgren.net@gmail.com>
> Sent: Friday, February 8, 2019 8:54 PM
> To: Jim Schaad <ietf@augustcellars.com>
> Cc: draft-rundgren-json-canonicalization-scheme@ietf.org; json-canon-
> request@ietf.org; Mark Nottingham <mnot@mnot.net>; Samuel Erdtman
> <samuel@erdtman.se>; Bret Jordan <jordan.ietf@gmail.com>
> Subject: JSON Subtype handling. Re: Review of draft-rundgren-json-
> canonicalization-scheme-03
> 
> On 2019-01-26 03:10, Jim Schaad wrote:
> > Here are a set of comments on the current version of the draft.
> 
> Thank you very much for these insightful comments!
> 
> Since the comments were many I take the liberty splitting the responses in
> separate threads.
> 
> Handling of subtypes in JSON strings was clearly missing in the 03 draft.
> The 04 draft adds the following to section 3.1 "Creation of Input Data":
> 
>      Note: parsed String data MUST NOT be altered during subsequent
>      serializations.  For more information see Appendix E
> 
> The added Appendix E (https://tools.ietf.org/html/draft-rundgren-json-
> canonicalization-scheme-04#appendix-E)
> contains a pretty extensive description of how this must be dealt with.
> 
> A side-effect of this is that the updated draft now makes a distinction
> between "Hashable" JSON and "true" canonicalization ("Comparable" JSON).
> The latter is a more demanding deployment option.
> 
> Cheers,
> Anders