Re: [kitten] [Gen-art] Genart last call review of draft-ietf-kitten-pkinit-alg-agility-05
Alissa Cooper <alissa@cooperw.in> Thu, 07 March 2019 03:28 UTC
Return-Path: <alissa@cooperw.in>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5FA72128CB7; Wed, 6 Mar 2019 19:28:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=taqeSD8q; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=k2LnygQV
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EFY1iw87Wfg2; Wed, 6 Mar 2019 19:28:49 -0800 (PST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05F35124C04; Wed, 6 Mar 2019 19:28:49 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5511B22F5B; Wed, 6 Mar 2019 22:28:48 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 06 Mar 2019 22:28:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm2; bh=7QXfL72BuoaFdaKn6IL1BGq XaFbP+ctBCSnvbW5yvbA=; b=taqeSD8qKj3pvzmA4ZOlw0oKoKDURznaCcZuFx3 Qvy7ulzNU+wcYzTRFdQHfA1eP+ZOyGUk1VabaefeDHiLDnhhKAsafp/R5lL9NBqQ CKaLpsw69EAytMK/7MEH1VIsXUNBKO9tJFVLkQ2zfUj2ceXaxIub1KIMyES0Bu2J RvrH0PmngKeZDZNEfmJ0o9Cf8gUjSMzOz07x5wqKyOmarsYYPsKkcJ1a9lI0elfA spLKqd0gLaydWS5EmhGFx9QM0hvfwKbN3WQd1oi5xbyR+Alj2iU8vPgbeF+YBW8X 6MojGKp9KlMI9abmQ6pX69knQk3DSd3TzG1nDQrxOzGmRhg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7QXfL7 2BuoaFdaKn6IL1BGqXaFbP+ctBCSnvbW5yvbA=; b=k2LnygQVU4zZVAc9sNA8R7 EXFCne/SSGAdmYEV69elrKk77luAVaJRtbbvmPZeH0aeQeVsusUGvY9ukDR2Dfax LnePMOQPjbbK1BeOM+VpivXePb9gxbgYjmRJuhjYabumvYighNRwXKjF+90nqJl4 k6efs4i/hwzNfJmeLPQB2RBtIjBYpCDcynVAAedwA1bkG86phwv0/A8gkxkRGxHt lj5HpiavBmXZ5FcomMTVgSPNuFBag74jQsrpJWMfh+dzxs76mhdbnigZIZjPFghA wbBuj4fRwubRl1T7I7yNj/AO16gJM0WCfhpnTQQifOATY5qBvpWdLrIS7EUqeMkQ ==
X-ME-Sender: <xms:74-AXPJ4XR6EpaabGnwjL5YYHqMxZUH8SGzfrOhiSbk_n_sc1Vq2lQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeejgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhkfgtggfuffgjvfhfofesrgdtmherhhdtvdenucfhrhhomheptehlihhsshgr ucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrghinh epihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrjeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhnnecuvehluhhsthgvrh fuihiivgeptd
X-ME-Proxy: <xmx:74-AXGKv0X-7_EWnR_XnPT1HXYCn17f7Rz5pNVWZwf-EZUgQtigUIQ> <xmx:74-AXAxVGPsFz4FCS4pWiRxf1PzUhOzkrDPzh0HDdGxxxFWvVkaxbA> <xmx:74-AXKKPcgcFTXXmWcqzaVTyEBGDqFZccaZi1oZWZdm9bxnXGt64GQ> <xmx:8I-AXO8dJob8lx-zGoG9QHKNLBI-4Ze-WAA7c0uAmdjhYWy14inJgg>
Received: from rtp-alcoop-nitro5.cisco.com (unknown [173.38.117.74]) by mail.messagingengine.com (Postfix) with ESMTPA id CC222100E5; Wed, 6 Mar 2019 22:28:46 -0500 (EST)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <486D3AB5-43B2-4CF6-90FB-C0F9CE534DEE@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_DCA4267F-6234-4649-A796-E993BB3B86D9"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 06 Mar 2019 22:28:44 -0500
In-Reply-To: <jlgo96nd8fi.fsf@redhat.com>
Cc: Brian E Carpenter <brian.e.carpenter@gmail.com>, General Area Review Team <gen-art@ietf.org>, kitten@ietf.org, IETF <ietf@ietf.org>, draft-ietf-kitten-pkinit-alg-agility.all@ietf.org
To: Robbie Harwood <rharwood@redhat.com>, Christer Holmberg <christer.holmberg@ericsson.com>
References: <155142941301.6207.9229636209459945659@ietfa.amsl.com> <jlgo96nd8fi.fsf@redhat.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/kitten/9AAVMAiUshFD3N5uawTZ8EbFVyM>
Subject: Re: [kitten] [Gen-art] Genart last call review of draft-ietf-kitten-pkinit-alg-agility-05
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 03:28:51 -0000
Christer, thank you for your review. Robbie and Greg, thanks for your responses. I entered a No Objection ballot. Alissa > On Mar 6, 2019, at 4:01 PM, Robbie Harwood <rharwood@redhat.com> wrote: > > Christer Holmberg <christer.holmberg@ericsson.com <mailto:christer.holmberg@ericsson.com>> writes: > >> Reviewer: Christer Holmberg >> Review result: Ready with Issues >> >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please treat these comments just >> like any other last call comments. >> >> For more information, please see the FAQ at >> >> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. >> >> Document: draft-ietf-kitten-pkinit-alg-agility-05 >> Reviewer: Christer Holmberg >> Review Date: 2019-03-01 >> IETF LC End Date: 2019-02-17 >> IESG Telechat date: 2019-03-07 >> >> Summary: The draft needs to be more clear on how RFC 4556 is updated. >> >> Major issues: None >> >> Minor issues: >> >> Q1: >> >> For the unfamiliar reader, it is unclear exactly how RFC 4556 is updated. There >> is e.g., no text indicating what sections of 4556 are updated, and there is no >> "Updates to RFC 4556" section. >> >> I assume the remainder of the draft then updates RFC 4556, but I think it needs >> to be more clear for the unfamiliar reader. >> >> Even if a "Updates to RFC 4556" section would not be feasible, the document >> should indicate what parts/sections of 4556 are updated, and what sections in >> the draft defines those updates. >> >> Nits/editorial comments: >> >> Q2: >> >> Both the Abstract and the Introduction start with "This document updates >> PKINIT,..." >> >> I think it would be good to first give some background information on the >> issue(s), and then state that the document fixes those issues by updating RFC >> 4556. > > Hi Christer, thanks for your review. > > Greg has created and uploaded a new version (-06) to the tracker that > hopefully addresses your concerns. > > Thanks, > --Robbie > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org <mailto:Gen-art@ietf.org> > https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>
- [kitten] Genart last call review of draft-ietf-ki… Christer Holmberg
- Re: [kitten] Genart last call review of draft-iet… Robbie Harwood
- Re: [kitten] [Gen-art] Genart last call review of… Alissa Cooper