Re: [kitten] shepherd review of draft-aes-cts-hmac-sha2-09

Luke Howard <lukeh@padl.com> Mon, 27 June 2016 09:17 UTC

Return-Path: <lukeh@padl.com>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38F4712D10B for <kitten@ietfa.amsl.com>; Mon, 27 Jun 2016 02:17:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.328
X-Spam-Level:
X-Spam-Status: No, score=-3.328 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-1.426, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t2ePwO_yfv8C for <kitten@ietfa.amsl.com>; Mon, 27 Jun 2016 02:17:49 -0700 (PDT)
Received: from us.padl.com (us.padl.com [216.154.215.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A605F12D0EA for <kitten@ietf.org>; Mon, 27 Jun 2016 02:17:49 -0700 (PDT)
Received: by us.padl.com with ESMTP id u5R9Hh5h023819; Mon, 27 Jun 2016 05:17:46 -0400
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Luke Howard <lukeh@padl.com>
In-Reply-To: <alpine.GSO.1.10.1606261730110.18480@multics.mit.edu>
Date: Mon, 27 Jun 2016 19:17:49 +1000
Content-Transfer-Encoding: quoted-printable
Message-Id: <5596DB1C-B1AA-4C5B-94B6-3FA033B8161E@padl.com>
References: <alpine.GSO.1.10.1606261730110.18480@multics.mit.edu>
To: Benjamin Kaduk <kaduk@mit.edu>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/kitten/Cvhv1r-i2m2GOfqD6be7Y02U0VY>
Cc: "kitten@ietf.org" <kitten@ietf.org>, draft-ietf-kitten-aes-cts-hmac-sha2@tools.ietf.org
Subject: Re: [kitten] shepherd review of draft-aes-cts-hmac-sha2-09
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jun 2016 09:17:51 -0000

> The one item which would potentially affect the actual protocol: at the
> end of Section 5, the pseudo-random function seems to be using a SP800-108
> KDF but omits the zero byte between label and context.  I think it would
> be better to have the zero byte -- do you remember whether there was a
> reason to omit it?  (Adding the zero byte would require re-rolling some
> test vectors, to be clear.)

The PRF is defined in terms of KDF-HMAC-SHA2() which implicitly inserts the zero byte when invoking HMAC-SHA-256(), e.g.:

	PRF = KDF-HMAC-SHA2(base-key, "prf" | octet-string, 256)
	= k-truncate(HMAC-SHA-256(key, 0x00000001 | "prf" | octet-string | 0x00 | 256))

if I’m not mistaken? Pretty sure our implementation passed the test vectors.

— Luke