Re: [kitten] New Version Notification for draft-kaduk-kitten-gss-loop-01.txt (fwd)

mrex@sap.com (Martin Rex) Thu, 21 November 2013 02:35 UTC

Return-Path: <mrex@sap.com>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CA5C1ADED9 for <kitten@ietfa.amsl.com>; Wed, 20 Nov 2013 18:35:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.552
X-Spam-Level:
X-Spam-Status: No, score=-6.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_DE=0.35, RCVD_IN_DNSWL_HI=-5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id se4H8aN7y1jy for <kitten@ietfa.amsl.com>; Wed, 20 Nov 2013 18:35:20 -0800 (PST)
Received: from smtpde02.sap-ag.de (smtpde02.sap-ag.de [155.56.68.140]) by ietfa.amsl.com (Postfix) with ESMTP id 9BA461A1F3F for <kitten@ietf.org>; Wed, 20 Nov 2013 18:35:20 -0800 (PST)
Received: from mail05.wdf.sap.corp by smtpde02.sap-ag.de (26) with ESMTP id rAL2ZCmh023157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Nov 2013 03:35:12 +0100 (MET)
In-Reply-To: <20131121012342.29CE81AACA@ld9781.wdf.sap.corp>
To: mrex@sap.com
Date: Thu, 21 Nov 2013 03:35:12 +0100
X-Mailer: ELM [version 2.4ME+ PL125 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"
Message-Id: <20131121023512.A7EA11AACA@ld9781.wdf.sap.corp>
From: mrex@sap.com
X-SAP: out
Cc: kitten@ietf.org
Subject: Re: [kitten] New Version Notification for draft-kaduk-kitten-gss-loop-01.txt (fwd)
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: mrex@sap.com
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Nov 2013 02:35:23 -0000

Martin Rex wrote:
> Martin Rex wrote:
> > > 
> > > (*) I also noticed that ~all of Appendix A of RFC 2744 (the sample 
> > > gssapi.h header) has incorrect signatures for the listed functions. 
> > > Basically, any pointer argument which is not in the final position, is not 
> > > listed as a pointer type.  It seems likely that a script to remove 
> > > argument names was buggy.  I'm not sure that I'm up to submitting a full 
> > > erratum to note all the changes, though.
> > 
> > I'm not aware of any problem with that header file (aside from the
> > invalid use of const for custom pointer types).
> 
> Ooops, you're correct.
> 
> Admittedly, I never tried to extract and use the header from rfc2744,
> and just looking at it again, I agree, it seems to have a few errors
> (lacking "*") in many of the output/modify function parameters
> --seemingly except for the last function parameter, where the "*"
> is usually present.


The "*" on the output parameters in the Appendix A sample header file
seem to have disappeared during I-D revision 05->06 of the C-bindings
draft, they were present during -00 through -05:

  http://tools.ietf.org/rfcdiff?url2=rfc2744.txt&url1=draft-ietf-cat-gssv2-cbind-05.txt#diff0410

I put together my gssapi_2.h header in 1995 (-00) and didn't notice
the corruption in Appendix A starting in cbind-06.


A "fix" of that size appears somewhat huge for the errata process.
Filing an errata that describes the nature of the problem--maybe including
a suitable URL to rfcdiff like the one above for visualizing the problem,
might be preferable.


The formatting of the C-Bindings I-D changed considerably from 05->06,
and apparently the gssapi.h sample header file in Appendix A got corrupted.
Scanning my archives, the C-Bindings author even indicated that he
had changed his I-D tooling.  Unfortunately http://tools.ietf.org/rfcdiff
didn't exist back then (and previous versions of drafts were also no
longer accessible in the download directories (so unless you happened
to have a previous copy...).

:  From:     John Wray
:  Subject:  New GSSAPI C-bindings draft
:  Date:     Mon, 13 Jul 1998 10:41:05 -0400
:  To:       Ietf-cat-wg@lists.Stanford.EDU
:
:  I've just submitted an updated C-bindings document, so expect
:  draft-ietf-cat-gssv2-cbind-06.txt to show up on the repositories in the
:  next couple of days.
:
:  Changes from the previous version:
:
:     Reformatting.  Changing jobs meant I no longer have all
:        the nroff macros I used to use, so I took the opportunity
:        to migrate to a slightly more modern formatting program.
:        One unfortunate result of this is that diff-ing this version
:        against the previous one won't give much useful
:        information.
:
:     Incorporation of the 2078bis alignments posted to the
:        list by Martin.
:
:     A number of typos and clarification requests received
:        by e-mail (also from Martin).
:
: John


Btw. there is another problem with the gssapi.h sample header file
in rfc2744:  for 64-bit, there exists a binary-incompatibility
between the X/Open defined GSS-API C-bindings and the IETF-defined
rfc2744 C-Bindings for "count" member of the gss_OID_set type:

rfc2744:  http://tools.ietf.org/html/rfc2744#page-84

     typedef struct gss_OID_set_desc_struct  {
         size_t     count;
         gss_OID    elements;
     } gss_OID_set_desc, *gss_OID_set;
     

X/Open: http://archive.opengroup.org/publications/archive/CDROM/c441.pdf
Page 45:

     typedef struct gss_OID_set_desc_struct{
         int count;
         gss_OID elements;
     } gss_OID_set_desc, *gss_OID_set;


-Martin