Re: [kitten] WGLC for three "bis" documents: draft-ietf-kitten-rfc4402bis-00, draft-ietf-kitten-rfc5653bis-01, draft-ietf-kitten-rfc6112bis-00

[Greg Hudson <[e-mail]>]

On 01/20/2015 06:02 PM, Benjamin Kaduk wrote:
> http://tools.ietf.org/html/draft-ietf-kitten-rfc4402bis-00

I reviewed this and did not find any problems with it.

> http://tools.ietf.org/html/draft-ietf-kitten-rfc5653bis-01

My only substantive note is that the InputStream/OutputStream forms of
initSecContext/acceptSecContext could, perhaps, already write tokens to
the outStream parameter before throwing an exception, instead of
communicating them in the exception.  If this issue has already been
discussed, please ignore this remark.  If not, I suspect it might be
easier on callers (but perhaps harder on implementations) just to
require that callers flush or otherwise handle content in the output
stream after an exception.  I do not have a strong interest in how this
turns out, though.

Some text was removed from the copyright notice about containing
pre-2008 material.  If this was intentional, please ignore this remark.

In several places the draft uses the new text "to inform the reason for
the error," which is not correct English.  I suggest "to communicate the
reason for the error."

The section 5.2 table contains the pre-existing typo "Covert" for
"Convert".  I noticed because the table was reformatted; it may or may
not be worth correcting.

> http://tools.ietf.org/html/draft-ietf-kitten-rfc6112bis-00

I found a typo: "optionSHOULD" for "option SHOULD."