Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth-12

Bill Mills <wmills@yahoo-inc.com> Wed, 18 December 2013 02:12 UTC

Return-Path: <wmills@yahoo-inc.com>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 96E8F1AE203 for <kitten@ietfa.amsl.com>; Tue, 17 Dec 2013 18:12:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.22
X-Spam-Level:
X-Spam-Status: No, score=-16.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_NEUTRAL=0.779, USER_IN_DEF_WHITELIST=-15] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6HlUjxt2ahwS for <kitten@ietfa.amsl.com>; Tue, 17 Dec 2013 18:12:15 -0800 (PST)
Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com [98.139.253.104]) by ietfa.amsl.com (Postfix) with ESMTP id 55E891AE1F1 for <kitten@ietf.org>; Tue, 17 Dec 2013 18:12:15 -0800 (PST)
Received: from GQ1-EX10-CAHT17.y.corp.yahoo.com (gq1-ex10-caht17.corp.gq1.yahoo.com [10.73.119.198]) by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id rBI2Bsco077828 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for <kitten@ietf.org>; Tue, 17 Dec 2013 18:11:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1387332715; bh=ZuCy/eKTE21UV+OVTLs2C9LIKBt+kEmd+5kVAYjXf88=; h=References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To: MIME-Version:Content-Type; b=f90EM0d7cqEH4hXgmt8bDDqIWBAUSjmU0xbG+efqD4I/HU1Sd2fWmWwFf55I0iBlV kWCbpz/VIyy8g3V9l4CkeFesmYqqZ00ft4Gu0q3CArpqyOOa940Pcs8ahwtPMuXken E5XNt12s5WjYRZKQRt7IPZAI2uUOjBpFuyuZC0gc=
Received: from omp1087.mail.ne1.yahoo.com (98.138.101.176) by GQ1-EX10-CAHT17.y.corp.yahoo.com (10.72.228.24) with Microsoft SMTP Server (TLS) id 14.3.158.1; Tue, 17 Dec 2013 18:11:53 -0800
Received: (qmail 16188 invoked by uid 1000); 18 Dec 2013 02:11:52 -0000
Received: (qmail 27271 invoked by uid 60001); 18 Dec 2013 02:11:51 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo-inc.com; s=ginc1024; t=1387332711; bh=Yd7a4d4eDkBUuDRmAqVdCHdax1ZfatE1m6n9Qgwrjys=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=jAEEWDGieSlRwDbSv3K77rI7go9NUJZIiY3UQpvVkkTQOMEUhl+mGDIZVJic+bBmkufetyAUicyC9fEBTSnAYyS1yqRbDBuTu7sXsVIoNRllFOfNTUFg/fSxj/28EozYKpEy9kWgi3XgOJlR0rNq+ucb7cGeJoXapbWpsYGRNZU=
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=ginc1024; d=yahoo-inc.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=hmgv4oTBRCVefM9k5H+9ihevsHdxppP4tThQcY27sdRd5+6NLMYvDsVLUcoPebKVQ0cyVjKg18N1oef2iD8ANnW+IJgWLnR2MOX3X+LCO1rdRdSzZ/VTHn64oZ8oorOh4wlTNvvs46gtdoTYSYLI3kh349Agun3c2+tQHfMAi1c=;
X-YMail-OSG: uPP3DzQVM1lT9Z6SqhfES0ElhNrpwYzApr_gtZLwMtEwqrD fhm9nogZ6ytcTnfbSa3VU9V2_YZZBkcGAz5s6bnZCPHYg.IbeBEdfPsWYI8z 2w.W8uS54FOMPtTb8xh59bT0Ml5B4RUcKWZczse7s4_MKlPhYlNXDbTWtO68 54JjEblzI_DhLfYh7GLf5HwvUzzqmYa1zsgQZk7MwzrU.DHewS7BYR5vMXQl huQO8f4VF36oEGrK.eHThvinasqvn8kysnCgdOnEkfyTM0Wny5vpHtdcMdTj 7Ec7bnVVMd3309Epvj1Lxaq3.
Received: from [209.131.62.113] by web125606.mail.ne1.yahoo.com via HTTP; Tue, 17 Dec 2013 18:11:51 PST
X-Rocket-MIMEInfo: 002.001, TWF0dCdzIGVkaXRzIGFyZSBpbmNsdWRlZCBpbiBteSB3b3JraW5nIGNvcHkgYW5kIHZpZXdhYmxlL2NvbW1lbnRhYmxlIGF0IGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS9maWxlL2QvMEI5OVlTa3hTNlplZmRHMWZTRkZJZVd4dE5VRS9lZGl0P3VzcD1zaGFyaW5nIHRob3VnaCBJIGRvbid0IGhhdmUgdGhlIGZhbmN5IGRpZmYgdmVyc2lvbi4KCgrCoAotYmlsbAoKCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpXaWxsaWFtIEouIE1pbGxzCiJQYXJhbm9pZCIgWWFob28hCgoKCgoKT24gVHVlc2QBMAEBAQE-
X-Mailer: YahooMailWebService/0.8.170.612
References: <52AE9A65.1010700@oracle.com> <C2752600-AC7C-4839-8BD0-3D850ECB19EB@cisco.com> <1387329873.35383.YahooMailNeo@web125604.mail.ne1.yahoo.com>
Message-ID: <1387332711.90725.YahooMailNeo@web125606.mail.ne1.yahoo.com>
Date: Tue, 17 Dec 2013 18:11:51 -0800
From: Bill Mills <wmills@yahoo-inc.com>
To: Bill Mills <wmills@yahoo-inc.com>, "Matt Miller (mamille2)" <mamille2@cisco.com>, Shawn M Emery <shawn.emery@oracle.com>, "kitten@ietf.org" <kitten@ietf.org>
In-Reply-To: <1387329873.35383.YahooMailNeo@web125604.mail.ne1.yahoo.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="607277540-2050968581-1387332711=:90725"
X-Milter-Version: master.31+4-gbc07cd5+
X-CLX-ID: 332715001
Subject: Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth-12
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Bill Mills <wmills@yahoo-inc.com>
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Dec 2013 02:12:17 -0000

Matt's edits are included in my working copy and viewable/commentable at https://drive.google.com/file/d/0B99YSkxS6ZefdG1fSFFIeWxtNUE/edit?usp=sharing though I don't have the fancy diff version.


 
-bill



--------------------------------
William J. Mills
"Paranoid" Yahoo!





On Tuesday, December 17, 2013 5:25 PM, Bill Mills <wmills@yahoo-inc.com> wrote:
 
Inline below.  I need to fix the examples as you note.


 
-bill



--------------------------------
William J. Mills
"Paranoid" Yahoo!





On Tuesday, December 17, 2013 2:47 PM, Matt Miller (mamille2) <mamille2@cisco.com> wrote:
 
On Dec 15, 2013, at 11:15 PM, Shawn M Emery <shawn.emery@oracle.com> wrote:

> 
> This message officially starts the 2nd kitten Working Group Last Call for the following document:
> 
> A set of SASL Mechanisms for OAuth
> http://tools.ietf.org/html/draft-ietf-kitten-sasl-oauth-12
> 
> The Working Group Last Call for this document starts today on Sunday, December 15th and will end on Tuesday, December 31st.
> 
> Please send any comments to the kitten mailing list or directly to the chairs.  Even if you reviewed this document and found no
 issues then please provide this feed-back.
> 

Here are my current comments on this draft (more might come later):

MAJOR:

* Removing the GS2-header (which was done in revision -11) also removed the ability for the client to specify an authorization identity.  If the lack of an authorization identity is acceptable (and I suspect it is not for some), then the document needs to state these mechanisms do not support authz-id.

[wmills] This is addressed in 3.2.1 of -12  authz-id is possible in some OAuth schemes.

* In section 3.2.2. Server Response to Failed Authentication, returning a space-separated list for the "scope" field is NOT RECOMMENDED, but also says the lack of a "scope" (value or field) implies the client SHOULD request tokens that are unscoped (empty list of scopes). 
 However, RFC 6749 § 3.3 does not permit unscoped tokens; the ABNF does not allow for "scope=" (i.e., the empty list), and the text regarding the lack of scope means the authorization server uses a default scope value (or fails authorization outright).  To me, this seems like a contradiction that would lead to interoperability problems.

[wmills] "scope" is an optional parameter, so if you want an empty value you don't send scope at all.

MINOR:

* In section 2. Terminology, it does not explicitly state that the reader ought to be familiar with terminology from RFC 4422.  This should be added.

[wmills] OK

* In section 3.2.2. Server Response to Failed Authentication, the last paragraph still discusses channel binding.  It should be removed.

[wmills] OK

* All of the examples
 include a gs2-header, but this was removed from the ABNF.  The examples need to be updated to remove the header.


* In section 8.1. Normative References, there is an entry for RFC 5056, but this reference is no longer used in the document.  It should be removed.

[wmills] OK

NITS:

* HTTP is mentioned but no citation or definition is included.
* XMPP is mentioned but no citation or definition is included.

[wmills] OK x2


* In section 1. Introduction, SMTP is mentioned with a citation but without a definition (unlike SASL and IMAP immediately preceding).

[wmills] I see "SMTP [RFC5321]" there

* In section 3. OAuth SASL Mechanism Specifications, the two lists describing success and failure flows are in fact ordered (numbered), but the document presents them as unordered (symbols).

[wmills] OK

* In section 3.2.2. Server Response to Failed Authentication, replace [[ need registry name ]] with "OAuth Extensions Error Registry".

[wmills] OK

* In section 4.2. Failed Exchange, the "status" value of "401" is not in the OAuth Extensions Error Registry; "invalid_request" seems appropriate here instead.

* In section 4.3. SMTP Example of a Failed Negotiation, the (encoded) server response uses a "status" value of "401", which is not in the OAuth Extensions Error Registry; "invalid_token" seems appropriate here instead.

[wmills] Will fix the 2 above (as opposed to OK which indicates I already did the edit)

* In section 5. Security Considerations, he phrase "This document specifies three SASL mechanisms should be "This document specifies two SASL mechanisms".

[wmills] OK

* In Appendix A. Acknowledgements, "area directors" should be "area director".

[wmills] OK



- m&m


Matt Miller < mamille2@cisco.com >
Cisco Systems, Inc.


_______________________________________________
Kitten mailing list
Kitten@ietf.org
https://www.ietf.org/mailman/listinfo/kitten





_______________________________________________
Kitten mailing list
Kitten@ietf.org
https://www.ietf.org/mailman/listinfo/kitten