Re: [kitten] New Version Notification for draft-kaduk-kitten-gss-loop-01.txt (fwd)

[Greg Hudson <[e-mail]>]

On 11/20/2013 05:45 PM, Benjamin Kaduk wrote:
> We discussed whether (either at the abstract level or the C bindings) it
> is guaranteed to be safe to call gss_release_buffer() twice on the same
> buffer.

I think that unfortunately it is not safe per the spec, although it is
probably safe in every GSSAPI implementation.

> The send_token()/receive_token() routines are not very good examples. 
> It is probably better to rewrite them to use sendmsg/recvmsg with
> socketpair, which also eliminates the need to add framing with the token
> length.

I think the RFC should only include the do_initiator() and do_acceptor()
functions.  The sample code does not need to compile and run, only
demonstrate how the API should be used and be a reasonable starting
point for cut and paste.  Adding questionable framing code runs the risk
of people actually using it, and adding solid framing code would be too
much verbiage.  release_buffer() is needed, of course, unless we get rid
of it somehow (perhaps by assuming that receive_token will free what's
already there, and then just calling free() in cleanup).

I would rather see anonymous handled as a runtime parameter than an
#ifdef, which is distracting.

"if ((ret_flags & GSS_C_ANON_FLAG) != GSS_C_ANON_FLAG)" can be
simplified to "if (!(ret_flags & GSS_C_ANON_FLAG))", and similarly
elsewhere.