Re: [kitten] Genart last call review of draft-ietf-kitten-krb-spake-preauth-07

Robbie Harwood <rharwood@redhat.com> Thu, 28 May 2020 22:27 UTC

Return-Path: <rharwood@redhat.com>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79B7C3A0C9F for <kitten@ietfa.amsl.com>; Thu, 28 May 2020 15:27:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2fsdr7enWOa7 for <kitten@ietfa.amsl.com>; Thu, 28 May 2020 15:27:30 -0700 (PDT)
Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B820B3A0C9A for <kitten@ietf.org>; Thu, 28 May 2020 15:27:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590704849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XM2oi5069fAaBqDsYLsbYlxR214ikN1R6m1sOrMTiFo=; b=c5jEEFnJebsloraMj+UScTki6Y6J9Z7IiKnvwEWAz/AK7xx7E07e0Df67zM1FapcKP0qJ0 WMgTI3vV5LyTTz9MWExWI2wjjCVtB85cxoXct8pqo8cPDGG5y/vjUgc21XEoAdv5ewpWxZ OOhUnVZhjrSc4XWXB7f4Biiy+8coW0s=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-qWzGNmq6OGSwHZjyIM_h5g-1; Thu, 28 May 2020 18:27:24 -0400
X-MC-Unique: qWzGNmq6OGSwHZjyIM_h5g-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 807CC464; Thu, 28 May 2020 22:27:23 +0000 (UTC)
Received: from localhost (unknown [10.10.110.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CCF75D9CD; Thu, 28 May 2020 22:27:22 +0000 (UTC)
From: Robbie Harwood <rharwood@redhat.com>
To: Russ Housley <housley@vigilsec.com>, gen-art@ietf.org
Cc: kitten@ietf.org, last-call@ietf.org, draft-ietf-kitten-krb-spake-preauth.all@ietf.org
In-Reply-To: <158956185809.27642.15651397749101904532@ietfa.amsl.com>
References: <158956185809.27642.15651397749101904532@ietfa.amsl.com>
Date: Thu, 28 May 2020 18:27:19 -0400
Message-ID: <jlgftbjelvc.fsf@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/kitten/tSL7EEOo7d92WbNSUC1xqbN7F_g>
Subject: Re: [kitten] Genart last call review of draft-ietf-kitten-krb-spake-preauth-07
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2020 22:27:33 -0000

Russ Housley via Datatracker <noreply@ietf.org> writes:

> Reviewer: Russ Housley
> Review result: Almost Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed by
> the IESG for the IETF Chair.  Please treat these comments just like
> any other last call comments.

Hi Russ, thanks for the review.  Changes should be present in -08 unless
discussed further below.

> Major Concerns:
>
> Does this align with draft-irtf-cfrg-spake2?

It's derived from it, though they no longer totally align.

> Are you aware of https://datatracker.ietf.org/ipr/4018/?

I have seen it, but as Watson Ladd put it in
https://mailarchive.ietf.org/arch/msg/cfrg/senXefqczpUZo26B35ekz8d3iLo/

    I’m not a patent lawyer, and cannot speculate on any IPR conflicts
    that may or may not exist.

> Minor Concerns:
>
> Abstract: Please explain "FAST", perhaps just a pointer to RFC 6113.

We believe this is covered by the "Document conventions" section.

Thanks,
--Robbie