Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth-12
"Matt Miller (mamille2)" <mamille2@cisco.com> Tue, 17 December 2013 22:47 UTC
Return-Path: <mamille2@cisco.com>
X-Original-To: kitten@ietfa.amsl.com
Delivered-To: kitten@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 83D381ADBCA for <kitten@ietfa.amsl.com>; Tue, 17 Dec 2013 14:47:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.039
X-Spam-Level:
X-Spam-Status: No, score=-10.039 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-0.538, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 283puVaCNYRM for <kitten@ietfa.amsl.com>; Tue, 17 Dec 2013 14:46:58 -0800 (PST)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) by ietfa.amsl.com (Postfix) with ESMTP id B2B9D1AD75F for <kitten@ietf.org>; Tue, 17 Dec 2013 14:46:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4613; q=dns/txt; s=iport; t=1387320417; x=1388530017; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=hPH3NA3JhLlzBnqBCPQ45Tf85k4NTKRMrKuR6goV2Lc=; b=csM+1g8xayrE3QAYadNgJdM/HsZhtxnmPVD7ZlWBO4jlVrGvCqAxvCbo jXGO43pT3YvR47bki3ujN5SMb2IOu7x2ghxOwuPPFTDKugIrn6DUj1XyO S7ip5XqhgRH2vMQOOMBihfT8iigicFV06VamMZmVY7EqxtaL6UbzyYrv6 I=;
X-Files: signature.asc : 496
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AlkFAL3TsFKtJXG+/2dsb2JhbABQCYMKOFWvNok1gR8WdIIlAQEBAwEdURsCAQhGMiUCBAESDoduCA3JRheON2KDI4ETAQOMW4NYgTGGMoEwhhCKVIMrgio
X-IronPort-AV: E=Sophos; i="4.95,503,1384300800"; d="asc'?scan'208"; a="7474839"
Received: from rcdn-core2-3.cisco.com ([173.37.113.190]) by alln-iport-3.cisco.com with ESMTP; 17 Dec 2013 22:46:57 +0000
Received: from xhc-aln-x09.cisco.com (xhc-aln-x09.cisco.com [173.36.12.83]) by rcdn-core2-3.cisco.com (8.14.5/8.14.5) with ESMTP id rBHMkv4m020314 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 17 Dec 2013 22:46:57 GMT
Received: from xmb-aln-x11.cisco.com ([169.254.6.22]) by xhc-aln-x09.cisco.com ([173.36.12.83]) with mapi id 14.03.0123.003; Tue, 17 Dec 2013 16:46:57 -0600
From: "Matt Miller (mamille2)" <mamille2@cisco.com>
To: Shawn M Emery <shawn.emery@oracle.com>, "kitten@ietf.org" <kitten@ietf.org>
Thread-Topic: [kitten] WGLC on draft-ietf-kitten-sasl-oauth-12
Thread-Index: AQHO+iYGh/HTVxoMc0+2BQxVCnN2eJpZZA6A
Date: Tue, 17 Dec 2013 22:46:57 +0000
Message-ID: <C2752600-AC7C-4839-8BD0-3D850ECB19EB@cisco.com>
References: <52AE9A65.1010700@oracle.com>
In-Reply-To: <52AE9A65.1010700@oracle.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.129.24.73]
Content-Type: multipart/signed; boundary="Apple-Mail=_610D75FA-E396-4124-B7F8-9F28439DF436"; protocol="application/pgp-signature"; micalg="pgp-sha512"
MIME-Version: 1.0
Subject: Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth-12
X-BeenThere: kitten@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Common Authentication Technologies - Next Generation <kitten.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/kitten>, <mailto:kitten-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/kitten/>
List-Post: <mailto:kitten@ietf.org>
List-Help: <mailto:kitten-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/kitten>, <mailto:kitten-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Dec 2013 22:47:00 -0000
On Dec 15, 2013, at 11:15 PM, Shawn M Emery <shawn.emery@oracle.com> wrote: > > This message officially starts the 2nd kitten Working Group Last Call for the following document: > > A set of SASL Mechanisms for OAuth > http://tools.ietf.org/html/draft-ietf-kitten-sasl-oauth-12 > > The Working Group Last Call for this document starts today on Sunday, December 15th and will end on Tuesday, December 31st. > > Please send any comments to the kitten mailing list or directly to the chairs. Even if you reviewed this document and found no issues then please provide this feed-back. > Here are my current comments on this draft (more might come later): MAJOR: * Removing the GS2-header (which was done in revision -11) also removed the ability for the client to specify an authorization identity. If the lack of an authorization identity is acceptable (and I suspect it is not for some), then the document needs to state these mechanisms do not support authz-id. * In section 3.2.2. Server Response to Failed Authentication, returning a space-separated list for the "scope" field is NOT RECOMMENDED, but also says the lack of a "scope" (value or field) implies the client SHOULD request tokens that are unscoped (empty list of scopes). However, RFC 6749 § 3.3 does not permit unscoped tokens; the ABNF does not allow for "scope=" (i.e., the empty list), and the text regarding the lack of scope means the authorization server uses a default scope value (or fails authorization outright). To me, this seems like a contradiction that would lead to interoperability problems. MINOR: * In section 2. Terminology, it does not explicitly state that the reader ought to be familiar with terminology from RFC 4422. This should be added. * In section 3.2.2. Server Response to Failed Authentication, the last paragraph still discusses channel binding. It should be removed. * All of the examples include a gs2-header, but this was removed from the ABNF. The examples need to be updated to remove the header. * In section 8.1. Normative References, there is an entry for RFC 5056, but this reference is no longer used in the document. It should be removed. NITS: * HTTP is mentioned but no citation or definition is included. * XMPP is mentioned but no citation or definition is included. * In section 1. Introduction, SMTP is mentioned with a citation but without a definition (unlike SASL and IMAP immediately preceding). * In section 3. OAuth SASL Mechanism Specifications, the two lists describing success and failure flows are in fact ordered (numbered), but the document presents them as unordered (symbols). * In section 3.2.2. Server Response to Failed Authentication, replace [[ need registry name ]] with "OAuth Extensions Error Registry". * In section 4.2. Failed Exchange, the "status" value of "401" is not in the OAuth Extensions Error Registry; "invalid_request" seems appropriate here instead. * In section 4.3. SMTP Example of a Failed Negotiation, the (encoded) server response uses a "status" value of "401", which is not in the OAuth Extensions Error Registry; "invalid_token" seems appropriate here instead. * In section 5. Security Considerations, he phrase "This document specifies three SASL mechanisms should be "This document specifies two SASL mechanisms". * In Appendix A. Acknowledgements, "area directors" should be "area director". - m&m Matt Miller < mamille2@cisco.com > Cisco Systems, Inc.
- [kitten] WGLC on draft-ietf-kitten-sasl-oauth-12 Shawn M Emery
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Matt Miller (mamille2)
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Matt Miller (mamille2)
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Matt Miller (mamille2)
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Ryan Troll
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Ryan Troll
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- [kitten] WGLC on draft-ietf-kitten-aes-cts-hmac-s… Shawn M Emery
- Re: [kitten] WGLC on draft-ietf-kitten-aes-cts-hm… Benjamin Kaduk
- Re: [kitten] WGLC on draft-ietf-kitten-aes-cts-hm… Peck, Michael A
- Re: [kitten] WGLC on draft-ietf-kitten-aes-cts-hm… Benjamin Kaduk
- Re: [kitten] WGLC on draft-ietf-kitten-aes-cts-hm… Simon Josefsson
- Re: [kitten] WGLC on draft-ietf-kitten-aes-cts-hm… Benjamin Kaduk
- Re: [kitten] WGLC on draft-ietf-kitten-aes-cts-hm… Greg Hudson
- [kitten] WGLC on draft-ietf-krb-wg-cammac-08 Shawn M Emery
- Re: [kitten] WGLC on draft-ietf-krb-wg-cammac-08 Zheng, Kai
- Re: [kitten] WGLC on draft-ietf-krb-wg-cammac-08 Tom Yu
- Re: [kitten] WGLC on draft-ietf-krb-wg-cammac-08 Zheng, Kai
- [kitten] WGLC on draft-ietf-kitten-sasl-oauth-15 Shawn M Emery
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Benjamin Kaduk
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Benjamin Kaduk
- Re: [kitten] WGLC on draft-ietf-kitten-sasl-oauth… Bill Mills