[L2sm] R: Yangdoctors early review of draft-ietf-l2sm-l2vpn-service-model-08

Fioccola Giuseppe <giuseppe.fioccola@telecomitalia.it> Wed, 28 February 2018 13:15 UTC

Return-Path: <giuseppe.fioccola@telecomitalia.it>
X-Original-To: l2sm@ietfa.amsl.com
Delivered-To: l2sm@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id BEC1D128959; Wed, 28 Feb 2018 05:15:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.611
X-Spam-Status: No, score=-2.611 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id 8LzUPIkWqxQt; Wed, 28 Feb 2018 05:15:47 -0800 (PST)
Received: from mx04.telecomitalia.it (mx04.telecomitalia.it []) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE55A126CB6; Wed, 28 Feb 2018 05:15:41 -0800 (PST)
X-AuditID: d9a97918-547ff70000006b07-8e-5a96ab7c6d2f
Received: from TELMBXB02RM001.telecomitalia.local ( []) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by mx04.telecomitalia.it () with SMTP id 9E.05.27399.C7BA69A5; Wed, 28 Feb 2018 14:15:40 +0100 (CET)
From: Fioccola Giuseppe <giuseppe.fioccola@telecomitalia.it>
To: Ladislav Lhotka <lhotka@nic.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "l2sm@ietf.org" <l2sm@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-l2sm-l2vpn-service-model.all@ietf.org" <draft-ietf-l2sm-l2vpn-service-model.all@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-l2sm-l2vpn-service-model-08
Thread-Index: AQHTrv5AYyIDdm1EX0ihG0H5S7yR0qO5rvBQ
Date: Wed, 28 Feb 2018 13:15:39 +0000
Message-ID: <a29f08b341cd472597badb2e6e55463f@TELMBXB02RM001.telecomitalia.local>
References: <151964851123.31353.1471509914124380207@ietfa.amsl.com>
In-Reply-To: <151964851123.31353.1471509914124380207@ietfa.amsl.com>
Accept-Language: it-IT, en-US
Content-Language: it-IT
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: []
x-ti-disclaimer: Disclaimer1
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDKsWRmVeSWpSXmKPExsXCxfdHWrdm9bQog+sLuC22TWthtHi2cT6L xZ2XLxktLqyay2bRt+sAowOrx5IlP5k8Nl2+wxjAFNXAaJOYl5dfkliSqpCSWpxsq+SSWZyc k5iZm1qkEJKak5qcn6ukkJliq2SspFCQk5icmpuaV2KrlFhQkJqXomTHpYABbIDKMvMUUvOS 81My89JtlTyD/XUtLEwtdQ2V7AJLU4tL8hVyU4uLE9PTM/MVUhPWC2b8+3aEqeCZQcWjoz3M DYxH9LsYOTkkBEwkLjf/Y+li5OIQEpjCJLHg3B9GkASbgI3EwVcn2EBsEYEwiR37v7KDFDEL rGeUmLFtOVARB4ewgJ/E/LsyIKaIQJDE6edmEOVGEov3HmcBCbMIqEqc6FEFCfMKBEpMbVvC DmILCThLfLq/ixXE5hRwkbgwYwbYJkYBWYkJuxeBXcAsIC7xYvoJdogzBSSW7DnPDGGLSrx8 /I8VwjaQ2Lp0HwuErSgx6dRTqLiMxMIjk1lBTmAW0JRYv0sfYqSixJTuh+wQ5whKnJz5hGUC o9gsJNtmIXTMQtIxC0nHAkaWVYyiuRUGJnolkLjLLEnMyUzUyyzZxAhMIjdXVkrsYOxe63yI UYCDUYmHt3PBtCgh1sSy4srcQ4wSHMxKIrxpJUAh3pTEyqrUovz4otKc1OJDjD7A4JrILCWa nA9McHkl8YYmFpaGxhYWRoYWZqY4hJXEeZdXAs0SSAcmruzU1ILUIphxTBycUg2M17Q3RHgW pDnfVK4uWvvxCOve/0xFejJ7Xl1UzSjtbNvueM7/czO3hm/b1IkLOi617JLOVbmyf+6Da2Wu /49XqeVn2s9ln9UQb+31bWv0p7Tdz9L0Uk6Iq85RlVeWCCtP2u41Mzlnjdb2lptOyTe3VrUc fLi3N883g1FpkVJLNcMjp9xDj92VWIozEg21mIuKEwGTa0rpTwMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/l2sm/DZtOm9IvT4dlTBztW7Qy-46UUqY>
Subject: [L2sm] R: Yangdoctors early review of draft-ietf-l2sm-l2vpn-service-model-08
X-BeenThere: l2sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "The Layer Two Virtual Private Network Service Model \(L2SM\)" <l2sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2sm>, <mailto:l2sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l2sm/>
List-Post: <mailto:l2sm@ietf.org>
List-Help: <mailto:l2sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2sm>, <mailto:l2sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2018 13:15:51 -0000

Hi Ladislav,
Thank you! We are working on a new revision that incorporates your comments.
My answers inline tagged as [GF].

Best Regards,


-----Messaggio originale-----
Da: Ladislav Lhotka [mailto:lhotka@nic.cz] 
Inviato: lunedì 26 febbraio 2018 13:35
A: yang-doctors@ietf.org
Cc: l2sm@ietf.org; ietf@ietf.org; draft-ietf-l2sm-l2vpn-service-model.all@ietf.org
Oggetto: Yangdoctors early review of draft-ietf-l2sm-l2vpn-service-model-08

Reviewer: Ladislav Lhotka
Review result: Ready with Issues

**** General comments

     - The 'ietf-l2vpn-svc' module contained in this document is
       rather large: it defines 386 schema nodes, 35 features and 175
       identities. It is therefore natural to ask whether the authors
       considered splitting the definitions into multiple
       modules. This would make the data model more modular and
       probably also make some of the features unnecessary. See also
       draft-ietf-netmod-rfc6087bis-18, sec. 4.17.

[GF]: Ok, Thanks for the suggestion. We will remove unnecessary identities, features. Note that unlike network element model, service model will describe various aspects of network infrastructure, including devices and their subsystems, and relevant protocols operating at the link and network layers across multiple device. So it is intentional to have such model design.

     - The module defines most containers, lists and even individual
       leaves in a grouping that is then used only once. This approach
       has its pros nad cons but it is not the common practice in YANG
       modelling - groupings are mostly defined only if they are used (or
       expected to be used) repeatedly and/or in different modules.

[GF]: It is expected some of these groupings can be reused in some other external modules, or model extension.

     - Some of the groupings (e.g. 'site-device') reference nodes
       outside the grouping, which is discouraged, see
       draft-ietf-netmod-rfc6087bis-18, sec. 4.13.

[GF]: Will fix it. Thanks.

     - Names are sometimes overloaded in that the same name is used
       for different purposes. For example, 'cloud-access' is used as
       the name of both a list and a feature. In one case
       ('bum-frame-delivery'), the same name is used for a list, the
       container that encloses it, and the grouping in which the
       container is defined. This should be avoided.

[GF]: Ok

**** Specific comments

     - Most when expressions correctly use the XPath function
       'derived-from-or-self()'. In two cases ('vpn-id' and 'cos-id'
       leaves) identities are compared in XPath expressions using
       plain string equality. These XPath expressions need to be
       changed to use 'derived-from-or-self()' as well.

 [GF]: Ok

     - The when expression for container 'devices' user a disjunction
       of two 'derived-from-or-self()' checks. This usually indicates
       that a new identity can be defined from which both or-ed
       identities are derived.

 [GF]: Ok

**** Instance examples

     The example instance documents contained in the document require
     to be carefully checked because they are often invalid or even
     not well-formed. I would also suggest to use examples in JSON
     encoding that is easier to read:

     The problems that I discovered include:

     - extra space in opening and closing XML tags
       < network-access-id> and </ network-access-id>

 [GF]: Will fix it.

     - p. 28: wrong namespace URI

[GF]: Will fix it.

     - p. 28: in the first 'vpn-service' entry (key 'VPNB'), two
       mandatory leaves are missing: 'ce-vlan-preservation' and

[GF]: Will fix it.

**** Nits

     - The name of 'ce-vlan-cos-perservation' should most likely be

[GF]: Will fix it.

     - Inconsistent indentation: features 'cfm' and 'y-1731' have less
       spaces of indentation than other features

[GF]: Will fix it.

     - When concatenating literal strings, the widely accepted
       convention is to put the '+' sign ot the second line, and align
       the string components. That is, instead of

       path "/l2vpn-svc/vpn-profiles/valid-provider-identifiers"+


       path "/l2vpn-svc/vpn-profiles/valid-provider-identifiers"
          + "/cloud-identifier/id";

[GF]: Will fix it.

Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie. 

This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks. 

Rispetta l'ambiente. Non stampare questa mail se non è necessario.