[L2sm] AD review of draft-ietf-l2sm-l2vpn-service-model

Benoit Claise <bclaise@cisco.com> Thu, 22 February 2018 02:24 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: l2sm@ietfa.amsl.com
Delivered-To: l2sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9483E12E852 for <l2sm@ietfa.amsl.com>; Wed, 21 Feb 2018 18:24:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.529
X-Spam-Level:
X-Spam-Status: No, score=-14.529 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g4G4grGn0q2u for <l2sm@ietfa.amsl.com>; Wed, 21 Feb 2018 18:24:45 -0800 (PST)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ADDE512E05C for <l2sm@ietf.org>; Wed, 21 Feb 2018 18:24:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4462; q=dns/txt; s=iport; t=1519266285; x=1520475885; h=from:subject:to:message-id:date:mime-version; bh=+dCToQ+LPv0TAkBMktLaiIUr1QY2rtTpPoIRPQQyEnw=; b=Th2uRhsPX3jzWxW3KFBaGJUdHA+wsCusHse3D4O0J+1lCBUV3yFeVOi5 Kn7bvPZLLC3cWjFnQh4dUaC7g7TtzRZOM7i0mZDtCJhBBcL9RSkq3JvPE D1pj6QhNijjRiJ8WRSPmUEzTuQne1VPiUJQe2Gc562h1RkiF5A9fgkrnm 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CgAwCRKY5a/5ldJa1dGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAYNPZnAog2iYHIFbgT6QboVcFIICCiOIC1YWAQIBAQEBAQE?= =?us-ascii?q?Cax0LhU11DjACSxQNCAEBih8Qmk2QHIInJoRag3iCEwEBAQEGAQEBAQEeBYU?= =?us-ascii?q?RgieBV4FnKQyGKQEBAgEBgTWDT4JlBYp7iG+GRYoMCYgnjWaCIIYpg3GIC44?= =?us-ascii?q?JggGIHIE8JgMvgVEzGggbFYJ9hRQjNwELjFABAQE?=
X-IronPort-AV: E=Sophos;i="5.47,376,1515456000"; d="scan'208,217";a="361943758"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2018 02:24:31 +0000
Received: from [10.82.244.207] (rtp-vpn2-1231.cisco.com [10.82.244.207]) by rcdn-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id w1M2OUo3005242 for <l2sm@ietf.org>; Thu, 22 Feb 2018 02:24:30 GMT
From: Benoit Claise <bclaise@cisco.com>
To: "l2sm@ietf.org" <l2sm@ietf.org>
Message-ID: <267629e4-dd94-8979-b67c-0cc961625dfe@cisco.com>
Date: Wed, 21 Feb 2018 21:24:30 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------B5EDD632CBD37221D2345261"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/l2sm/bXnfpoPQnju-N1rQc4asyziT5-k>
Subject: [L2sm] AD review of draft-ietf-l2sm-l2vpn-service-model
X-BeenThere: l2sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "The Layer Two Virtual Private Network Service Model \(L2SM\)" <l2sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2sm>, <mailto:l2sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l2sm/>
List-Post: <mailto:l2sm@ietf.org>
List-Help: <mailto:l2sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2sm>, <mailto:l2sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2018 02:24:47 -0000

Dear all,

Here is the AD review.

- Section 1.2.
You want to use the YANG tree diagrams in 
draft-ietf-netmod-yang-tree-diagrams-04 
<https://datatracker.ietf.org/doc/draft-ietf-netmod-yang-tree-diagrams/>
I advice a section similar to 
https://tools.ietf.org/html/draft-ietf-netmod-rfc7223bis-03#section-1.3

- The draft is NMDA compliant. It should be mentioned.
Ex: draft-ietf-netmod-rfc7223bis-03, in the abstract and intro

    The YANG model in this document conforms to the Network Management
    Datastore Architecture defined in I-D.ietf-netmod-revised-datastores.

- The references to RFC6020 should be changed to RFC7950, except in the 
IANA considerations.
The YANG module is YANG 1.1

-

  revision 2018-02-05 {
     description
       "Initial revision -04 version";
     reference
       "draft-ietf-l2sm-l2vpn-service-model-05.txt 
<https://tools.ietf.org/html/draft-ietf-l2sm-l2vpn-service-model-05.txt>
        A YANG Data Model for L2VPN Service Delivery.";
   }

This should be changed to
  revision 2018-02-05 {
     description
       "Initial revision -04 version";
     reference
       "RFC XXXX: A YANG Data Model for L2VPN Service Delivery.";
   }

- https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines
Please doublecheck the template.
The first sentence is:
The YANG module specified in this document defines a schema for data 
that is designed to be accessed via network management protocols such as 
NETCONF [RFC6241] or RESTCONF [RFC8040].


Please publish a new version asap.
Note that those changes doesn't prevent the IETF LC to start now.
Hopefully, we could shoot for the March 8th IESDG telechat.

Regards, Benoit