[L2sm] R: AD review of draft-ietf-l2sm-l2vpn-service-model

Fioccola Giuseppe <giuseppe.fioccola@telecomitalia.it> Thu, 22 February 2018 08:25 UTC

Return-Path: <giuseppe.fioccola@telecomitalia.it>
X-Original-To: l2sm@ietfa.amsl.com
Delivered-To: l2sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 883141270A7; Thu, 22 Feb 2018 00:25:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zX5M-ss5yZaB; Thu, 22 Feb 2018 00:25:40 -0800 (PST)
Received: from mx03.telecomitalia.it (mx03.telecomitalia.it [217.169.121.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7BC8B1242EA; Thu, 22 Feb 2018 00:25:39 -0800 (PST)
X-AuditID: d9a97917-c4dff7000000441d-fb-5a8e7e8115fa
Received: from TELMBXB02RM001.telecomitalia.local ( [10.14.252.27]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by mx03.telecomitalia.it () with SMTP id 2C.0D.17437.18E7E8A5; Thu, 22 Feb 2018 09:25:37 +0100 (CET)
From: Fioccola Giuseppe <giuseppe.fioccola@telecomitalia.it>
To: Benoit Claise <bclaise@cisco.com>, "l2sm@ietf.org" <l2sm@ietf.org>
CC: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, Qin Wu <bill.wu@huawei.com>, "draft-ietf-l2sm-l2vpn-service-model@ietf.org" <draft-ietf-l2sm-l2vpn-service-model@ietf.org>
Thread-Topic: [L2sm] AD review of draft-ietf-l2sm-l2vpn-service-model
Thread-Index: AQHTq4RWxL2eA/ZrH0GCkwnBWg2N5qOv6rfQgAAqTFA=
Date: Thu, 22 Feb 2018 08:25:36 +0000
Message-ID: <ed7f6bfc54444b3497ea5210c584322c@TELMBXB02RM001.telecomitalia.local>
References: <B8F9A780D330094D99AF023C5877DABA9AD6486E@nkgeml513-mbs.china.huawei.com>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABA9AD6486E@nkgeml513-mbs.china.huawei.com>
Accept-Language: it-IT, en-US
Content-Language: it-IT
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.14.252.233]
x-ti-disclaimer: Disclaimer1
Content-Type: multipart/alternative; boundary="_000_ed7f6bfc54444b3497ea5210c584322cTELMBXB02RM001telecomit_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIKsWRmVeSWpSXmKPExsXCxfdHWrexri/KYFcTr8WPnhvMFkcfS1g8 nruA1aLncSOTxZ2XLxkdWD2m/N7I6tFy5C2rx5IlP5k8VmxeyRjAEtXAaJOYl5dfkliSqpCS Wpxsq+SSWZyck5iZm1qkEJKak5qcn6ukkJliq2SspFCQk5icmpuaV2KrlFhQkJqXomTHpYAB bIDKMvMUUvOS81My89JtlTyD/XUtLEwtdQ2V7AJLU4tL8hVyU4uLE9PTM/MVUhPWC2acvLOE rWDNCsaKvgWrWRoYPyxm7GLk4JAQMJF4s6qoi5GLQ0hgCpNEx6+9QHFODjYBG4mDr06wgdgi Am4SjR/2s4EUMQusZ5RYM/MAE0hCWMBZouvnVqgiV4n3SzZC2VYSb272gg1iEVCVuN+9lAlk Ga9AoMT6g7ogYSGBUInt076ygticAmESXZMgbEYBWYkJuxeBtTILiEu8mH6CHcSWEBCQWLLn PDOELSrx8vE/VgjbQGLr0n0sELaixKPmbjYIW0Zi4ZHJrBBz8iXWzH8EVsMrIChxcuYTlgmM orOQrJiFpGwWkrJZQFczC2hKrN+lD1GiKDGl+yFUuYZE65y57MjiCxjZVzGK5lYYGOuVQOI1 syQxJzNRL7NkEyMwHd1cWSm+g7F9pfMhRgEORiUe3sSSvigh1sSy4srcQ4wSHMxKIrxLQ4FC vCmJlVWpRfnxRaU5qcWHGH2A4TiRWUo0OR+YKvNK4g1NLCwNjS0sjAwtzExxCCuJ816Z2Bsl JJAOTHjZqakFqUUw45g4OKUaGB+Yflp81uLPNtuTzdu2Tao3+PSqxuTUnzNPXRiXTpC/23fi vVri/ZVRXYe/r/jRnpOn3XdtpZ2DeWGg3wxthfNCCYtm1T4tmSp8M/TIZr7gcy+5Ai2qCnqP WNSq8Mef0dgg//fqNOXW++/Fb6yez6W7+KzcrKPnVcRYvzyuNJkx9R+fUM/bs9FKLMUZiYZa zEXFiQDTbcfPdAMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/l2sm/mbVF3YcQ9Tj7OedrHCjVMwO4s7E>
Subject: [L2sm] R: AD review of draft-ietf-l2sm-l2vpn-service-model
X-BeenThere: l2sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "The Layer Two Virtual Private Network Service Model \(L2SM\)" <l2sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2sm>, <mailto:l2sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l2sm/>
List-Post: <mailto:l2sm@ietf.org>
List-Help: <mailto:l2sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2sm>, <mailto:l2sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2018 08:25:44 -0000

Thank you Benoit!
We will address your comments and will publish a new version later today.

Best Regards,

Giuseppe

Da: Qin Wu [mailto:bill.wu@huawei.com]
Inviato: giovedì 22 febbraio 2018 06:57
A: draft-ietf-l2sm-l2vpn-service-model@ietf.org
Cc: l2sm@ietf.org; adrian@olddog.co.uk
Oggetto: RE: [L2sm] AD review of draft-ietf-l2sm-l2vpn-service-model

Thanks Benoit.
Authors, please take care of AD review’s comments.
It requires some editorial changes to address them.

-Qin
发件人: L2sm [mailto:l2sm-bounces@ietf.org] 代表 Benoit Claise
发送时间: 2018年2月22日 10:25
收件人: l2sm@ietf.org<mailto:l2sm@ietf.org>
主题: [L2sm] AD review of draft-ietf-l2sm-l2vpn-service-model

Dear all,

Here is the AD review.

- Section 1.2.
You want to use the YANG tree diagrams in draft-ietf-netmod-yang-tree-diagrams-04<https://datatracker.ietf.org/doc/draft-ietf-netmod-yang-tree-diagrams/>
I advice a section similar to https://tools.ietf.org/html/draft-ietf-netmod-rfc7223bis-03#section-1.3

- The draft is NMDA compliant. It should be mentioned.
Ex: draft-ietf-netmod-rfc7223bis-03, in the abstract and intro

   The YANG model in this document conforms to the Network Management

   Datastore Architecture defined in I-D.ietf-netmod-revised-datastores.


- The references to RFC6020 should be changed to RFC7950, except in the IANA considerations.
The YANG module is YANG 1.1

-

 revision 2018-02-05 {

    description

      "Initial revision -04 version";

    reference

      "draft-ietf-l2sm-l2vpn-service-model-05.txt<https://tools.ietf.org/html/draft-ietf-l2sm-l2vpn-service-model-05.txt>

       A YANG Data Model for L2VPN Service Delivery.";

  }



This should be changed to

 revision 2018-02-05 {

    description

      "Initial revision -04 version";

    reference

      "RFC XXXX: A YANG Data Model for L2VPN Service Delivery.";

  }


- https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines
Please doublecheck the template.
The first sentence is:
The YANG module specified in this document defines a schema for data that is designed to be accessed via network management protocols such as NETCONF [RFC6241] or RESTCONF [RFC8040].


Please publish a new version asap.
Note that those changes doesn't prevent the IETF LC to start now.
Hopefully, we could shoot for the March 8th IESDG telechat.

Regards, Benoit

Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie. 

This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks. 

Rispetta l'ambiente. Non stampare questa mail se non è necessario.