[L2tpext] RtgDir review : draft-ietf-l2tpext-sbfd-discriminator

Manav Bhatia <manav@ionosnetworks.com> Thu, 31 December 2015 12:56 UTC

Return-Path: <manav@ionosnetworks.com>
X-Original-To: l2tpext@ietfa.amsl.com
Delivered-To: l2tpext@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7FBB11A8844 for <l2tpext@ietfa.amsl.com>; Thu, 31 Dec 2015 04:56:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.278
X-Spam-Level:
X-Spam-Status: No, score=-1.278 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0sLDMQQk1SU6 for <l2tpext@ietfa.amsl.com>; Thu, 31 Dec 2015 04:55:59 -0800 (PST)
Received: from mail-vk0-x22b.google.com (mail-vk0-x22b.google.com [IPv6:2607:f8b0:400c:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5B9CC1A8833 for <l2tpext@ietf.org>; Thu, 31 Dec 2015 04:55:59 -0800 (PST)
Received: by mail-vk0-x22b.google.com with SMTP id a188so217233136vkc.0 for <l2tpext@ietf.org>; Thu, 31 Dec 2015 04:55:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionosnetworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=YyFnCWSAQkIy2c5zVPkuBxnPdV9jQn0JdUxrZO/BKUY=; b=KWrMh9nD1wsHFgP5SEkk4/a7e6bFH3jqBez2xZAn/WO2GqmVo7zA1cQe6QEdgri0rG vFpdUzYr4gv9z5FFy1ynF/evIpbpx8QcK2o8LbfdvtBqOIZEgxgQe6ZbVmduZQRBg7sg Q1LEpwo8+wDJQiKnfWEG5nF6lXxii/3alcTSYTqiG8xkI1AxLAVfF1dMYvW9ZSjNxDet cfzeHgcdDbLNskzbt+L8JTSxoKHU7GYNUmm6i+2tZnNJODV/zdwOs+pA6ol/if3g4OaN MeLGstrQA3Av/gbeasMxDP5Qiwpl8Q9etkGvHJ6Z3SamBMcNUvJkMb0llrbB4ecHBX+Q Q7TQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=YyFnCWSAQkIy2c5zVPkuBxnPdV9jQn0JdUxrZO/BKUY=; b=f4xmV1cSpQnhqNi2aOD1b5/hP0Fhyy6Cxz3zUCA5DD2s1VkfAX+H5RPENlr6JUSPrW 7GyrirSt+Zobk2VmXdga8mZPFoWFlSX/CZB5ROJLPVioOVH0bLv7svyi6Ml5HDU6hmiU nTqhrWIFFOx3Ahbtkmf08rJA+Q0xAaXtaFm9RgIL8a+QQZeSA5if9LY9jn7wVTaTGdBj qmXu1M2rAvGQGuT/FxIlEo+ap+GgFoWmYs3W+xgp0wBBLpPvelwM1E+Ic6GomM7zd2fZ ws2fA/9Cyr59jL+x9C9HKrv8tQLw14Rd4yP6RE/bfe64gPj5ls+rDccFijWkElbLb6+a 0inA==
X-Gm-Message-State: ALoCoQmMWwPlzEil6jdWOs90Kp8Pb9WUGcmbf7M1/8eEw5vgXJ+sJKBndUowejrlkEtCCLTt+5Jjq2WvtHy9Nax6NYQQqNifzQ==
MIME-Version: 1.0
X-Received: by 10.31.171.142 with SMTP id u136mr47523332vke.88.1451566558432; Thu, 31 Dec 2015 04:55:58 -0800 (PST)
Received: by 10.31.48.4 with HTTP; Thu, 31 Dec 2015 04:55:58 -0800 (PST)
Date: Thu, 31 Dec 2015 18:25:58 +0530
Message-ID: <CAGS6MpDZWc7Bpfs7+pHMTwdLfv8460nW_M_9+yHdr_r3fj+2Fg@mail.gmail.com>
From: Manav Bhatia <manav@ionosnetworks.com>
To: "rtg-dir@ietf.org" <rtg-dir@ietf.org>
Content-Type: multipart/alternative; boundary="001a114409801562230528312d15"
Archived-At: <http://mailarchive.ietf.org/arch/msg/l2tpext/ZN0bQwBqZfcM1EpuP8J6U0NhmlE>
Cc: draft-ietf-l2tpext-sbfd-discriminator@ietf.org, l2tpext@ietf.org, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Subject: [L2tpext] RtgDir review : draft-ietf-l2tpext-sbfd-discriminator
X-BeenThere: l2tpext@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Layer Two Tunneling Protocol Extensions <l2tpext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2tpext>, <mailto:l2tpext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l2tpext/>
List-Post: <mailto:l2tpext@ietf.org>
List-Help: <mailto:l2tpext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2tpext>, <mailto:l2tpext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Dec 2015 12:56:01 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request. The purpose of the review is to provide assistance to
the Routing ADs. For more information about the Routing Directorate, please
see  http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-l2tpext-sbfd-discriminator-01.txt
Reviewer: Manav Bhatia
Review Date: 2015-12-31
IETF LC End Date: date-if-known
Intended Status: Proposed Standard (ID says Standards track)

Summary:

I have some minor concerns about this document that I think should be
resolved before publication.

Comments:

I have issues in general readability of the draft. There were parts that
were not very clear but that could also be because i am not very conversant
with L2TP.

Major Issues:

1. The document describes how one or more than one S-BFD descriminator can
be advertised using L2TPv3 AVP. The draft when originally written was
inline with the popular idea then, that a node MAY want to advertise more
than one S-BFD descriminator. This idea however, is losing currency since
the reason that necessitated this capability is now being questioned. Given
this, the authors might need to rewrite sections of this draft, if the
consensus is to remove the notion of advertising multiple discriminators.

Minor Issues:

1. Most of the acroynms have not been expanded and referenced.

2. The figure in the draft is not clear. I dont even want to guess how that
needs to be interpreted.

Cheers, Manav