RtgDir review: draft-ietf-l2vpn-vpls-inter-domain-redundancy-05.txt

"Andrew G. Malis" <agmalis@gmail.com> Tue, 15 April 2014 10:45 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: l2vpn@ietfa.amsl.com
Delivered-To: l2vpn@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFBFB1A03C0; Tue, 15 Apr 2014 03:45:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.599
X-Spam-Level:
X-Spam-Status: No, score=-0.599 tagged_above=-999 required=5 tests=[BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xt1DOhbFD6Sa; Tue, 15 Apr 2014 03:45:22 -0700 (PDT)
Received: from mail-qg0-x22c.google.com (mail-qg0-x22c.google.com [IPv6:2607:f8b0:400d:c04::22c]) by ietfa.amsl.com (Postfix) with ESMTP id 765311A03BB; Tue, 15 Apr 2014 03:45:22 -0700 (PDT)
Received: by mail-qg0-f44.google.com with SMTP id j107so263861qga.3 for <multiple recipients>; Tue, 15 Apr 2014 03:45:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type; bh=OUJTV0IbKqSmLwITVaPe3OPb1mV774WgOqJdmIovAh8=; b=ohBINBYepC5mjveAtECBc+4Az8UIwafwcvNRDQ0b7FMndRJ7+Nsgxof8R1H6TY5wyL tvZ82uIr4aeTg5rJN3Cr88fpiQCaC5bjx201d9pyyYmCQqPmtgLvhwQbUoum4VyGRggR BsQf9mVwXijOXe01j5/n6XZOEbn0NcL0XirSCyeO8EOQ6rSA/UcyZYNQaaHv2L5ER8ma dk00mBU4wsoHN5jSEKEm4kcQucbZYyEluK0KK+doN3J7upavjvmEBu2HsJ9ApTpUnda4 y83aU+qJTs2fHYp/0tboKqvnCITtsjM7k4CkMht7dStzPzhkxNhOjtuqBe53DZPPx4Nk ZbKQ==
X-Received: by 10.224.66.4 with SMTP id l4mr1387055qai.70.1397558719421; Tue, 15 Apr 2014 03:45:19 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.205.69 with HTTP; Tue, 15 Apr 2014 03:44:59 -0700 (PDT)
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Tue, 15 Apr 2014 06:44:59 -0400
Message-ID: <CAA=duU3axdmSkz89F2GFtXYCsY1oSdphHeif-3VsycY8++7UBg@mail.gmail.com>
Subject: RtgDir review: draft-ietf-l2vpn-vpls-inter-domain-redundancy-05.txt
To: rtg-ads@tools.ietf.org
Content-Type: multipart/alternative; boundary=001a11c2905806249004f7127f07
Archived-At: http://mailarchive.ietf.org/arch/msg/l2vpn/IKkKMMB8LKjhb3z14Y167CQ7ZTY
Cc: "l2vpn@ietf.org" <l2vpn@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, draft-ietf-l2vpn-vpls-inter-domain-redundancy.all@tools.ietf.org
X-BeenThere: l2vpn@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Layer 2 Virtual Private Networks <l2vpn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2vpn>, <mailto:l2vpn-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/l2vpn/>
List-Post: <mailto:l2vpn@ietf.org>
List-Help: <mailto:l2vpn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2vpn>, <mailto:l2vpn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Apr 2014 10:45:25 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request. The purpose of the review is to provide assistance to
the Routing ADs. For more information about the Routing Directorate, please
see http://www.ietf.org/iesg/directorate/routing.html

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other IETF Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-l2vpn-vpls-inter-domain-redundancy-05.txt
Reviewer: Andy Malis
Review Date: 15 April 2014
IETF LC End Date: 24 April 2014
Intended Status: Standards Track

Summary:

I have some minor concerns about this document that I think should be
resolved before publication. It also has editorial nits that should be
considered prior to publication.

Comments:

In general, I found the draft straightforward to read and follow. It does
require a working knowledge of draft-ietf-pwe3-iccp-16.txt and RFC 6870,
and it is a very good application of these two specifications.

I noted that the only draft in the references (draft-ietf-pwe3-iccp-16.txt)
is currently in the RFC Editor's queue.

Major Issues:

No major issues found.

Minor Issues:

Section 5.3: The draft includes two variants of the 3:1 protection model,
referred to as options A and B. However, it does not provide any criteria
or guidelines for selection between the two either for code implementation
or network operation. The draft should state whether one or both are
required for implementation (I would guess both) and how to choose between
them operationally (there are hints if you read between the lines, but it
should be explicit). It is also implied (but again not explicitly stated)
that both domains should choose the same option. That should be explicitly
stated, if correct, and should be repeated in Section 6.

Section 6: This section provides two examples of options that need to be
provisioned identically within and/or between RGs for proper operation.
This should be a list of such options rather than just the two examples.

Section 7, second paragraph: Should "could be secured" be "MAY be secured"?

Nits:

Section 1, last paragraph, "behaviour" -> "behavior".

Section 3, fourth paragraph, "P2P" is used without definition. As this is
the only use in the document, I recommend spelling it out to
"point-to-point".

Section 4, third paragraph, "use-case" -> "use case"

Section 5, second paragraph, I personally prefer "manual provisioning"
instead of "manual operation", but the current text is OK if the authors
prefer it.

Section 5.1.3, "that is member" -> "that is a member"

Section 5.3, fourth paragraph: "option A and B" -> "options A and B"

Section 7, last paragraph, "activitiy" -> "activity"
                           "attackes" -> "attacks"