Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt

"Jan Lindblad (jlindbla)" <jlindbla@cisco.com> Mon, 18 September 2017 10:36 UTC

Return-Path: <jlindbla@cisco.com>
X-Original-To: l3sm@ietfa.amsl.com
Delivered-To: l3sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9EEFE13314B for <l3sm@ietfa.amsl.com>; Mon, 18 Sep 2017 03:36:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IUUBYjSfnOFk for <l3sm@ietfa.amsl.com>; Mon, 18 Sep 2017 03:36:22 -0700 (PDT)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E29841321C7 for <l3sm@ietf.org>; Mon, 18 Sep 2017 03:36:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5739; q=dns/txt; s=iport; t=1505730981; x=1506940581; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=eiBUMeJDqwAqaLneCgaZZA0L4XFbWR5XjXaB0XS2bLQ=; b=eUzelT4E99VlSgmQLUzwGiIwu2CdgnuV21Ope2FnOylElwe7zH0zSk9K zkZXIMF0GoaLkPO7xrCa8gTYUxghlLdn1lcyzGSFe8BR50XCv/kKATnlh /f6tX7PJwv2J95bd3aERnopJETrF24yfAkJTkxPBdSR4JxrCIFbbREgHV A=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DOAQBCob9Z/5ldJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1qBUhQTB54DkluHUQqFOwKEP1cBAgEBAQEBAmsohRkDA3cCEAI?= =?us-ascii?q?BCD8HMhQRAQEEDgWJT2SsbyeLAAEBAQEBAQEBAQEBAQEBAQEBAQEBAR2DK4ICg?= =?us-ascii?q?VCCDoJ9iDqCMQWhCAKUU5J4lQgCERkBgTgBV4ENdxVbAYcJdocEgQ8BAQE?=
X-IronPort-AV: E=Sophos;i="5.42,412,1500940800"; d="scan'208,217";a="5017866"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 10:36:21 +0000
Received: from XCH-ALN-008.cisco.com (xch-aln-008.cisco.com [173.36.7.18]) by rcdn-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v8IAaLaB015962 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 18 Sep 2017 10:36:21 GMT
Received: from xch-aln-004.cisco.com (173.36.7.14) by XCH-ALN-008.cisco.com (173.36.7.18) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Mon, 18 Sep 2017 05:36:20 -0500
Received: from xch-aln-004.cisco.com ([173.36.7.14]) by XCH-ALN-004.cisco.com ([173.36.7.14]) with mapi id 15.00.1263.000; Mon, 18 Sep 2017 05:36:20 -0500
From: "Jan Lindblad (jlindbla)" <jlindbla@cisco.com>
To: "David Ball -X (daviball - ENSOFT LIMITED at Cisco)" <daviball@cisco.com>
CC: Qin Wu <bill.wu@huawei.com>, "l3sm@ietf.org" <l3sm@ietf.org>, "Benoit Claise (bclaise)" <bclaise@cisco.com>, Stephane Litkowski <stephane.litkowski@orange.com>, Kenichi Ogaki <ke-oogaki@kddi.com>, "Luis Tomotaki" <luis.tomotaki@verizon.com>, "adrian@olddog.co.uk" <adrian@olddog.co.uk>
Thread-Topic: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
Thread-Index: AdMumCuWLUN8x/LDjUWvHXDkwgSGUAB+tkMAAAA2PQA=
Date: Mon, 18 Sep 2017 10:36:20 +0000
Message-ID: <87B29717-A086-4E9B-8D5A-688070BFF769@cisco.com>
References: <B8F9A780D330094D99AF023C5877DABA9AB358A5@nkgeml513-mbs.china.huawei.com> <2185ebfb-f142-9b8f-a02d-59ffd6453db6@cisco.com>
In-Reply-To: <2185ebfb-f142-9b8f-a02d-59ffd6453db6@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.147.40.239]
Content-Type: multipart/alternative; boundary="_000_87B29717A0864E9B8D5A688070BFF769ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/l3sm/-fypmmuntaNC9safR0kv71z-3Ig>
Subject: Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
X-BeenThere: l3sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: L3VPN Service YANG Model discussion group <l3sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l3sm>, <mailto:l3sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l3sm/>
List-Post: <mailto:l3sm@ietf.org>
List-Help: <mailto:l3sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l3sm>, <mailto:l3sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 10:36:24 -0000

Clarity may be somewhat subjective ;-) but this is also perfectly fine -- if this is the desired semantics, obviously.
/jan

I think a clearer way to achieve this (if it is the desired behaviour) is:

leaf address-family { ... }
leaf address {
    when ../address-family;
    mandatory true;
}

This has the same effect as below (either both must be specified, or neither are), but avoids confusing the reader with a choice that only has one option.


    David

On 16/09/2017 04:04, Qin Wu wrote:
Another option could be to introduce an optional choice here with one alternative, with both elements mandatory.

choice automatic-or-specific-address {
  case specific-address {
    leaf address-family {
      mandatory true;
      ...
    }
    leaf address {
      mandatory true;
      ...
    }
  }
  description "By default address allocation happens automatically. Customer may override using these settings.";
}

Either way, they would both be optional, but come and go as one unit.


--
David Ball
<daviball@cisco.com><mailto:daviball@cisco.com>