Re: [L3sm] Shepherd review of draft-wu-l3sm-rfc8049bis-02.txt

"Adrian Farrel" <adrian@olddog.co.uk> Sun, 20 August 2017 09:50 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: l3sm@ietfa.amsl.com
Delivered-To: l3sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 915B51326EC; Sun, 20 Aug 2017 02:50:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nYDN1tvNzO1z; Sun, 20 Aug 2017 02:50:37 -0700 (PDT)
Received: from asmtp3.iomartmail.com (asmtp3.iomartmail.com [62.128.201.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F82512EC06; Sun, 20 Aug 2017 02:50:37 -0700 (PDT)
Received: from asmtp3.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp3.iomartmail.com (8.13.8/8.13.8) with ESMTP id v7K9oZJU005538; Sun, 20 Aug 2017 10:50:35 +0100
Received: from 950129200 (196.252.114.87.dyn.plus.net [87.114.252.196]) (authenticated bits=0) by asmtp3.iomartmail.com (8.13.8/8.13.8) with ESMTP id v7K9oYCd005528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 20 Aug 2017 10:50:34 +0100
Reply-To: adrian@olddog.co.uk
From: Adrian Farrel <adrian@olddog.co.uk>
To: l3sm@ietf.org, draft-wu-l3sm-rfc8049bis@ietf.org
References: <008901d31994$6466cfb0$2d346f10$@olddog.co.uk>
In-Reply-To: <008901d31994$6466cfb0$2d346f10$@olddog.co.uk>
Date: Sun, 20 Aug 2017 10:50:33 +0100
Message-ID: <00bd01d31999$c4b540e0$4e1fc2a0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQHyy00TydwpJdquGNbctnHmZJKmKaJNlcAg
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1679-8.1.0.1062-23270.006
X-TM-AS-Result: No--20.254-10.0-31-10
X-imss-scan-details: No--20.254-10.0-31-10
X-TMASE-MatchedRID: EMyCvCfVN1H1YAnKwZYkDLMjW/sniEQKzJmqByfAaS3jsTquy0JRi4hs IUVuvfY3C11Czjs2wZlxzdwR5chcmldI3z1FMme3cFEiuPxHjsXv6kiVCTIVStp1biJhIyNRcBa 45GbRMhpFXcm/C/kiiTBdPqJDZ3D5d1Y1V4f00o+vdf2B19ItZRdEegv9bhjqyePPo/WTREzV9x 7gL2l/Muz9k8GTKvvQ06jpFtSmgCmlkv5rfXKqzUhEDfw/93BuSiV8TkZKsPkT7lsB95pa6lUNB m/mlFhbMiRhSPldc+USb55kiYr6J/tbv/3CxyN1cLw8nYQVLshMkOX0UoduuUvpau5VMz55MH1x x17eFtSsRiy0190rtQoW8ORkIqmK4FfximrQLyXAJnGRMfFxyZZ6zKu0q4rtNAG98m3XL7Fndvv VByEuWWhIqt/OFJIe0nsujPvI9cpAYS7mW5FtjbMsPmSZxbpk+nvSwfDbaCUj/BgXooqgw+H7Zf hCofggjScdZ7Wg786WJcbpNaIEAPs6AFvEdeZfHPCema1j/6t9LQinZ4QefL6qvLNjDYTwzz3je hzeneyrusVRy4an8bxAi7jPoeEQftwZ3X11IV0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/l3sm/Ct2mUaD2glmlE-3G3-hnzxRLo48>
Subject: Re: [L3sm] Shepherd review of draft-wu-l3sm-rfc8049bis-02.txt
X-BeenThere: l3sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: L3VPN Service YANG Model discussion group <l3sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l3sm>, <mailto:l3sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l3sm/>
List-Post: <mailto:l3sm@ietf.org>
List-Help: <mailto:l3sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l3sm>, <mailto:l3sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Aug 2017 09:50:39 -0000

Apologies for immediately updating this. I found another set of nits. 

In several places you use "proposed" to describe this work. But since it will be
an RFC we don't need to be so timid.

6.2.1
OLD
   Our proposed model supports any-to-any
NEW
   This model supports any-to-any
END

6.2.2
OLD
  The proposed model provides cloud access configuration
NEW
  The model defined in this document provides cloud access configuration
END

6.2.3
OLD
  The proposed model supports bidirectional
NEW
  This model supports bidirectional
END

6.2.3
OLD
  Some containers proposed in the model
NEW
  Some containers in the model
END

6.6.5
OLD
   Some infeasible access placement scenarios could be created via the
   proposed configuration framework.
NEW
   Some infeasible access placement scenarios could be created via the
   configuration framework.
END

6.12.2.2 as already noted

6.13.1
OLD
  In the proposed model, LDP or BGP can be used
NEW
  In the model, LDP or BGP can be used
END

Adrian

> -----Original Message-----
> From: L3sm [mailto:l3sm-bounces@ietf.org] On Behalf Of Adrian Farrel
> Sent: 20 August 2017 10:12
> To: l3sm@ietf.org; draft-wu-l3sm-rfc8049bis@ietf.org
> Subject: [L3sm] Shepherd review of draft-wu-l3sm-rfc8049bis-02.txt
> 
> Author, All,
> 
> I have done my document shepherd review of this document as part of the
> publication process. My comments are basically nits and I suggest you fix them
> at the same time as addressing the latest comments from David Ball. Then I
will
> do the document write-up and send the draft to the AD for publication.
> 
> Thanks,
> Adrian
> 
> ===
> 
> Many thanks for Section 1.4 that made this review much easier.
> 
> ---
> 
> idnits reports some issues that you should handle:
> 
>   ** There are 132 instances of too long lines in the document, the longest
>      one being 70 characters in excess of 72.
> 
>   It would be really nice if you fixed these.  If you don't then the RFC
>   Editor will introduce line wraps and you might not like how they do it.
> 
> 
>   == There are 2 instances of lines with non-RFC6890-compliant IPv4 addresses
>      in the document.  If these are example addresses, they should be changed.
> 
>   This is a bogus warning, you can ignore it.
> 
> 
>   == Line 486 has weird spacing: '...--rw id    str...'
>   == Line 488 has weird spacing: '...--rw id    str...'
>   == Line 490 has weird spacing: '...--rw id    str...'
>   == Line 492 has weird spacing: '...--rw id    str...'
>   == Line 566 has weird spacing: '...roup-id    str...'
>   == (20 more instances...)
> 
>   These are bogus warnings, you can ignore them.
> 
> 
>   == Missing Reference: 'VPN2' is mentioned on line 1839, but not defined
>   == Missing Reference: 'VPN3' is mentioned on line 1848, but not defined
> 
>   This is the figure in 6.5.2.2.  I suggest that you use curved brackets
>   as '(VPN2)'
> 
> 
>   == Unused Reference: 'RFC6020' is defined on line 8310, but no explicit
>      reference was found in the text
> 
>   I think you can simply remove this reference.
> 
> 
>   ** Downref: Normative reference to an Informational RFC: RFC 4026
> 
>   You can move this reference to be Informative consistent with the
>   reference to RFC 4110.
> 
> ---
> 
> Section 1
> 
> OLD
>    If approved, this document obsoletes [RFC8049].  The changes are a
>    series of small fixes to the YANG module, and some clarifications to
>    the text.
> 
>    The following changes were made:
> 
>    o  First change
> 
>    o  ...
> 
>    o  Last change
> NEW
>    If approved, this document obsoletes [RFC8049].  The changes are a
>    series of small fixes to the YANG module, and some clarifications to
>    the text.  The changes are listed in Section 1.4.
> END
> 
> ---
> 
> Section 5
> 
> OLD
>    The model is
>    intended to be used in the way that the network operator's system is
>    the server and the customer's system is the client.
> NEW
>    The model is
>    intended to be used in a mode where the network operator's system is
>    the server and the customer's system is the client.
> END
> 
> ---
> 
> Section 6.3
> 
> OLD
>    A particular location or a set of locations must be
>    associated with each site.
> NEW
>    Each site is associated with one or more location.
> END
> 
> ---
> 
> Section 6.12.2.2
> 
> OLD
>    o  direction: used to specify the direction which qos profile is
>       applied to.  Our proposed model supports "Site-to-WAN" direction,
>       "WAN-to-Site"direction and "both" direction.  By default, "both"
>       direction is used.
> NEW
>    o  direction: used to specify the direction to which the qos profile
>       is applied.  This model supports three direction settings:
>       "Site-to-WAN", "WAN-to-Site", and "both".  By default, the "both"
>       direction value is used.
> END
> 
> ---
> 
> Section 11
> 
> OLD
>    This document adds a new YANG module name in the "YANG Module Names"
>    registry [RFC7950]:
> 
>            Name: ietf-l3vpn-svc
>            Namespace: urn:ietf:params:xml:ns:yang:ietf-l3vpn-svc
>            Prefix: l3vpn-svc
>            Reference: RFC 8049
> NEW
>    IANA has recorded a YANG module name in the "YANG Module Names"
>    registry [RFC7950] as follows:
> 
>            Name: ietf-l3vpn-svc
>            Namespace: urn:ietf:params:xml:ns:yang:ietf-l3vpn-svc
>            Prefix: l3vpn-svc
>            Reference: RFC 8049
> 
>    IANA is requested to update this registry to reference this document
>    on publication as an RFC.
> END
> 
> _______________________________________________
> L3sm mailing list
> L3sm@ietf.org
> https://www.ietf.org/mailman/listinfo/l3sm