IETF Logo Mail Archive

Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt

Qin Wu <bill.wu@huawei.com> Wed, 11 October 2017 09:14 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: l3sm@ietfa.amsl.com
Delivered-To: l3sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 35F1D128D0D for <l3sm@ietfa.amsl.com>; Wed, 11 Oct 2017 02:14:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MhkCDxdSfW92 for <l3sm@ietfa.amsl.com>; Wed, 11 Oct 2017 02:13:58 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 244B9133023 for <l3sm@ietf.org>; Wed, 11 Oct 2017 02:13:58 -0700 (PDT)
Received: from 172.18.7.190 (EHLO LHREML713-CAH.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DXI41929; Wed, 11 Oct 2017 09:13:54 +0000 (GMT)
Received: from NKGEML411-HUB.china.huawei.com (10.98.56.70) by LHREML713-CAH.china.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.301.0; Wed, 11 Oct 2017 10:12:56 +0100
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.199]) by nkgeml411-hub.china.huawei.com ([10.98.56.70]) with mapi id 14.03.0235.001; Wed, 11 Oct 2017 17:12:50 +0800
From: Qin Wu <bill.wu@huawei.com>
To: "Jan Lindblad (jlindbla)" <jlindbla@cisco.com>
CC: "David Ball -X (daviball - ENSOFT LIMITED at Cisco)" <daviball@cisco.com>, l3sm <l3sm@ietf.org>
Thread-Topic: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
Thread-Index: AQHTQQWsNfIEJ/tueE6vL9DaPP0v1qLc10iQ///Pb4CAAWKscP//xwmAgACKDbA=
Date: Wed, 11 Oct 2017 09:12:50 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA9ABA8DB6@nkgeml513-mbx.china.huawei.com>
References: <B8F9A780D330094D99AF023C5877DABA9AB378D8@nkgeml513-mbs.china.huawei.com> <c5269278-b3a4-a12e-a911-0af20d7baa21@cisco.com> <B8F9A780D330094D99AF023C5877DABA9ABA732C@nkgeml513-mbx.china.huawei.com> <e5103039-d554-2259-d15d-f9f1da248c73@cisco.com> <B8F9A780D330094D99AF023C5877DABA9ABA8A63@nkgeml513-mbx.china.huawei.com> <901E5F78-19DD-4CF7-A6BE-221C5A9BDF25@cisco.com>
In-Reply-To: <901E5F78-19DD-4CF7-A6BE-221C5A9BDF25@cisco.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.79.163]
Content-Type: multipart/alternative; boundary="_000_B8F9A780D330094D99AF023C5877DABA9ABA8DB6nkgeml513mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.59DDE0D3.005B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.1.199, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 3559a394797ae8daebdfca3b7d662411
Archived-At: <https://mailarchive.ietf.org/arch/msg/l3sm/f7FCJOS9vKhSxMam1jMiDLM6Weo>
Subject: Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
X-BeenThere: l3sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: L3VPN Service YANG Model discussion group <l3sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l3sm>, <mailto:l3sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l3sm/>
List-Post: <mailto:l3sm@ietf.org>
List-Help: <mailto:l3sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l3sm>, <mailto:l3sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2017 09:14:02 -0000

发件人: Jan Lindblad (jlindbla) [mailto:jlindbla@cisco.com]
发送时间: 2017年10月11日 16:38
收件人: Qin Wu
抄送: David Ball -X (daviball - ENSOFT LIMITED at Cisco); l3sm
主题: Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt

[DB]
Yes, that makes sense.  Should they also be strict inequalities, or is it ok if l4-src-port is equal to lower-port?

[Qin]: Good comment, fixed with
“
must "'.' < '../ipv4-dst-port-range/lower-port' or '.' > '../ipv4-dst-port-range/upper-port'" {
”

I'm afraid this expression will not to what you expect. This compares a constant one letter string to another constant string, or:ed with a constant string compared to another constant string. This will be constantly true or false, and not depend on any configuration data. Also, the dot (.) object is treacherous. Except in some extremely odd cases, what you mean is actually current().

So I would propose
must "current() < ../ipv4-dst-port-range/lower-port or current() > ../ipv4-dst-port-range/upper-port" {

[Qin]: My bad, you are right, will fix as you suggested, thanks.
/jan

v2.23.0 | Report a Bug | By Email