Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt

"Jan Lindblad (jlindbla)" <jlindbla@cisco.com> Wed, 11 October 2017 08:39 UTC

Return-Path: <jlindbla@cisco.com>
X-Original-To: l3sm@ietfa.amsl.com
Delivered-To: l3sm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E7F1128D0D for <l3sm@ietfa.amsl.com>; Wed, 11 Oct 2017 01:39:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yWjxrIMFPDJf for <l3sm@ietfa.amsl.com>; Wed, 11 Oct 2017 01:39:41 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E524B126CB6 for <l3sm@ietf.org>; Wed, 11 Oct 2017 01:39:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5466; q=dns/txt; s=iport; t=1507711180; x=1508920780; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=kezB+EoOe+NW6kuHiWqMUDkooi1A+Gzd6SszVtBZtJ8=; b=haRhzgC7WdBsQs8I7QI+QdT9/Iggy0iNyEY1RbslrqU+sQ5Ym6DQ90Lt f2QwES+iORZiaTkaQSGgzEFFNmvRXXzhc03e3S/3weGWYuiGdV0oYMn0L V7h43TX8hix3KZd0YIEjYcZkq/RSqtpL8H4beLf8Za8wnIG7csGiAXduV U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0A9AgAb2N1Z/51dJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBgm9sgVIug3OZR5JmhT+CEgqFOwIahD1AFwECAQEBAQEBAWsohR4?= =?us-ascii?q?GI1QCEAIBCAQKNAICAjAlAQEEDolFZKh7gieLNQEBAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAR2DLYICgVGCFYJ+iBcvgjIFoTwClGeTD5U2AhEZAYE4ASABNoEOeBVbAYc?= =?us-ascii?q?KiTqBEAEBAQ?=
X-IronPort-AV: E=Sophos;i="5.43,360,1503360000"; d="scan'208,217";a="306366967"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2017 08:38:21 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id v9B8cKO0015032 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 11 Oct 2017 08:38:20 GMT
Received: from xch-aln-004.cisco.com (173.36.7.14) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 11 Oct 2017 03:38:20 -0500
Received: from xch-aln-004.cisco.com ([173.36.7.14]) by XCH-ALN-004.cisco.com ([173.36.7.14]) with mapi id 15.00.1320.000; Wed, 11 Oct 2017 03:38:20 -0500
From: "Jan Lindblad (jlindbla)" <jlindbla@cisco.com>
To: Qin Wu <bill.wu@huawei.com>
CC: "David Ball -X (daviball - ENSOFT LIMITED at Cisco)" <daviball@cisco.com>, l3sm <l3sm@ietf.org>
Thread-Topic: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
Thread-Index: AdMumcwCLUN8x/LDjUWvHXDkwgSGUASlbxOAACo8IgAACjfmgAAbnnQAAAmXtgA=
Date: Wed, 11 Oct 2017 08:38:19 +0000
Message-ID: <901E5F78-19DD-4CF7-A6BE-221C5A9BDF25@cisco.com>
References: <B8F9A780D330094D99AF023C5877DABA9AB378D8@nkgeml513-mbs.china.huawei.com> <c5269278-b3a4-a12e-a911-0af20d7baa21@cisco.com> <B8F9A780D330094D99AF023C5877DABA9ABA732C@nkgeml513-mbx.china.huawei.com> <e5103039-d554-2259-d15d-f9f1da248c73@cisco.com> <B8F9A780D330094D99AF023C5877DABA9ABA8A63@nkgeml513-mbx.china.huawei.com>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABA9ABA8A63@nkgeml513-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.147.40.122]
Content-Type: multipart/alternative; boundary="_000_901E5F7819DD4CF7A6BE221C5A9BDF25ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/l3sm/hOgkG-Luzr29td0lpltbLeFMUpc>
Subject: Re: [L3sm] New Version Notification for draft-wu-l3sm-rfc8049bis-03.txt
X-BeenThere: l3sm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: L3VPN Service YANG Model discussion group <l3sm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l3sm>, <mailto:l3sm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/l3sm/>
List-Post: <mailto:l3sm@ietf.org>
List-Help: <mailto:l3sm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l3sm>, <mailto:l3sm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2017 08:39:42 -0000

[DB]
Yes, that makes sense.  Should they also be strict inequalities, or is it ok if l4-src-port is equal to lower-port?

[Qin]: Good comment, fixed with
“
must "'.' < '../ipv4-dst-port-range/lower-port' or '.' > '../ipv4-dst-port-range/upper-port'" {
”

I'm afraid this expression will not to what you expect. This compares a constant one letter string to another constant string, or:ed with a constant string compared to another constant string. This will be constantly true or false, and not depend on any configuration data. Also, the dot (.) object is treacherous. Except in some extremely odd cases, what you mean is actually current().

So I would propose
must "current() < ../ipv4-dst-port-range/lower-port or current() > ../ipv4-dst-port-range/upper-port" {

/jan