IETF Logo Mail Archive

Re: [Last-Call] Rtgdir last call review of draft-ietf-lisp-vendor-lcaf-10

Dino Farinacci <farinacci@gmail.com> Wed, 27 April 2022 06:10 UTC

Return-Path: <farinacci@gmail.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B13B2C15E3F9; Tue, 26 Apr 2022 23:10:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fxuI0gdC4UOW; Tue, 26 Apr 2022 23:10:23 -0700 (PDT)
Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 37745C15E3F7; Tue, 26 Apr 2022 23:10:23 -0700 (PDT)
Received: by mail-pg1-x52a.google.com with SMTP id g3so676186pgg.3; Tue, 26 Apr 2022 23:10:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=fN0qK6MYLkPYGLz5FZXC8nCiI1FwMpiDYJYs0pywmK8=; b=LI+/Xzlf1dqBArhosAguMApIRNr2Aju2uM4LT3LMiP7xKQh77UiAgyBraH2GggxNu5 WfbryXyJsKUq2ef+rmNoMEbBt4UwxJDrrdqDR42uHrvF8nRVZD9aNzUYwrfia07fdSDR rM+VeKfvZk0k6aW9Yhmilharl1nU/lz3ef2BPVjaLALB372lThNTLKeTEIvkVkqEMmcc NdlTIRmiXJP0ln0tQRoI5txdn4t5fp1HoNoPvS7NBq/HhXV3I+FEmA8UdXwFcsxZOFYI YdiRaTz2DhSTzEo+lJSgkWr1XgEFpyOtjeCYnCPKOCrP/I6EQV03UBguHNOktBH+388b wJZw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=fN0qK6MYLkPYGLz5FZXC8nCiI1FwMpiDYJYs0pywmK8=; b=jBsW2MBMiY3IIrYIB7fCXzrQBPiT6cqjQYx1jWokxL4nWLGFKsvyiR8GE+uda0Omlc i+1Zcf93jdPg2QBYiwLuTkByKNH+xWN3zO9+fCgvfvHLlOSaSdvFrYiWo4QWMbub0atd M4nAIW7/jFFjLl8w7sUhE6QIEsVgIZp+KtU36qLZSkqjO7ZsvK9vlhRDTWmof6NABx1x SZKG1YKDAfVN0bEmFpyy1CP7p4IitsipKymuBzXmceKUsBZppqF+Ss/ZETIzX94zAq11 HfWliEqBoRMAJrMoP6X0NN+pfSFQm9aPlNgmlqwBCeRm7w9bEuGGKAkcsv6GOTENP5rx 5b6w==
X-Gm-Message-State: AOAM531BM1AySqFVv3p0KmAjB26TCDCbSHT3Wa1X5Kk8IUzGFmVCFXSg CZxn1byj71/53HrlRPtvCaLTbfkz7Gk=
X-Google-Smtp-Source: ABdhPJxRDvry4m6zCx9k+y9Hm5IzWVXYVgtuWr0AZjlrJK5yUvaV1+wNTNfwjDOzblUE+HGN4qpOMg==
X-Received: by 2002:a05:6a00:a94:b0:4fd:c14b:21cb with SMTP id b20-20020a056a000a9400b004fdc14b21cbmr28218753pfl.53.1651039821247; Tue, 26 Apr 2022 23:10:21 -0700 (PDT)
Received: from smtpclient.apple ([2601:646:9600:fef0:89ac:ab2e:4c62:739f]) by smtp.gmail.com with ESMTPSA id u10-20020a17090a890a00b001cb14240c4csm1376893pjn.1.2022.04.26.23.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 23:10:20 -0700 (PDT)
Content-Type: multipart/alternative; boundary=Apple-Mail-D2F51B30-1BC6-4F02-AF44-DBE354525842
Content-Transfer-Encoding: 7bit
From: Dino Farinacci <farinacci@gmail.com>
Mime-Version: 1.0 (1.0)
Date: Tue, 26 Apr 2022 23:10:19 -0700
Message-Id: <D35E0043-6DA7-4147-872F-355A5FF5DCF1@gmail.com>
References: <CAP7zK5bL0ZOjw_93Q1OSe_nyVELUhs3PFZwBMcqbC6QMcVGuMg@mail.gmail.com>
Cc: "Alberto Rodriguez-Natal (natal)" <natal@cisco.com>, rtg-dir@ietf.org, draft-ietf-lisp-vendor-lcaf.all@ietf.org, last-call@ietf.org, lisp@ietf.org
In-Reply-To: <CAP7zK5bL0ZOjw_93Q1OSe_nyVELUhs3PFZwBMcqbC6QMcVGuMg@mail.gmail.com>
To: Dhruv Dhody <dd@dhruvdhody.com>
X-Mailer: iPhone Mail (19F5057e)
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/J8ZhQhH3RPs2UFqDspMoDuCVlak>
Subject: Re: [Last-Call] Rtgdir last call review of draft-ietf-lisp-vendor-lcaf-10
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2022 06:10:23 -0000

So we designed LCAFs to be short-word (16-bit) aligned so we wouldn’t waste packet space. Having an LCAF larger than 65535 bytes we felt wasn't necessary.  And same for the total number of types. 

Dino

> On Apr 26, 2022, at 8:48 PM, Dhruv Dhody <dd@dhruvdhody.com> wrote:
> 
> In some protocols that I am aware of, it is usual to state that the variable-length portion in the TLVs/objects is 4-byte aligned. But looking at RFC 8060, I see that LISP does not follow this approach for any of the LCAF and it works just fine without it. I agree with you that no change is required then. Thanks for taking my comment into consideration.

v2.8.7 | Report a Bug | By Email