Re: [Last-Call] [Extra] Opsdir last call review of draft-ietf-extra-imap-partial-02

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 05 December 2022 11:36 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 807F5C1522AB; Mon, 5 Dec 2022 03:36:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nE79b_mG4Cy9; Mon, 5 Dec 2022 03:36:37 -0800 (PST)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id 8FC2CC14CE4E; Mon, 5 Dec 2022 03:36:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1670240196; d=isode.com; s=june2016; i=@isode.com; bh=vGT5fuJMCMsIQ7qQ/opBcKoQk+BrSVIS7cLyCh4Irv4=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=oEG0z6ajhyF2AX81PelTqf5qSNEIc2jqpgJHJbca+8zR7O4l5YyywdNGnSoXnJkOx0yDJl CLkxRuEmwaMbG8CHJaEZbQ9xO77rskm9YIiEz4jqEMYMOEsGmxZUL+v2Dvn2p+ej4Bq6Pf aYLDrfP2hTSnlbKtuezRt1AWNIu2SFU=;
Received: from [192.168.1.222] (host31-49-219-67.range31-49.btcentralplus.com [31.49.219.67]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <Y43XwwAPgVpD@statler.isode.com>; Mon, 5 Dec 2022 11:36:35 +0000
Message-ID: <390dd970-8d6c-71cf-6299-a249ef5332d5@isode.com>
Date: Mon, 05 Dec 2022 11:36:34 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2
From: Alexey Melnikov <alexey.melnikov@isode.com>
To: Yingzhen Qu <yingzhen.ietf@gmail.com>, ops-dir@ietf.org
Cc: draft-ietf-extra-imap-partial.all@ietf.org, extra@ietf.org, last-call@ietf.org
References: <166906092177.62314.5285463903860804171@ietfa.amsl.com> <6aa9e4cb-a46a-cb1d-6a9c-300025d208a2@isode.com>
In-Reply-To: <6aa9e4cb-a46a-cb1d-6a9c-300025d208a2@isode.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/JwvjEd2c_fHLRvRT2z2jBfP9SCc>
Subject: Re: [Last-Call] [Extra] Opsdir last call review of draft-ietf-extra-imap-partial-02
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Dec 2022 11:36:41 -0000

Dear Yingzhen Qu,

On 24/11/2022 11:51, Alexey Melnikov wrote:
> Dear Yingzhen Qu,
>
> Thank you for your review!
>
> My answers are below:
>
> On 21/11/2022 20:02, Yingzhen Qu via Datatracker wrote:
>> Reviewer: Yingzhen Qu
>> Review result: Has Nits
>>
>> I have reviewed this document as part of the Operational 
>> directorate's ongoing
>> effort to review all IETF documents being processed by the IESG. 
>> These comments
>> were written with the intent of improving the operational aspects of 
>> the IETF
>> drafts. Comments that are not addressed in last call may be included 
>> in AD
>> reviews during the IESG review. Document editors and WG chairs should 
>> treat
>> these comments just like any other last call comments.
>>
>> Document: draft-ietf-extra-imap-partial-02
>> Reviewer: Yingzhen Qu
>> Review Date: 2022-11-20
>>
>> Summary:
>> This document extends PARTIAL SEARCH return option defined in RFC 5267.
>> The document is ready, but the following nits should be considered
>> before publication.
>>
>> General: this documents still has a normative reference to RFC 3501, 
>> which
>> was obsoleted by RFC 9051. RFC 3501 is referenced multiple times in the
>> draft.
>>
>> Nits (line numbers are from idnits):
>>
>> 90   This document defines an extension to the Internet Message Access
>> 91   Protocol [RFC3501] for performing incremental searches and fetches.
>>
>> major: RFC 9051 should be referenced here instead of RFC 3501.
> Ok, I will review this. The intend was to reference both RFC 3501 and 
> RFC 9051.
I checked and I think the following sentence is quite clear on that. So 
I haven't done any change.
>> 101   This document extends PARTIAL SEARCH return option originally
>>
>> nits: should it be "PARTIAL SEARCH" (used 4 times) or "PARTIAL search"
>> (used 2 times)?
> Well spotted. It should be "PARTIAL SEARCH" in all cases.
>> 245 +------------------------------+---------------------+
>> 246              |    SAVE PARTIAL COUNT [m]    |  all found messages |
>> 247 +------------------------------+---------------------+
>>
>> 249                                     Table 1
>>
>> 251       where '[m]' means optional "MIN" and/or "MAX"
>>
>> Question: If the SAVE + PARTIAL result options are combined with COUNT,
>> MIN and MAX, what the result would be? The text above the table didn't
>> cover this case.
>
> This is covered by the last line of the table, as it also applies when 
> both MIN and MAX are present, as per the comment under the table.
I tried to clarify that.