Re: [Last-Call] [Gen-art] Genart last call review of draft-ietf-ippm-ioam-conf-state-06

Lars Eggert <lars@eggert.org> Wed, 26 October 2022 08:53 UTC

Return-Path: <lars@eggert.org>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3BE2C1522C9; Wed, 26 Oct 2022 01:53:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NhQWavhqkQly; Wed, 26 Oct 2022 01:53:51 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 84263C1522C1; Wed, 26 Oct 2022 01:53:51 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:dbd:1611:1173:8420]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 30B531DBAF7; Wed, 26 Oct 2022 11:53:40 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1666774420; bh=lL2XVFD7aLeBU6nCkJj/Su+enVUJ5jB2mTwhI2ajid0=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=W2pvCMOiEx/Cr4XmjojeGNSLFCOZJF/F/qjttTQmeBjXn4V/SccDsM3DewGKL7kyA LMx1G1SyqNnNF1HC4qjot3yIQiIuHNIKsmAjMATJdEp/TpmEbweAQRG9hcPNiy6VMr cIVxgu3pfo+vGXtIW9V1ShMJSaNMFp1/FL7QaC1s=
Content-Type: multipart/signed; boundary="Apple-Mail=_B08FA39C-1B2E-468B-AE08-71210EE9747A"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <166541584130.48944.863927247671754385@ietfa.amsl.com>
Date: Wed, 26 Oct 2022 11:53:29 +0300
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-ippm-ioam-conf-state.all@ietf.org, ippm@ietf.org, last-call@ietf.org
Message-Id: <A14175A9-E2FC-4622-9E26-D0118A261F2C@eggert.org>
References: <166541584130.48944.863927247671754385@ietfa.amsl.com>
To: Gyan Mishra <hayabusagsm@gmail.com>
X-MailScanner-ID: 30B531DBAF7.A4337
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/O8iPnPwS7uxiNTR4HEDZoA44oxQ>
Subject: Re: [Last-Call] [Gen-art] Genart last call review of draft-ietf-ippm-ioam-conf-state-06
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2022 08:53:56 -0000

Gyan, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On Oct 10, 2022, at 18:30, Gyan Mishra via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Gyan Mishra
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ippm-ioam-conf-state-??
> Reviewer: Gyan Mishra
> Review Date: 2022-10-10
> IETF LC End Date: 2022-10-06
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
>   This document describes an extension to the echo request/reply
>   mechanisms used in IPv6 (including Segment Routing with IPv6 data
>   plane (SRv6)), MPLS (including Segment Routing with MPLS data plane
>   (SR-MPLS)), Service Function Chain (SFC) and Bit Index Explicit
>   Replication (BIER) environments, which can be used within the In situ
>   Operations, Administration, and Maintenance (IOAM) domain, allowing
>   the IOAM encapsulating node to discover the enabled IOAM capabilities
>   of each IOAM transit and IOAM decapsulating node.
> 
> The draft is well written and is almost ready for publication.
> 
> Major issues:
> None
> 
> Minor issues:
> I believe the draft should make more clear  the use of the capabilities
> discovery extension throughout the draft that it applies to both IOAM data and
> use of IOAM DEX “draft-ietf-ippm-ioam-direct-export-11” and if it applies to
> one or the other to make that clear.  I can understand how it can easily apply
> to IOAM Data but for IOAM DEX is based on an export off line postcard based
> telemetry I am not sure how this extension could be applicable.  Also the
> applicability to both use cases above should be explained in section 4
> operational guide.
> 
> Nits/editorial comments:
> Please review the SHOULD normative language where I think maybe MUST might be
> appropriate
> 
> middle of page 6
> 
>   If there is no IOAM capability to be reported by the receiving node,
>   then this container SHOULD be ignored by the receiving node, which
>   means the receiving node SHOULD send an echo reply without IOAM
>   capabilities or no echo reply, in the light of whether the echo
>   request includes other containers than the IOAM Capabilities Query
>   Container.
> 
> middle of page 7
> 
>   A list of IOAM capabilities objects (one
>   or more objects) which contains the enabled IOAM capabilities SHOULD
>   be included in this container of echo reply.
> 
> middle of page 8
> 
>   Namespace-ID field has the same definition as what's specified in
>   Section 4.3 of [RFC9197], it should be one of the Namespace-IDs
>   listed in the IOAM Capabilities Query Object of the echo request.
> 
> top of page 13
> 
>   For the echo reply, there
>   should be an IOAM Capabilities Response Container containing one or
>   more Objects.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art