Re: [Last-Call] Genart last call review of draft-ietf-dots-robust-blocks-05

mohamed.boucadair@orange.com Tue, 27 September 2022 05:44 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3800C14CE2E; Mon, 26 Sep 2022 22:44:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26pmOKiGxsJj; Mon, 26 Sep 2022 22:44:11 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BCECCC14F733; Mon, 26 Sep 2022 22:44:10 -0700 (PDT)
Received: from opfedar02.francetelecom.fr (unknown [xx.xx.xx.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfedar27.francetelecom.fr (ESMTP service) with ESMTPS id 4Mc7pw60Wkz2ySC; Tue, 27 Sep 2022 07:44:08 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1664257448; bh=j7dXDfWZ9hyBeerMWsg8YFri5nEssJVHD5OuHs8n2l0=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=OPDwhQWqlXfj/y8hcBypes5StsAD0mpPazVCQxDiBVyPswB4F9dnRO7XHjWFe5+CL XoOQS7gNRfwFj19nx5BrJlEpNprbP7LN2g/szvwzHS2TUcIa4XqY8ObsbVSLZEj8+a HZi61x9s8YR2LPbOojNPFeqS7oxwGOmui2RYuJEFFtQeS3bkIa4KYg8LEatuwqbZrS b6Ld7CHpA9i8WjP6yR7P7WCSAzeYtO4sqnVDAK/mJdzhjpCR88rnVg8nsGlUOlcPPa f2dHra6JXEvVUA2Z5rkAKHPaJdne9xz8D8Lu17R6kMl88f6iG82BNf1eSVe0zC4kht Lh8NrtNV75VGQ==
From: <mohamed.boucadair@orange.com>
To: Tim Evens <tievens@cisco.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "dots@ietf.org" <dots@ietf.org>, "draft-ietf-dots-robust-blocks.all@ietf.org" <draft-ietf-dots-robust-blocks.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-dots-robust-blocks-05
Thread-Index: AQHY0h/kTkgurs2TMEOEZtoiL5+p663ywb7A
Content-Class:
Date: Tue, 27 Sep 2022 05:44:08 +0000
Message-ID: <2073_1664257448_63328DA8_2073_111_1_1d0096a448c546308b54f3f51a053b93@orange.com>
References: <166424873911.33674.13795353189229005326@ietfa.amsl.com>
In-Reply-To: <166424873911.33674.13795353189229005326@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2022-09-27T05:36:11Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=7294add7-d286-4293-823f-0b03239535e5; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.115.27.51]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/Pc_-8zYHjIctPP2X-6Dlubth3Hw>
Subject: Re: [Last-Call] Genart last call review of draft-ietf-dots-robust-blocks-05
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2022 05:44:14 -0000

Hi Tim, 

Thank you for the review. 

You can track the changes made to address your comments at: https://tinyurl.com/dots-robust-latest. FWIW, please see inline for more context.

Cheers,
Med

> -----Message d'origine-----
> De : Tim Evens via Datatracker <noreply@ietf.org>
> Envoyé : mardi 27 septembre 2022 05:19
> À : gen-art@ietf.org
> Cc : dots@ietf.org; draft-ietf-dots-robust-blocks.all@ietf.org;
> last-call@ietf.org
> Objet : Genart last call review of draft-ietf-dots-robust-blocks-
> 05
> 
> Reviewer: Tim Evens
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General
> Area Review Team (Gen-ART) reviews all IETF documents being
> processed by the IESG for the IETF Chair.  Please treat these
> comments just like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-dots-robust-blocks-??
> Reviewer: Tim Evens
> Review Date: 2022-09-26
> IETF LC End Date: 2022-09-16
> IESG Telechat date: 2022-10-06
> 
> Summary: This document is ready with some minor comments.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1) +1 to Paul's Nits
> 
> 2) Upon initial read, the abstract could suggest new parameters
> being introduced for configuration, yet that is not the case for
> this document. In Section 1 it is more clear by writing "This
> document augments the "ietf-dots-signal-channel" DOTS signal YANG
> module defined in Section 5.3 of [RFC9132]". It appears to me that
> this document adds the existing RFC9177 non-confirming parameters
> to DOTS. I'm not suggesting that the abstract needs to be changed,
> but IMO it is a bit misleading till you read the intro.
> 

[Med] The abstract is correct, but added a new sentence to indicate that the new parameters are added by augmenting the DOTS signal channel model. 

> 3) In section 1; "Nevertheless, the parameters listed in Table 1
> are not supported in [RFC9132]". While "not supported" is correct,
> I believe that it would be more clear as "not included"
> considering the parameters do exist.
> 

[Med] Changed to "negotiating ... is not supported". 

> 4) In section 3, the parameters are restated from RFC9177 and
> RFC9132.
> 
> Each parameter looks to be a redefinition of what's documented in
> RFC9177 but with missing statements, truncated. I would prefer
> that if the parameter is unchanged to RFC9177, it should simply
> state that it's the same as defined in RFC9177.
> 
> Restating/documenting the parameters leads the reader to have to
> compare if there is a change from the source RFC.
> 

[Med] The current approach was adopted for the reader's convenience. We do point systematically to the authoritative RFCs and keep repeating "parameter XX echoes xxx in RFC9177". I prefer to keep the current structure. Thank you. 


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.