Re: [Last-Call] Rtgdir last call review of draft-ietf-lsr-ospf-reverse-metric-04

Ketan Talaulikar <ketant.ietf@gmail.com> Thu, 28 April 2022 14:48 UTC

Return-Path: <ketant.ietf@gmail.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F2A0C159A39; Thu, 28 Apr 2022 07:48:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f49FstggynNg; Thu, 28 Apr 2022 07:48:17 -0700 (PDT)
Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 82E71C159A31; Thu, 28 Apr 2022 07:48:14 -0700 (PDT)
Received: by mail-vk1-xa32.google.com with SMTP id e144so2428298vke.9; Thu, 28 Apr 2022 07:48:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m3y28Rl4NPQAWKCE42D5DjKy+tUW98ZqVkQAEt0t7LQ=; b=HGK63zQeVlh9lSJE9m50RWBSnlEGwq8UsrJGpN0YhT9FuslKGs/hXiVfxKpQEpWk6j eHT8yWFHXJc1bFTzGyBFAKhysIlKTTXmv6tU/viv9RFe7sgXwM0C98sW48U30vCYxR0+ rcytC3QsgYkXJbtpdXCZ+4sw+vF5m9dLkkBFJN0g1t8IFfsMxnnfVXC25evDcmxv8RNQ zXpOlUJaM+5TBW1dTSYrmGhHJ+3A1XkoaXbqpZNvGSmpi4ggeFJoy8hniNqCpq0JhgtZ BBZD7nOCEXbSEYA97vAJy4/+6LqKQ6gaKRohnBb9TJM/Lt0Osd+49zYysAN3W1YU5evV 21sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m3y28Rl4NPQAWKCE42D5DjKy+tUW98ZqVkQAEt0t7LQ=; b=JCGd1M7yccFoj5WMtqsHt2VHsJ2R4CYL+JcO+qTRN3WnliJaQHDhF+sehlZ+P0LE0O DiNRI2X9Zg/H/PhuTC8X4kYiItNsht1rNgU4xN5VJSiiBH29HpiS6RUNm3CohnyRv1CY qX4cXCJfhfX5G9hNbN9BJ5GSGOHTw1c32OvJcuuJMuBYlZy9ys6wEpouIQOzlLAsZaLF 1qysnA25mrci4mCChgax5bJy9uI+gnyzefnDputNfZ5ss5BlEd3Oat/E/5Z0cfhKc2Vm aLRd78kd670AHY1ZvRCROtyjcgKrrAsdn9Rb6ySyG0+oHOVZm0eebVVE/aiaR+zdl0Sz l5Pw==
X-Gm-Message-State: AOAM532kn0MyGUWVLmIRw+wy3XjNfNjknFQcQ5a24sYMyh2J8fLgDEZz Jeab8Jozf8ANOL5QWHhTfr9DvPqz9GMoRmzjZHI=
X-Google-Smtp-Source: ABdhPJwtlNiy1vAn1rYTNh2R5AC+pVUYv+sseFltM4qAHGS8ik+NdpW8oiFiPVIolFx+mMTXQ6SP4miYM8hkDZLl+b0=
X-Received: by 2002:a1f:d2c4:0:b0:339:578b:471d with SMTP id j187-20020a1fd2c4000000b00339578b471dmr6074881vkg.7.1651157293443; Thu, 28 Apr 2022 07:48:13 -0700 (PDT)
MIME-Version: 1.0
References: <165107434667.986.8513125292645167148@ietfa.amsl.com>
In-Reply-To: <165107434667.986.8513125292645167148@ietfa.amsl.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Thu, 28 Apr 2022 20:18:01 +0530
Message-ID: <CAH6gdPxDXzEyOnSi8hybNHLV7KOEZXNzKwaDQoTe9km3AgevUw@mail.gmail.com>
To: Matthew Bocci <matthew.bocci@nokia.com>
Cc: rtg-dir@ietf.org, draft-ietf-lsr-ospf-reverse-metric.all@ietf.org, last-call@ietf.org, lsr <lsr@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000f1addf05ddb803c3"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/ToNkixUs9XZ1-W9DRGly3c64h9k>
Subject: Re: [Last-Call] Rtgdir last call review of draft-ietf-lsr-ospf-reverse-metric-04
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Apr 2022 14:48:18 -0000

Hi Matthew,

Thanks for your review and we've fixed all the nits identified by you in
the updated version posted below:

https://datatracker.ietf.org/doc/html/draft-ietf-lsr-ospf-reverse-metric-05

Thanks,
Ketan


On Wed, Apr 27, 2022 at 9:15 PM Matthew Bocci via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Matthew Bocci
> Review result: Ready
>
> The draft is basically ready. I found the it easy to read and well written.
> Thank you!
>
> I have a few minor nits, intended to improve readability, as follows:
>
> Section 2.2:
> "..to a bunch of routers R1 thru RN..." I suggest changing 'thru' to
> 'through',
> to be consistent with the rest of the draft. "...towards the core getting
> diverted away..." I suggest changing this to "...towards the core to be
> diverted away..."
>
> Section 4 LLS Reverse Metric TLV
> Please expand 'LLS' on first use.
>
> Section 6 Procedures, first bullet
> "..by any of its neighbor on any of its links..." I suggest changing to
> "..by
> any of its neighbors on any of its links..."
>
>
>
>