Re: [Last-Call] [Gen-art] Genart last call review of draft-ietf-cellar-matroska-15

Lars Eggert <lars@eggert.org> Thu, 25 May 2023 07:09 UTC

Return-Path: <lars@eggert.org>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8DE8C151077; Thu, 25 May 2023 00:09:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AjTfzPpuWzsa; Thu, 25 May 2023 00:09:02 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0602DC151065; Thu, 25 May 2023 00:08:59 -0700 (PDT)
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6CC868C3E8; Thu, 25 May 2023 10:08:48 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eggert.org; s=dkim; t=1684998537; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=KrX7Msz9eaLTAor1L2x48gLJhUMAzzyMrUkv/JGwZWQ=; b=JnN8rxWxrvTZ37zg9TY8gLi/73TQh1yJGA2nCbXV43ivO7kIcxorla6BteLFelQqIlhXK8 g+Xfm1VRRIz36xJjjmi0mFMOh5U9cWJUnGGYr3MiP7xbrKUwkCv9m4b58ohrWyFZ2q2v/j pHafDn9xbr615yhrsxaNo4UGQaXJnufZBBT24rTmZpTd4aSpDWXy2Ts41KeutQdQ6vBy7K yoA4mK817cIvXKfmmuF7jXLlfobnR2tmMa/wbZ/Y+rf2e/oy9asjCOodVpj2oUZPhRnRRV PK6Vih1B1dreZkY0Mb7kye6RL422bHsNobnw41VM1jF2p8HzB02ohs1BXnrRqw==
Content-Type: multipart/signed; boundary="Apple-Mail=_70DEEAFB-C6D5-41BA-A532-77AEDC021A9D"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <167780246094.46963.4672549410769570417@ietfa.amsl.com>
Date: Thu, 25 May 2023 10:08:39 +0300
Cc: General Area Review Team <gen-art@ietf.org>, cellar@ietf.org, draft-ietf-cellar-matroska.all@ietf.org, last-call@ietf.org
Message-Id: <FE3B9B8C-AE6B-45E9-97C7-8D1F1B77ABB3@eggert.org>
References: <167780246094.46963.4672549410769570417@ietfa.amsl.com>
To: Elwyn Davies <elwynd@dial.pipex.com>
X-Last-TLS-Session-Version: TLSv1.2
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/TuUstQ5jn8XbPMiQYlTYf7ussmY>
Subject: Re: [Last-Call] [Gen-art] Genart last call review of draft-ietf-cellar-matroska-15
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2023 07:09:07 -0000

Elwyn, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On Mar 3, 2023, at 02:14, Elwyn Davies via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Elwyn Davies
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-cellar-matroska-15
> Reviewer: Elwyn Davies
> Review Date: 2023-03-02
> IETF LC End Date: 2023-02-28
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:  Almost ready.  Thre is a good deal of discussion of earlir versions
> of the structure and associated parsers together dicussion of future proofing
> and potential future versions of the structure and associated parsers.  I am
> concerned that it is not possible to automatically know which components are
> associated with a given version.  At the least, this would assist implementers
> to ensure that their parsers are working on the right ietms and ignoring
> irrelevant items.
> 
> Major issues:
> 
> Versions of Matroska:  According to Section 2, this document covers versions 1,
> 2, 3 and 4 of Matroska. The implication is that not all elements were defined
> in lower numbered versions but that older parsers should potentially be able to
> handle later versions of the format.  I am unclear about this but I have a
> suspiscion that implementers and extenders of the format need to know which
> elements existed in which versions and may need to understand whether they can
> modify these elements in future versions.  At present there is no indication
> which elements are defined in earlier versions and are therefore potentially
> not updateable.
> 
> Minor issues:
> 
> General: I am concerned about the long term stability of the web site
> referenced for the Matroska Container Format, reference [MCF].  Among other
> issues it is not accessed via https and it claims that it is the one true
> specification which is rather confusing when it is being written into a
> standards track RFC.
> 
> s1: What is meant by the term 'old parsers'?  Is this just claiming that
> parsers for possible future formats will be always capable of parsing old
> versions of the format?
> 
> Nits and Editorial Comments
> 
> Abstract and s1: I wonder if 'Matroska audiovisual data container structure'
> might be a clearer reflection of what is being described?
> 
> s1: It might be more helpful if the MCF reference pointed to the descriptive
> introductory page of the web site (http://mukoli.free.fr/mcf/).
> 
> s1, para 1: s/differentiates from it/diverges from it/
> 
> s1, para 1: s/enables/provides/
> 
> s1, 2nd bullet: s/for which/in which/
> 
> s1, para after 2nd bullet: s/features like/features such as/
> 
> s4.3: I suspect that the use and format of Hexadecimal Floating-Point Constants
> is not sufficiently generally understood to not require explanation in an RFC.
> I suggest duplicating the reference to [ISO9899] used in Section 11.1.18 of RFC
> 8794 would be desirable.
> 
> s5: A reference to Section 11 of [RFC8794] referring to the structure of
> element definitions would be useful.
> 
> s5.1: The details of the elements in this section are outside my competence and
> I haven't looked at them with any exactitude.  Nothing jumped out at me.
> 
> s6.1, para 2: I was unable to parse the second sentence: "In that case the
> Segment containing in these Chapters do no required a Track Element or
> a Cluster Element."
> 
> s20.5.2: s/contain/contains/
> 
> s23.3.3, para 1: s/want to seek/wants to seek/; s/to have these/to access these/
> 
> s27.1: Should an Element ID registry entry contain the Matroska version at
> which it was introduced?
> 
> s28, para 2: s/if there is no more/if there are no more/
> 
> 
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art