[Last-Call] Genart last call review of draft-ietf-dots-robust-blocks-05

Tim Evens via Datatracker <noreply@ietf.org> Tue, 27 September 2022 03:18 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: last-call@ietf.org
Delivered-To: last-call@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1DEE9C1522BF; Mon, 26 Sep 2022 20:18:59 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Tim Evens via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: dots@ietf.org, draft-ietf-dots-robust-blocks.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.17.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166424873911.33674.13795353189229005326@ietfa.amsl.com>
Reply-To: Tim Evens <tievens@cisco.com>
Date: Mon, 26 Sep 2022 20:18:59 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/UbWdbdpkB7hlJUNWacGaQfQyxA0>
Subject: [Last-Call] Genart last call review of draft-ietf-dots-robust-blocks-05
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2022 03:18:59 -0000

Reviewer: Tim Evens
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-dots-robust-blocks-??
Reviewer: Tim Evens
Review Date: 2022-09-26
IETF LC End Date: 2022-09-16
IESG Telechat date: 2022-10-06

Summary: This document is ready with some minor comments.

Major issues:

Minor issues:

Nits/editorial comments:

1) +1 to Paul's Nits

2) Upon initial read, the abstract could suggest new parameters being
introduced for configuration, yet that is not the case for this document. In
Section 1 it is more clear by writing "This document augments the
"ietf-dots-signal-channel" DOTS signal YANG module defined in Section 5.3 of
[RFC9132]". It appears to me that this document adds the existing RFC9177
non-confirming parameters to DOTS. I'm not suggesting that the abstract needs
to be changed, but IMO it is a bit misleading till you read the intro.

3) In section 1; "Nevertheless, the parameters listed in Table 1 are not
supported in [RFC9132]". While "not supported" is correct, I believe that it
would be more clear as "not included" considering the parameters do exist.

4) In section 3, the parameters are restated from RFC9177 and RFC9132.

Each parameter looks to be a redefinition of what's documented in RFC9177 but
with missing statements, truncated. I would prefer that if the parameter is
unchanged to RFC9177, it should simply state that it's the same as defined in
RFC9177.

Restating/documenting the parameters leads the reader to have to compare if
there is a change from the source RFC.