Re: [Last-Call] Genart last call review of draft-ietf-jsonpath-iregexp-06
Carsten Bormann <cabo@tzi.org> Mon, 22 May 2023 09:04 UTC
Return-Path: <cabo@tzi.org>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3940BC15199C; Mon, 22 May 2023 02:04:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ENKod-_snxVM; Mon, 22 May 2023 02:04:11 -0700 (PDT)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [134.102.50.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A4014C151557; Mon, 22 May 2023 02:04:08 -0700 (PDT)
Received: from [192.168.217.124] (p548dc0f6.dip0.t-ipconnect.de [84.141.192.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4QPs2F2Z6QzDCgd; Mon, 22 May 2023 11:04:05 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <168390322438.52616.9322373497339670155@ietfa.amsl.com>
Date: Mon, 22 May 2023 11:04:05 +0200
Cc: gen-art@ietf.org, draft-ietf-jsonpath-iregexp.all@ietf.org, jsonpath@ietf.org, last-call@ietf.org
X-Mao-Original-Outgoing-Id: 706439044.992946-71b4bcc34893adb9282a813ca5d2c367
Content-Transfer-Encoding: quoted-printable
Message-Id: <05949245-91BE-4549-A17D-86CA45D233C7@tzi.org>
References: <168390322438.52616.9322373497339670155@ietfa.amsl.com>
To: Russ Housley <housley@vigilsec.com>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/bIjNYEKutTsoLnbvbcdJ1TOUMo8>
Subject: Re: [Last-Call] Genart last call review of draft-ietf-jsonpath-iregexp-06
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 May 2023 09:04:16 -0000
Hi Russ, thank you for this review. Two comments: > Minor Concerns: > > Section 3: A reference to ABNF is needed. Since %s is being used, > I believe that a reference to RFC 7405 is required. Alternatively, > the paragraph in Section 1.1 could be moved to Section 3. We generally write IETF documents with the assumption that the terminology section has been read before reading other parts of the document. Given that the reference to 5234/7405 is a third of a page away, it doesn’t seem additional text is needed. There is also the issue that any additional text shortcutting to the references might preempt the important part of the text in Section 1.1, which specifies that the ABNF “characters” for this document are Unicode scalar values. > Nits: > > Section 3.1: s/_checking_/checking/ Well, this is the plaintext emulation of italic style, which seems quite appropriate for the occurrence of this term where it is being defined. Grüße, Carsten
- [Last-Call] Genart last call review of draft-ietf… Russ Housley via Datatracker
- Re: [Last-Call] Genart last call review of draft-… Carsten Bormann