Re: [Last-Call] Rtgdir last call review of draft-ietf-ospf-te-link-attr-reuse-12

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Wed, 03 June 2020 15:35 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8B5C3A0D25; Wed, 3 Jun 2020 08:35:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r1X3CZlcSuZE; Wed, 3 Jun 2020 08:35:50 -0700 (PDT)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EDA0F3A0D1D; Wed, 3 Jun 2020 08:35:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vka7Q4RXUIL9KTX41iqKCuTH9gteakYrPoSajtQw9Q6u8nfD0EDsoSAPrWVaDvTy2N8qRQxHlwSpo4hafhO3yI2/wASz0yviluCMyVZiJLmyhN0MNNhc6fSurZyDVdoDc2ErPL6OfSCr+QWEAiPYajj4Sc2Eq/y98RNySP+4GXBJREhmnP0Jo1Gdz3GXQt2hrPir0jtczZY1SQ1d3rs/3EH5phj77uiwDd4iK3ZDeDX4oTvoR6Mlu9uZr01LYRohrdOxrjHKIqHXBGVymzn4/BJCN2I+eJL7heR7H+0aYJa0i3I8OZcG6lW+kgbVS+XGG+FFfpM5Rwdl/lld1HsGGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yv50aIJ7+pV5DErS7ib344AYs1o406AfEwTXrs1Tu5E=; b=PSNJjjCey12/UpDBHU8TFg/r4YKgnN11qE5a2qsEcn86O6+edscCsYV1LqgbbCx3Wf5PFrXuYdXHpyZHcN1x06Xy2NUonkEf7AeKGck2zkN4ri6+IfUNu72hs0IIwKhQpX9rdLJ4fkvbzDdQNwjG0jn9bssrmVNvPZxtf8cLPhT1GDmnWsJIMdgNk9TFE7ZjJi90f5wBt6srSYgT4Bcpm+ANSTPcV1UCY1MLMJ9ZMy+9n6sVpjxgngur72p87Dtltqqmla+1bKt83JN4t/uhxZM+L6Msf4tTb/MZ+MC6U/YqsBoifV9SXYQxe/2srsVgd053fwj8pEK25VC/UN3tgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yv50aIJ7+pV5DErS7ib344AYs1o406AfEwTXrs1Tu5E=; b=FSm1aypquLkC9f4u3BocsX0WYurilVcyLHPV+7+Oix4aukOrlicUS/ux0z40KqKJ3O0XFMPycLZWZeklfYU5Plj9NDB0XlNGsM48T3UKFOjMyO90VNhYn7t2JuAQ1o6/RpBxy576rnvsVb8gU6KIs6pdISRjWcK63jPllprtzFc=
Received: from HE1PR07MB4156.eurprd07.prod.outlook.com (2603:10a6:7:9b::16) by HE1PR07MB3484.eurprd07.prod.outlook.com (2603:10a6:7:2c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.7; Wed, 3 Jun 2020 15:35:47 +0000
Received: from HE1PR07MB4156.eurprd07.prod.outlook.com ([fe80::7d12:7db0:50be:6400]) by HE1PR07MB4156.eurprd07.prod.outlook.com ([fe80::7d12:7db0:50be:6400%7]) with mapi id 15.20.3066.016; Wed, 3 Jun 2020 15:35:47 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: Peter Psenak <ppsenak@cisco.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "draft-ietf-ospf-te-link-attr-reuse.all@ietf.org" <draft-ietf-ospf-te-link-attr-reuse.all@ietf.org>
Thread-Topic: Rtgdir last call review of draft-ietf-ospf-te-link-attr-reuse-12
Thread-Index: AQHWN/2ZpXnbPVtk10eL7RR0kgVJBqjHBvwA
Date: Wed, 03 Jun 2020 15:35:47 +0000
Message-ID: <HE1PR07MB4156D83BBA83E22C0918F827F0880@HE1PR07MB4156.eurprd07.prod.outlook.com>
References: <159076909169.565.534138764890157419@ietfa.amsl.com> <a20a9eaf-a6db-4207-838b-1a4a8eeba9ad@cisco.com>
In-Reply-To: <a20a9eaf-a6db-4207-838b-1a4a8eeba9ad@cisco.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [93.38.67.165]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8df511d1-bbb4-4b9e-0287-08d807d3c9b3
x-ms-traffictypediagnostic: HE1PR07MB3484:
x-microsoft-antispam-prvs: <HE1PR07MB34847718F37F7167D59C4B10F0880@HE1PR07MB3484.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 04238CD941
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QIaAGR5+GzvlIYEZWj4KVGIFUxuwJrdRAjUltSpGmraPEEA0jjx2FSY+A51btF5Mx3WSg7LjbX/sOH1RPUfaz3Lg8e1kUl+mnxCCVxyB/GjkWk/CYNexKcbhLrDpfvgTsm/LTgdncM7UFEwvXALF5hoPGjYq3wv2rl0H+fnX9vQCQyR6+c+rl53EPKePmdAVqWgXjExdhumDBJ2uO8J2M0m33KTEewOpafTf6mljzn6EWcMbRtGvWPtqIgNQ5qW3InYv3mL0Q/QP4dMG8EXOc8Zpo8Z+80kdu7iI836V5X76FWugYjnsOE4cgDJJVwC1Ih1o86ib0DjQ5mekMdUY2Oww+Bo5FJyg8NSeQeELXi+RcAYtACYZwSjJQdt+Ap84oLsvtH9VZo1Be3B9PCAvaQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4156.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(53546011)(54906003)(5660300002)(76116006)(110136005)(2906002)(316002)(66556008)(478600001)(33656002)(66476007)(66446008)(64756008)(66946007)(9686003)(8676002)(7696005)(66574014)(55016002)(6506007)(186003)(71200400001)(26005)(8936002)(44832011)(52536014)(4326008)(86362001)(83380400001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: o7U5yW1a575W3nc8ypqFVU7wnqmZevS8D6YZRqPGX1xEzlsfi6GmjEiKcSbvYm/JKOEg5eKH8IJS45YlFmAmCHdXO8i00OuC0YkmS22oh2iCNRj3ccvBdNEgsXbzw4/iS+Gpiui9nMVtEOohBw/M4+kkV455EhuxNaYmJido4kBJ/wdIv2Zs7lLYFKNSyI4d4HKoY4VnhTI3CVDs//nVRsQmFFhAwEz/Of73Rwk4Ym8wMBMgj3UifIlrrElyE5bcm+TJd6eC7IvJd2O45zMuNCuCq2njOZZkUvNrqwjuoOThO7I35QVFRJOkPiJIaewkcm8d/tWe4LiQo1C4fQGpnhwr60Y/tFW4UdvXHu2SS7j4t7ayugafRETGrusn8A8oAciIoBp1NMiKcDvXfdE/SD70lIwthlVKFOI2NbsHoI5tCWFNARw63S++m4XXDAlPogAsrQ7AteO7hYz0BjsArkYFovrPjWa2+/NXeteAEmE=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8df511d1-bbb4-4b9e-0287-08d807d3c9b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2020 15:35:47.4961 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3WQNkA862k4F1v7qSmq1hUSBCZyX4sBjuYMKykkCdMiLijiDSJixgUm0t9Lmb+GJm1QxOzftfxEsUhH+NkeQPJZ2M9hNLwnoMiP9eMkUwrs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3484
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/3DGPpvj5E-UexZvLaVDU0CIXOgI>
Subject: Re: [Last-Call] Rtgdir last call review of draft-ietf-ospf-te-link-attr-reuse-12
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jun 2020 15:35:52 -0000

Hi Peter,

Please see in line.

BR
Daniele  

-----Original Message-----
From: Peter Psenak <ppsenak@cisco.com> 
Sent: den 1 juni 2020 12:15
To: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>; rtg-dir@ietf.org
Cc: last-call@ietf.org; lsr@ietf.org; draft-ietf-ospf-te-link-attr-reuse.all@ietf.org
Subject: Re: Rtgdir last call review of draft-ietf-ospf-te-link-attr-reuse-12

Hi Daniele,

please see inline (##PP)

On 29/05/2020 18:18, Daniele Ceccarelli via Datatracker wrote:
> Reviewer: Daniele Ceccarelli
> Review result: Has Nits
> 
> Hello,
> 
> I have been selected as the Routing Directorate reviewer for this 
> draft. The Routing Directorate seeks to review all routing or 
> routing-related drafts as they pass through IETF last call and IESG 
> review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs.
> For more information about the Routing Directorate, please see 
> ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
> 
> Although these comments are primarily for the use of the Routing ADs, 
> it would be helpful if you could consider them along with any other 
> IETF Last Call comments that you receive, and strive to resolve them 
> through discussion or by updating the draft.
> 
> Document: draft-ietf-ospf-te-link-attr-reuse-12
> Reviewer: Daniele Ceccarelli
> Review Date: 2020-05-29
> IETF LC End Date: date-if-known
> Intended Status: Standard Track
> 
> Summary:
> 
> The readibility of the draft has been significantly improved since my 
> last review (v07), mostly the abstract and the introduction, which now 
> cleary state what is the scope of the draft. I also appreciated the 
> introduction of section
> 3 where a description of the existing solution is described.
> 
> Minor issues:
> - Section 4.1 - Advantages with respect to RSVP-TE are described while 
> the text speaks about advantages with respect to RSVP-TE and GMPLS, 
> probably it could be changed into: advantages with respect to RSVP-TE 
> when used in packet networks and in GMPLS, something like this.

##PP
I can change to something like this:

"Advantages of Extended Link Opaque LSAs as defined in [RFC7684] for
OSPFv2 and Extended Router-LSAs [RFC8362] for OSPFv3 with respect to advertisement of link attributes originally defined for RSVP-TE when used in packet networks and in GMPLS"

Would that work?

[DC] yes, perfect.

 >
>- Section 5 - Why for the UDABM it doens't  say the value MUST be 0,4,8 
>but rather says "the legal values are" ? Is 8  octets future-proof 
>enough? or conversely, if only 3 values are defined why do  we need 8 
>octects as option?

##PP
I have corrected that and use the same text (with MUST) for both SABM and UDABM.
[DC] ok

We did not limit the size at the beginning, but later due to limited size of ISIS TLVs we limited it to 8 bytes to leave some space for the attributes itself (draft-ietf-isis-te-app). We wanted to keep the consistency between ISIS and OSPF which also helps BGP-LS. 8 octets should be future-proof enough (64 apps).
[DC] makes sense.

 >
 >
>- Section 8 - I really find it hard to understand  this small section.

##PP
this section says that Extended TE Metrics can be advertised per application as well as application independent and suggests how that can be done.
[DC] that's not super clear from the text, but now I understand what's the message that it conveys. I suggest a better phrasing to make it clear.


> 
> Typos:
> -  Unidirectional Link Dela [RFC7471]

##PP
fixed.

thanks,
Peter

> 
> 
> 
> 
>