Re: [Last-Call] Iotdir last call review of draft-ietf-6lo-minimal-fragment-04

Ines Robles <mariainesrobles@googlemail.com> Tue, 26 November 2019 15:08 UTC

Return-Path: <mariainesrobles@googlemail.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C6BC1208C6; Tue, 26 Nov 2019 07:08:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IffZi7jyWmno; Tue, 26 Nov 2019 07:08:07 -0800 (PST)
Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ECFBD1202A0; Tue, 26 Nov 2019 07:08:06 -0800 (PST)
Received: by mail-il1-x12d.google.com with SMTP id s5so17935436iln.4; Tue, 26 Nov 2019 07:08:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wUyd+c+Sc/QTvHem/+S3yE4y4iFLshfDGcwYvr8+Khk=; b=fLlpAvFO0nUigNI2lrvdrZkscSp1zWqhk4TEjNBt65X1osWB6uULyA3vMrnbZEeamg cNC9xTtV/XSvTDlVNPPV4gvQPuffi8oaaW2Drs+khxg9SgZq87sA9wN5WF2yg6J67iLM I0w7hBPDIY4eVacr6tOZmaLWBYc5MK5bGzdM+zhfsyD37PlWkgw1CTBfWKc7DW9RrRJ5 kDZybAewRJxj78XfNZuUtmnmLvKlvJmLvtmLLm/3Hjrkams/+Q6EYdEpTRs3qN73pkKB A/opbvpysGvXjP+1jprbjGjKQFlMN4DlRXWDXj1Jfwe92uQZE/mvavx5tLELN1vRhAAr 46JA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wUyd+c+Sc/QTvHem/+S3yE4y4iFLshfDGcwYvr8+Khk=; b=lDDsL1gngoOESSDGCsV8JD4xoY7PW/SmUZCgE4//z/yCy3uSi+WVHBeavO8r1lTT3g e8iB6cHMlS1/sqXaKzuXcAhavz/Z+Ux1Xs81iuTMTrWTtBjTMNXnJUMEDWrC9cUs7OV1 0t0FA4Q/t/r7TEqsPnxkjUVBnIB1wcTaai4zTZyc78nIycoicPsYyNteg3pMnc2ioJhQ HDoe8bpdNSyKnSsg38TKzHgx1Yi77o92GTD0pUIgI1+5ql81seNxKap0pwtrDMU+72jZ UcxMo2Hps7entxbMTLl/L1rvleCLFJEc/TR4xqRXTZ0Y1EfF1YvwsFa1x42q1yh6RFx2 IcdA==
X-Gm-Message-State: APjAAAVV4vD+wgbvvIt/m3QdEB8SP1zUr/1PfR4c73Z7ynmyBH5zjBuO JLjDQE0azldEjtXo9NF/a18CdLge7lRcRrYsuDEgRw==
X-Google-Smtp-Source: APXvYqwnNvUiLSdMqIY9qZBVUPwiwQmAWtpq3Q3C44bbjLCoTYU7StxYY6VvMEJAaoFfNWFQSqS2y482AqLKKpvAu8c=
X-Received: by 2002:a92:d80e:: with SMTP id y14mr40360644ilm.267.1574780885992; Tue, 26 Nov 2019 07:08:05 -0800 (PST)
MIME-Version: 1.0
References: <157477128880.13735.1639586563134012090@ietfa.amsl.com> <MN2PR11MB3565B3E1C6C4819300132E0BD8450@MN2PR11MB3565.namprd11.prod.outlook.com> <CAP+sJUcGvY2ZZgZMJc=xzjsoCw1+Ay9d5UANEK5=3ajTroDsCQ@mail.gmail.com> <MN2PR11MB356504734927FDAFC85B897ED8450@MN2PR11MB3565.namprd11.prod.outlook.com>
In-Reply-To: <MN2PR11MB356504734927FDAFC85B897ED8450@MN2PR11MB3565.namprd11.prod.outlook.com>
From: Ines Robles <mariainesrobles@googlemail.com>
Date: Tue, 26 Nov 2019 17:07:29 +0200
Message-ID: <CAP+sJUc8ioBUL_kLf1ysTiXUHwPOCW+CYmPbKd7qprZKfnezhg@mail.gmail.com>
To: "Pascal Thubert (pthubert)" <pthubert@cisco.com>
Cc: "Iot-dir@ietf.org" <Iot-dir@ietf.org>, "draft-ietf-6lo-minimal-fragment.all@ietf.org" <draft-ietf-6lo-minimal-fragment.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "6lo@ietf.org" <6lo@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000004f0a460598413f63"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/j73Dyr0ZB6HEvQAly7esruCII3c>
Subject: Re: [Last-Call] Iotdir last call review of draft-ietf-6lo-minimal-fragment-04
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Nov 2019 15:08:10 -0000

Sure Pascal, I will review the new version as well :)

Thank you,

Ines.

On Tue, Nov 26, 2019 at 3:58 PM Pascal Thubert (pthubert) <
pthubert@cisco.com> wrote:

> Just published 05, Ines, to address your last point.  Please see section 6
> on security.
>
> There’s also a bunch of new text that was discussed with Dave Thaler but
> could not be uploaded during draft cutoff.
>
> Maybe you’d want to look at that text too?
>
>
>
> Pascal
>
>
>
> *From:* Ines Robles <mariainesrobles@googlemail.com>
> *Sent:* mardi 26 novembre 2019 14:28
> *To:* Pascal Thubert (pthubert) <pthubert@cisco.com>
> *Cc:* Iot-dir@ietf.org; draft-ietf-6lo-minimal-fragment.all@ietf.org;
> last-call@ietf.org; 6lo@ietf.org
> *Subject:* Re: Iotdir last call review of
> draft-ietf-6lo-minimal-fragment-04
>
>
>
> Thank you very much Pascal for the fast response and explanations.
>
>
>
> Best,
>
>
>
> Ines.
>
>
>
> On Tue, Nov 26, 2019 at 3:12 PM Pascal Thubert (pthubert) <
> pthubert@cisco.com> wrote:
>
> Many thanks Ines!
>
> > Questions:
> >
> > 1- In Section 1 that list the components of the reassembly buffer in
> node B,
> > should it contains the datagram_offset as well?
>
> Well each fragment has a offset and a length but there's only one datagram
> size. Fragments are normally received in order but that's only a MUST for
> the first fragment. So say fragments are received in any order. You'd need
> to remember all the offsets. Whether the fragments are kept as received
> with their meta including the offset or just pasted at the right place is
> implementation dependent.
>
> >
> > 2-  In Section 1, where states: "...the actual packet data from the
> fragments
> > received so far, in a form that makes it possible to detect...", I think
> it might be
> > nice to add an example referring in which form, I mean: "...in a form
> (e.g. ....)
> > that makes it possible....", what do you think?
>
>
> If an implementation wishes to check that it gets is all and that's
> there's no overlap it can remember all the offsets and sizes. Or make a
> linked list of the fragments as received. Or paste in a space that is big
> enough and in a way that allows to scan for gaps. But we do not mandate
> exactly if and how that's done. If we indicate one we seem to favor it and
> I'm concerned that people would come up with a better idea and complain.
> This is an internal of the implementation after all.
>
> > 3- draft-ietf-intarea-frag-fragile-17, section 3.7 states some security
> > vulnerabilities for IP fragmentation (The mentioned document as well
> defines
> > virtual reassembly). Do you think that some of these vulnerabilities can
> be
> > applied to 6LOWPAN fragments? For example, attacks based on predictable
> > 6LOWPAN fragment identification values.
>
> You're certainly right, Ines. Let me visit that and come back with an
> update.
>
> All the best;
>
> Pascal
>
>