IETF Logo Mail Archive

Re: [Last-Call] [Gen-art] Genart last call review of draft-ietf-lisp-vendor-lcaf-09

Lars Eggert <lars@eggert.org> Tue, 19 April 2022 17:00 UTC

Return-Path: <lars@eggert.org>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6FFA83A08CD; Tue, 19 Apr 2022 10:00:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.109
X-Spam-Level:
X-Spam-Status: No, score=-7.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tPPZWGbqAwwb; Tue, 19 Apr 2022 10:00:48 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B2603A0910; Tue, 19 Apr 2022 10:00:47 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:9180:dfcf:fc10:7f39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id C9C311DAAE7; Tue, 19 Apr 2022 20:00:31 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1650387631; bh=ArZ0/rGu9OA/93uGpRttJghr3coNzgyX7VkA236E9Jk=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=AEvVOOR7YiDk0OvcEkYKF4zaw2RvJ+F7LFcqNgwgsomxkdYfBGJifai5Z3x/sds6s JckxJDKOKp4CTEpyleG5PFW0hLFlVL4JNoT2Q320X4j2popvAINc6wsRz27wDMxmst mPNVpjek1HYUd0PcnnQUm940Omyzw4m0ZFbeOYCw=
Content-Type: multipart/signed; boundary="Apple-Mail=_BEFEE01A-8724-420D-BE2C-12838CC22E54"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <164970933406.11609.7107781510824246342@ietfa.amsl.com>
Date: Tue, 19 Apr 2022 20:00:31 +0300
Cc: gen-art@ietf.org, last-call@ietf.org, draft-ietf-lisp-vendor-lcaf.all@ietf.org, lisp@ietf.org
Message-Id: <15D7DBCF-AC02-4445-AC18-8548A52D841D@eggert.org>
References: <164970933406.11609.7107781510824246342@ietfa.amsl.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-MailScanner-ID: C9C311DAAE7.A57D9
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/jbSkHLAIqZ41rgZ3AnHN8q7L6RA>
Subject: Re: [Last-Call] [Gen-art] Genart last call review of draft-ietf-lisp-vendor-lcaf-09
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2022 17:00:53 -0000

Christer, thank you for your review and thank you all for the following discussion. I have entered a No Objection ballot for this document based on the current revision that addressed the issue Christer identified.

Lars


> On 2022-4-11, at 23:35, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Christer Holmberg
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lisp-vendor-lcaf-09
> Reviewer: Christer Holmberg
> Review Date: 2022-04-11
> IETF LC End Date: 2022-04-12
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> The document is well written, and easy to read and understand. However, I do
> have a couple of issues.
> 
> Major issues:
> 
> Q1:
> 
> I do wonder why the document is published as Experimental, however, due to the
> following reasons:
> 
>   a)
> 
>   The document defines usage of the Type value 255.
> 
>   b)
> 
>   Section 3 says:
> 
>      "If a LISP device receives a LISP message containing a Vendor Specific
>       LCAF with an OUI that it does not understand, it MUST drop the
>       message and it SHOULD create a log message."
> 
>   This sounds like an update to LISP.
> 
>   c)
> 
>   Section 3 defines new header fields.
> 
> Minor issues:
> 
> N/A
> 
> Nits/editorial comments:
> 
> Q2:
> 
> Section 1 says:
> 
>   “The Vendor Specific LCAF allows organizations to create
>   LCAF addresses to be used only internally on particular LISP
>   deployments.”
> 
> Is “allows” the best wording? Where organizations previously disallowed to do
> this?
> 
> Would it be more correct to say “defines how organizations can create…”?
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.8.7 | Report a Bug | By Email