[Last-Call] Secdir last call review of draft-ietf-lsr-ospf-bfd-strict-mode-07
Wes Hardaker <wjhns1@hardakers.net> Sun, 18 September 2022 13:45 UTC
Return-Path: <wjhns1@hardakers.net>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2A61C14F732; Sun, 18 Sep 2022 06:45:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3MSZBbFLMXGZ; Sun, 18 Sep 2022 06:45:11 -0700 (PDT)
Received: from mail.hardakers.net (mail.hardakers.net [168.150.192.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E7149C14F736; Sun, 18 Sep 2022 06:45:05 -0700 (PDT)
Received: from localhost (unknown [103.199.217.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hardakers.net (Postfix) with ESMTPSA id 35A58205FF; Sun, 18 Sep 2022 06:45:03 -0700 (PDT)
From: Wes Hardaker <wjhns1@hardakers.net>
To: secdir@ietf.org
Cc: draft-ietf-lsr-ospf-bfd-strict-mode.all@ietf.org, last-call@ietf.org, raw@ietf.org
Date: Sun, 18 Sep 2022 06:44:59 -0700
Message-ID: <yblzgewx0dg.fsf@wx.hardakers.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/oTtSDWFcUmDpd7E6oc8yoU9ZT0c>
Subject: [Last-Call] Secdir last call review of draft-ietf-lsr-ospf-bfd-strict-mode-07
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Sep 2022 13:45:11 -0000
Reviewer: Wes Hardaker Review result: Ready I reviewed this document as part of the Security Directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the Security Area Directors. Document authors, document editors, and WG chairs should treat these comments just like any other IETF Last Call comments. Document: draft-ietf-lsr-ospf-bfd-strict-mode-07 Reviewer: Wes Hardaker Review Date: 2022-09-18 IETF LC End Date: 2022-09-20 Summary: Ready Major Concerns: None Minor Concerns: Just nits and comments Nits and comments: - In the introduction you might point to the section numbers where future things are defined. The one that drew my attention was the local interface ipv4 address TLV section (3) which is mentioned in 4th paragraph in the introduction, but the section itself felt like it came about suddenly. I'd add a "(section 3)" tagging to the introduction to introduce where it will be discussed later. But this is a very minor nit/suggestion. - In multiple places it talks about "strict-mode is enabled on the link" or similar. It is unclear from the context where this enabling is happening, and I'd be tempted to add a bit more operational context such as "strict-mode is enabled by the operator..." or similar. - In the state discussions the phrase "or higher" is used to indicate multiple states. The original OSPF RFC generally uses different terminology: "or greater". It might be wise to switch to the original terminology instead.
- [Last-Call] Secdir last call review of draft-ietf… Wes Hardaker
- Re: [Last-Call] Secdir last call review of draft-… Ketan Talaulikar
- Re: [Last-Call] Secdir last call review of draft-… Ketan Talaulikar
- Re: [Last-Call] Secdir last call review of draft-… Wes Hardaker