Re: [Last-Call] Intdir telechat review of draft-ietf-dnsop-svcb-https-08
Ben Schwartz <bemasc@google.com> Tue, 19 April 2022 18:00 UTC
Return-Path: <bemasc@google.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
by ietfa.amsl.com (Postfix) with ESMTP id 001363A0FD7
for <last-call@ietfa.amsl.com>; Tue, 19 Apr 2022 11:00:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -22.609
X-Spam-Level:
X-Spam-Status: No, score=-22.609 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01,
URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5,
USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key)
header.d=google.com
Received: from mail.ietf.org ([4.31.198.44])
by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id yQm-ymWP-9NB for <last-call@ietfa.amsl.com>;
Tue, 19 Apr 2022 11:00:06 -0700 (PDT)
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com
[IPv6:2a00:1450:4864:20::32a])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by ietfa.amsl.com (Postfix) with ESMTPS id 735F63A0FC5
for <last-call@ietf.org>; Tue, 19 Apr 2022 11:00:06 -0700 (PDT)
Received: by mail-wm1-x32a.google.com with SMTP id y21so9693965wmi.2
for <last-call@ietf.org>; Tue, 19 Apr 2022 11:00:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=IJLrsTZqQTqWMKcA16q3YdU/cC7h3sy6hb8Lu9nScpw=;
b=NSaBo2Udii0ON4Ozbpl3LKUlt9DH/GPsqKemvqTHcbbtRzUPWepvCLcPwhBZnamCMO
oo7rtYn9xyreBocfnQqh7lyqqFQ9NeG3PkrPNCZYYEH7g1Q+Jh3my5hk8RUrQky2mXi7
rW6ppt02Nt1J6h8h/VYgHqD5tffKVuB/0+xSJaw3yzPg3AEhZZ2S0Na4w541cCykq8pw
MEN/G9OJw6XrGrUVA4JQ2B6mP12swalzcmEzYS5CP4OZ2eTM3vOc5Mupq+Sx9pOXRCx7
h32ew5TyEClY513UWmW7a1qzGIPTdW65wJV7IS+2QoJbC8wz8H9F+DinVFqB4hMsptgZ
9jSQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=IJLrsTZqQTqWMKcA16q3YdU/cC7h3sy6hb8Lu9nScpw=;
b=gYIBp/rSe8Mua7VGkRJ+FvJqW1KZKlg6E1GvodMCeoraCL+RcFIDeyqk876PqcrNGX
kzgXuP/94PTw3jFip742z+KQ8MUddkBT9kG7E1jAq3IG647u7c3wF9gCshIzNma5+Qf/
U2CR9YW6G4OrjnPq0xk8JQNJfL2XdzBaJh0bw6GDhcQZI9cdaxLvkUzWeQqx+JooETp9
hVCdnZhLdCK7/dMWlVA4PvLwztRV6OSq0lTwPgbUaWElhZAPnQNNM4XwknVei1J+DIQC
TTsfhUk/HASWrzf+z3iIHqfCNA6QiEhwL0q+bNhmapfa4DDf2Fl3Q/nfLaOfy7IgU7UO
CWrw==
X-Gm-Message-State: AOAM530rJphzRcXf9kYl7Pp0QTiau+qbbODeMUJ1f23v3MuB2697hIEG
ytjZSQAJbVQWGQ8WsqEPQ13iKXJqQkC/rBHEPzlVNA==
X-Google-Smtp-Source: ABdhPJzUR65OKQi2Gvm0aP/TdQucTtrZTI6zzfwO4MreLDRbetj0ZjgfKWEmNntidXNp2qP/lnlQ0pdQrKyVGGMf7kY=
X-Received: by 2002:a7b:c0d5:0:b0:38e:ca29:f40 with SMTP id
s21-20020a7bc0d5000000b0038eca290f40mr17163180wmh.205.1650391204192; Tue, 19
Apr 2022 11:00:04 -0700 (PDT)
MIME-Version: 1.0
References: <165038223911.7532.5891611392351457956@ietfa.amsl.com>
In-Reply-To: <165038223911.7532.5891611392351457956@ietfa.amsl.com>
From: Ben Schwartz <bemasc@google.com>
Date: Tue, 19 Apr 2022 13:59:52 -0400
Message-ID: <CAHbrMsBNPaXmPjabrDiwu=WCDxUHCr7jLYD7CvmR1qRwTo3=JQ@mail.gmail.com>
To: Carlos Pignataro <cpignata@cisco.com>
Cc: int-dir@ietf.org, dnsop <dnsop@ietf.org>,
draft-ietf-dnsop-svcb-https.all@ietf.org, last-call@ietf.org
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
micalg=sha-256; boundary="0000000000007ddcf605dd05a52a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/pWVXs6k1H2gJc0mfXDLVIHpzBdI>
Subject: Re: [Last-Call] Intdir telechat review of
draft-ietf-dnsop-svcb-https-08
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>,
<mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>,
<mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2022 18:00:09 -0000
On Tue, Apr 19, 2022 at 11:30 AM Carlos Pignataro via Datatracker < noreply@ietf.org> wrote: > Reviewer: Carlos Pignataro > Review result: Ready with Nits > > I am an assigned INT directorate reviewer for draft-ietf-dnsop-svcb-https. > These comments were written primarily for the benefit of the Internet Area > Directors. Document editors and shepherd(s) should treat these comments > just > like they would treat comments from any other IETF contributors and resolve > them along with any other Last Call comments that have been received. For > more > details on the INT Directorate, see > https://datatracker.ietf.org/group/intdir/about/ > <https://datatracker.ietf.org/group/intdir/about/>. > > This document specifies the "SVCB" and "HTTPS" DNS resource record (RR) > types > to facilitate the lookup of information needed to make connections to > network > services, such as for HTTP origins. > > This document is clear and comprehensive. Specifically, rev -08 improved > structure, terminology, and readability. It seems ready modulo some nits. > > Editorial suggestions: > * s/followup/follow-up/g > * " * Fallback to the the client's non-Alt-Svc connection behavior" --> > duplicate "the" * "IANA from the "Resource Record (RR) TYPEs" subregistry" > --> > looks like that's a registry, not sub-registry (same with other parts of > the > IANA sections) * s/e.g./e.g.,/g * "2 octet field" -> "2-octet field" > Thanks for flagging these style issues. I've proposed these changes in a Github Pull Request [1], except for the comma changes (which appear to be a contested point of English style). [1] https://github.com/MikeBishop/dns-alt-svc/pull/390 > Editorially, I find this construct a bit interesting -- indirections, and > wonder if a bit more context can be added to S7.5. 7.5. "mandatory" > See Section 8. > 8. ServiceMode RR compatibility and mandatory keys > Yes, this is a bit odd, as is the forward reference for "ech". However, it avoids disrupting the flow of Section 7 with extensive subsections, and helps to highlight important material. I have no strong opinions about how this ought to be laid out in the document. Thank you for your consideration, > > Carlos. > > >
- [Last-Call] Intdir telechat review of draft-ietf-… Carlos Pignataro via Datatracker
- Re: [Last-Call] Intdir telechat review of draft-i… Ben Schwartz
- Re: [Last-Call] Intdir telechat review of draft-i… Carlos Pignataro (cpignata)