Re: [Last-Call] Genart last call review of draft-ietf-idr-tunnel-encaps-19

Gyan Mishra <hayabusagsm@gmail.com> Fri, 13 November 2020 21:47 UTC

Return-Path: <hayabusagsm@gmail.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66CA93A0D37; Fri, 13 Nov 2020 13:47:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.087
X-Spam-Level:
X-Spam-Status: No, score=-2.087 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bb3ChbYkj7GT; Fri, 13 Nov 2020 13:47:31 -0800 (PST)
Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AFCA23A0D31; Fri, 13 Nov 2020 13:47:31 -0800 (PST)
Received: by mail-pg1-x52d.google.com with SMTP id h16so4093850pgb.7; Fri, 13 Nov 2020 13:47:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=amagRStSvJbSafovtg3TAiddARd0/2UCxGrgaNgA4Fo=; b=pCKvbCXYCTSdxDnl991JBirJfovgZk3ksWBs1hEKH2HpLfGEhck6uFAVb78oQIfVYj +AiWsKWBrZLajpMbV6j5UWGGi5LTZPXmmdnwubPmikgnQ3Wnmadzf0dDG4BHH3DR1jX8 uymwr6//ZPGmoYaGQdKEV+srFlTh+mkdY94qHF3ZJtzZSY/LaJRopDtJvIUJR8yOZbRe k6gihv8VOvKGfBlxVXgFJyy3Ws08K/MY6VObzcV6pYbhtX4ibBKSjLN99nLPr5bIio2O UMNw+I1+DSpkELDXayFMGw5vli9oRlAgt/Z+/JFZ5j1mvf37SdFxSFu0GRUtQYEiZj2P A6/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=amagRStSvJbSafovtg3TAiddARd0/2UCxGrgaNgA4Fo=; b=j8tmjRUuhjTXUWffVjrsiH25Q3t0jqf4PLEXDxmeZi08FT2rhdqZlOyHSP3YNOBqJ/ sZ1L4jjtK1dVX+uBbLtxL75Q9CSlU/M0/VqDw4DPyfq87BOkxIl03Q1SfVgOqnrkX0OZ oe9slnc+Em5YdlTP+44HzFZSAinIfzIL/30anbMZbY8bGMpTObjfotplkcRXzfsk+tWl FUhzR7mG/ruHbxn5753yRZSj/57XEGffnAIPqNO00AgE7mFug+V1oozCoCtT+2nDL68Z jpw5nRPbVobABUY7Nx6gfb13MUoFuuRJJ5UDdKrhqQMR983CmBQy8q0AdHZiPIiIVgvc jZjg==
X-Gm-Message-State: AOAM532n/GEiRUE9XfrdIyXCtGggvFdshab0/sPrNgNApKyC8KKO6ABW PGd70RkWiuwOI6eKAqbVe8J0dREeJk/heEvC+Ko=
X-Google-Smtp-Source: ABdhPJyZdXc1fQ30QFOOn2aHNLmhnqXTDv36L82WEz80QcR/fYvGhVzTddCZ1CCtUZgJGkHnAyJTxCoeYQ3UuBgYZyk=
X-Received: by 2002:a63:fd0b:: with SMTP id d11mr3482931pgh.50.1605304051115; Fri, 13 Nov 2020 13:47:31 -0800 (PST)
MIME-Version: 1.0
References: <160170536718.20424.6017677549974569740@ietfa.amsl.com> <7FDAF4A4-7F10-4E22-8CA3-1D85A791F4DD@arrcus.com>
In-Reply-To: <7FDAF4A4-7F10-4E22-8CA3-1D85A791F4DD@arrcus.com>
From: Gyan Mishra <hayabusagsm@gmail.com>
Date: Fri, 13 Nov 2020 16:47:20 -0500
Message-ID: <CABNhwV1n5FWZAbvMaMKEzs7_hDi2iS87joboURRZ6Q2iWv-NMA@mail.gmail.com>
To: Keyur Patel <keyur@arrcus.com>
Cc: "draft-ietf-idr-tunnel-encaps.all@ietf.org" <draft-ietf-idr-tunnel-encaps.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000b92a0605b403f950"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/pa2-zG9UdjDefSisapwZkFy4LDY>
Subject: Re: [Last-Call] Genart last call review of draft-ietf-idr-tunnel-encaps-19
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2020 21:47:34 -0000

Thank you for the responses.

I am all set for the document advancement.

Gyan
On Fri, Nov 13, 2020 at 4:21 PM Keyur Patel <keyur@arrcus.com> wrote:

> Hi Gyan,
>
> Thanks for the detail review of the draft. My comments are inlined #Keyur
>
> On 10/2/20, 11:09 PM, "Gyan Mishra via Datatracker" <noreply@ietf.org>
> wrote:
>
>     Reviewer: Gyan Mishra
>     Review result: Ready
>
>     I am the assigned Gen-ART reviewer for this draft. The General Area
>     Review Team (Gen-ART) reviews all IETF documents being processed
>     by the IESG for the IETF Chair.  Please treat these comments just
>     like any other last call comments.
>
>     For more information, please see the FAQ at
>
>     <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
>     Document: draft-ietf-idr-tunnel-encaps-??
>     Reviewer: Gyan Mishra
>     Review Date: 2020-10-02
>     IETF LC End Date: 2020-10-01
>     IESG Telechat date: Not scheduled for a telechat
>
>     Summary:
>        This draft updates RFC 5512 is which was never used in production.
>         This document deprecates the original RFC 5512
>        Encapsulation SAFI used for GRE encapsulation type only and defined
> extended
>        community attributes  (which has never been used in production) ,
> and
>        specifies semantics for the attribute when it is carried in UPDATEs
> of
>        certain other SAFIs.  This document adds support for additional
> Tunnel
>        Types, and allows a remote tunnel endpoint address to be specified
> for each
>        tunnel.  This document also provides support for specifying fields
> of any
>        inner or outer encapsulations that may be used by a particular
> tunnel.
>
>     This document is well written and clearly defines all the tunnel
> encapsulation
>     attributes that exist today. This draft modification of the usage of
> the tunnel
>     encapsulation attribute is backwards compatible so does not impact the
> existing
>     deployments of the tunnel encapsulation types such as vxlan,vxlan GPE,
> NVGRE,
>     MPLS over GRE, L2TPV3.
>
>     Major issues:
>     None
>
>     Minor issues:
>     Is tunnel type RFC 7510 MPLS over UDP supported.
>
> #Keyur: Yes. Please see section 1.4 in the draft version 20 that was
> recently posted.
> https://datatracker.ietf.org/doc/draft-ietf-idr-tunnel-encaps/
>
>
> Also RFC 8663 SR-MPLS over IP
>     for SRv6 and SR-MPLS interoperability where MPLS over GRE RFC 4023 is
> used or
>     RFC 7510 MPLS over UDP and outer encapsulation is IPv6 for SRv6
> forwarding
>     plane to tunnel SR-MPLS.
>
> #Keyur: These should be a separate document. __
>
>     Nits/editorial comments:
>     As this update is backwards compatible to tunnel encapsulation
> attributes
>     deployed today is there any code upgrade for vendor implementation
> required now
>     for router vendors to support the new encapsulation attributes TLV and
> Sub TLVs
>     and extended community attributes defined with this draft.
>
> #Keyur: As you know the tunnel encapsulation attribute itself is backward
> compatible with RFC5512. However as part of this document, the tunnel
> encapsulation attribute can be carried with set of AFI/SAFIs that are
> defined in this document. To make this happen the code upgrade would be
> needed (Please refer to section 1).
>
> Regards,
> Keyur
>
>
>
> --

<http://www.verizon.com/>

*Gyan Mishra*

*Network Solutions A**rchitect *



*M 301 502-134713101 Columbia Pike *Silver Spring, MD