IETF Logo Mail Archive

Re: [Ledger] Errors in the document https://interledger.org/rfcs/0030-notes-on-oer-encoding/#what-is-oercanonical-oer

Adrian Hope-Bailie <adrian@hopebailie.com> Thu, 09 May 2019 09:19 UTC

Return-Path: <adrian@hopebailie.com>
X-Original-To: ledger@ietfa.amsl.com
Delivered-To: ledger@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 469321200CD for <ledger@ietfa.amsl.com>; Thu, 9 May 2019 02:19:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=hopebailie.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7Y3i0VW--8Z8 for <ledger@ietfa.amsl.com>; Thu, 9 May 2019 02:19:48 -0700 (PDT)
Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD614120020 for <ledger@ietf.org>; Thu, 9 May 2019 02:19:47 -0700 (PDT)
Received: by mail-ot1-x331.google.com with SMTP id g8so1634537otl.8 for <ledger@ietf.org>; Thu, 09 May 2019 02:19:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hopebailie.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BZg/JF+G0IUvS3MBmdcSqXwaOHSfDc0Z66mm2QjUcNg=; b=DVtOfKje9kn29zkoBwRg824hzka9heB15tJDneyDk7eCFjp3bePD59f1La1VLz7RkT 4dNnbYpzd7CcjEHkA+RDxU2+Bs/wFAVN3l28/LNQVWN94asyisf+VkyHDVPtUfqQbMjU roF5ErkL8s3OxaqibRZKy/ZwQe0tQ1BpAcc8M=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BZg/JF+G0IUvS3MBmdcSqXwaOHSfDc0Z66mm2QjUcNg=; b=D/OLmuhh4HTshsjJYNt7tgmsC6M7dInDdneALasDfM5y0ujrqfVxZs6/v7NJZOlDji yW8q2YN1yz/ZcKFDRRBng1nxoZia4ZmtczamIUK5WUGc7qPtxO1Ne2DaBNUCB/VmefAW pOmCcOcllHPDVom2UQyMWyJTlsYesFEE8dzKUEY6QLA8QXyU9LeZUTiJofFXvkw8OzO7 ywntUQlsPZCdajdt+g9AJwy507xzEVqfofVfA44rc5f8jkh0jAEm4SXSWCAzPquTeFsm WidRiJsDLcacKDUFTfJFqIy3H8DUHis5wZb0ukLIbOThTbuFV+tgFDBQblEeUX7fgdSx tnww==
X-Gm-Message-State: APjAAAWFyVhN/48LuhKAvcormOJhWazcjhtXm/atteiZRRWI87Ge5MqA oyJTphkJqBsiMDKFame8DdASLQ1EUNS88h7aI6VM+wXXLhI=
X-Google-Smtp-Source: APXvYqxWtrnEZ/86f6xQNp5OnMYy0Re3sLvmaHo8KYl+ODiDBzgX/R1tX6Xh7ddxvuBBe01wUhbQ/ABtPLpTyEzErmI=
X-Received: by 2002:a9d:3622:: with SMTP id w31mr1589972otb.279.1557393587037; Thu, 09 May 2019 02:19:47 -0700 (PDT)
MIME-Version: 1.0
References: <!&!AAAAAAAAAAAuAAAAAAAAAFMqVsFUbGBCrb8RSyzM7tYBANlTnCJhprtFudq2LHCBs8EBACQA//8AABAAAADobkHfBCiGT64RnN05TLrzAQAAAAA=@unigone.com>
In-Reply-To: <!&!AAAAAAAAAAAuAAAAAAAAAFMqVsFUbGBCrb8RSyzM7tYBANlTnCJhprtFudq2LHCBs8EBACQA//8AABAAAADobkHfBCiGT64RnN05TLrzAQAAAAA=@unigone.com>
From: Adrian Hope-Bailie <adrian@hopebailie.com>
Date: Thu, 09 May 2019 11:19:35 +0200
Message-ID: <CA+eFz_Ld4M5NeH3LKAZqzdDn7gEBJkHa1NouCCU+k=jhnjK6_w@mail.gmail.com>
To: Bruno Konik <bruno.konik@unigone.com>
Cc: Interledger Mailing List - IETF <ledger@ietf.org>
Content-Type: multipart/related; boundary="0000000000008857b2058870f31e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ledger/tSSvyuWUmAzdjmGu2D73GLDHocE>
Subject: Re: [Ledger] Errors in the document https://interledger.org/rfcs/0030-notes-on-oer-encoding/#what-is-oercanonical-oer
X-BeenThere: ledger@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of interledger, originally a protocol stack for moving digital assets \(making payments\) between accounts operating on different payment networks or ledgers." <ledger.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ledger>, <mailto:ledger-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ledger/>
List-Post: <mailto:ledger@ietf.org>
List-Help: <mailto:ledger-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ledger>, <mailto:ledger-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 09:19:50 -0000

Hi Bruno,

Thanks for this. I am looking into the corrections and will revert.

Adrian

On Tue, 7 May 2019 at 16:24, Bruno Konik <bruno.konik@unigone.com> wrote:

> Hello,
>
>
>
> I would like to make remarks about this doc (
> https://interledger.org/rfcs/0030-notes-on-oer-encoding/#what-is-oercanonical-oer
> ).
>
>
>
> There are errors of how integers are encoded in COER in the examples :
>
>
>
> In Fixed-length signed integers chapter :
>
>
>
> *Type*
>
> *Bytes*
>
> *Decoded value*
>
> Int8
>
> 00
>
> 0
>
> Int8
>
> 7F
>
> 127
>
> Int8
>
> 80
>
> -1
> *IT IS “-128” !*
>
> Int8
>
> FF
>
> -128
> *IT IS “-1” !*
>
> Int16
>
> 7FFF
>
> 32767
>
> Int16
>
> FC00
>
> -1024
>
> Int16
>
> CFC7
>
> -12345
>
> Int32
>
> 0C00F5C9
>
> 201389513
>
> Int32
>
> F204BA10
>
> -234571248
>
> Int64
>
> 7FFFFFFF FFFFFFFF
>
> 9223372036854775807
>
> Int64
>
> EF68FE12 0BC51AD7
>
> -8027945689248242392
> *IT IS* “-*1195426347606533417L” ! The encoding of “*-8027945689248242392”
> *is 909701ED F43AE528*
>
>
>
> I hope that my email will reach someone who can handle the above remark.
> Thank you very much for taking it in consideration.
>
>
>
> Best Regards,
>
>
>
>
> *Bruno KONIK*[image: Unigone-Horiz-sign] <http://www.unigone.com/>
>
> 4 route de la Noue
>
> 91 190 Gif sur Yvette
>
> +33(0)160127764 / +33(0)169419619
>
> http://www.unigone.com
>
>
> _______________________________________________
> Ledger mailing list
> Ledger@ietf.org
> https://www.ietf.org/mailman/listinfo/ledger
>

v2.23.0 | Report a Bug | By Email