[Lime] Yangdoctors early review of draft-ietf-lime-yang-oam-model-10

Carl Moberg <calle@tail-f.com> Fri, 02 June 2017 07:57 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carl Moberg <calle@tail-f.com>
To: yang-doctors@ietf.org
Cc: lime@ietf.org, ietf@ietf.org, draft-ietf-lime-yang-oam-model.all@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149639025372.31882.14301747353948788147@ietfa.amsl.com>
Date: Fri, 02 Jun 2017 00:57:33 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/OcRM4901kV8jrNQ53A0pa7cZ0Gs>
Subject: [Lime] Yangdoctors early review of draft-ietf-lime-yang-oam-model-10

Reviewer: Carl Moberg
Review result: On the Right Track

I am the assigned YANG Doctor for the LIME YANG modules, this is the
notes from my initial review of draft-ietf-lime-yang-oam-model done
with the authors:

First of all, would suggest we rename draft and the module itself:
OLD:
 draft-ietf-lime-yang-oam-model

NEW:
 draft-ietf-lime-yang-connection-oriented-oam-model


OLD:
 ietf-conn-oam

NEW:
 ietf-connection-oriented-oam

There are several uses of 'ordered-by system;'. Unless there is a
specific, and
documented reason for pointing out this default behavior, I suggest we
simply
remove them entirely.

Please review the use of case, e.g. the 'Interval' typedef should
likely be all
lowercase.

The description fields will need some language editing before release,
e.g. the
"Indicate whether the CC enable." description string for the 'MEP'
list.

[Lime] Yangdoctors early review of draft-ietf-lim… Carl Moberg