[Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods

Benoit Claise <bclaise@cisco.com> Fri, 11 August 2017 15:11 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 03B4B132654 for <lime@ietfa.amsl.com>; Fri, 11 Aug 2017 08:11:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, WEIRD_PORT=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JsWhCARrbYQ2 for <lime@ietfa.amsl.com>; Fri, 11 Aug 2017 08:11:38 -0700 (PDT)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 044EF13263F for <lime@ietf.org>; Fri, 11 Aug 2017 08:11:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=11954; q=dns/txt; s=iport; t=1502464298; x=1503673898; h=from:subject:references:to:cc:message-id:date: mime-version:in-reply-to; bh=L/x5UCNaCsqOxlI8RJHiHWyyJdomWhqnTmVk++oXlok=; b=OroDoEkFPF9rg1gb1SeUJ8iJqVWmrvG7Ji2OiotBuiNn6iBKg1rYwHAt qJt7C8Z2n1dE1SWx4dVi7dh2BgJnqvEFSHkD3INEZHGGno1Fr+j0EO48h NlG6Ufz1vqjrRPXyUqCmYQ5Gd+LpOCDmlZkDdWUXpAG1QxoEGdR/X2xwy 8=;
X-IronPort-AV: E=Sophos;i="5.41,358,1498521600"; d="scan'208,217";a="656712760"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2017 15:11:36 +0000
Received: from [10.55.221.36] (ams-bclaise-nitro3.cisco.com [10.55.221.36]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id v7BFBZ3d025423; Fri, 11 Aug 2017 15:11:36 GMT
From: Benoit Claise <bclaise@cisco.com>
References: <da8af3c8-67f2-64e3-d9b7-d592db2d5eb5@cisco.com>
To: "lime@ietf.org" <lime@ietf.org>
Cc: "Carl Moberg (camoberg)" <camoberg@cisco.com>
Message-ID: <43b1244d-f834-4251-b930-4f2cb66d774c@cisco.com>
Date: Fri, 11 Aug 2017 17:11:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <da8af3c8-67f2-64e3-d9b7-d592db2d5eb5@cisco.com>
Content-Type: multipart/alternative; boundary="------------7873844225457B56BFE571B4"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/ZHvdtJ7R2CRnRggJwSyHezRFpkE>
Subject: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Aug 2017 15:11:41 -0000

Dear all,

Here is my AD review.

- I see that the draft is NMDA-compliant. Good.
https://yangcatalog.org:8443/search/modules/ietf-connectionless-oam-methods,2017-05-18,ietf

- " This document presents a retrieval method YANG Data model for 
connectionless OAM protocols" is this right?

        rpc path-discovery {
              description
                "Generates path discovery as perRFC7276 <https://tools.ietf.org/html/rfc7276>.";;


        rpc continuity-check {
              if-feature coam:continuity-check;
              description
                "Generates continuity-check as perRFC7276 <https://tools.ietf.org/html/rfc7276>.";;

AFACT, the RPC triggers an "on-demand" (as opposed to proactive 
draft-ietf-lime-yang-connectionless-oam, to use the 
draft-ietf-lime-yang-connectionless-oam term) OAM mechanism and 
retrieves the results directly.
" This document presents a retrieval method YANG Data model for 
connectionless OAM protocols" makes it sound like "polling" the results, 
which could also be "proactive". You should improve the text

After hours spent on the two LIME drafts ...
If the continuity-check RPC is really "on-demand", why do we have the 
session-type-enum as input?

  rpc continuity-check {
     if-feature "coam:continuity-check";
     description
       "Generates continuity-check as perRFC7276 <https://tools.ietf.org/html/rfc7276>.";;
     input {
       container destination-tp {
         uses coam:tp-address;
         description
           "Destination test point.";
       }
       uses coam:session-type;         <==============
       leaf source-interface {
         type if:interface-ref;
         description
           "Source interface.";
       }

 From the other draft (why, btw?)

     grouping session-type {
       description
         "This object indicates the current session
          definition.";
       leaf session-type-enum {
         type enumeration {
           enum "proactive" {
             description
               "The current session is proactive";
           }
           enum "on-demand" {
             description
               "The current session is on-demand.";
           }
         }
         default "on-demand";
         description
           "Session type enum";
       }
     }

This should always be "on-demand", right?

Same remark for the persistent RPCs in the appendix A, which should 
always have a "session-type-enum" value of "proactive".
Trying to understand...


- Abstract:

    The retrieval methods
    model presented here can be extended to include technology specific
    details.

But this is not in line with the appendix A, which is the place that 
speaks about "extensions"
You should have another place (a new appendix) to explain how to augment 
the technology specific details ... in a consistent way, if possible.


-

    RPC - A Remote Procedure Call, as used within the NETCONF protocol

This document is about a YANG data model. So independently of NETCONF or 
RESTCONF or something else.
So referring to NETCONF only is not right. I would remove "as used 
within the NETCONF protocol"
Btw, RFC 7950 makes the distinction between :

    o  RPC: A Remote Procedure Call.

    o  RPC operation: A specific Remote Procedure Call.


You should include RPC and RPC operations in section 2
You want to review all "RPC" instances.
For example, RPC commands should be: RPC operations
Most of the time, RPC should be: RPC operation(s). Ex: 3.1 title.

- Since you import ietf-connectionless-oam, 
draft-ietf-lime-yang-connectionless-oam should probably be a normative 
reference

- The security considerations have been updated: 
https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines


Editorial:
-
OLD:

    It provides a technology-independent
    RPC commands for connectionless OAM protocols.


NEW:

    It provides technology-independent
    RPC commands for connectionless OAM protocols.

-
    It provides a flexible way to retrieve the retrieved-
    data which defined by the "ietf-connectionless-oam.yang"
    [I-D.ietf-lime-yang-connectionless-oam 
<https://tools.ietf.org/html/draft-ietf-lime-yang-connectionless-oam-methods-05#ref-I-D.ietf-lime-yang-connectionless-oam>].

retrieve the data?

-

OLD:
      "This YANG module defines the RPCs for ,
      connectionless OAM to be used within IETF
      in a protocol Independent manner.

NEW:
      "This YANG module defines the RPCs for
      connectionless OAM to be used within IETF
      in a protocol independent manner.

-
Appendix A
OLD:

    The following are some examples of extensions possible to the yang
    model.  The example discusses persistent methods.


NEW:

    The following are some examples of extensions possible to the YANG
    model.  The example discusses persistent methods.



Regards, Benoit