[Lime] YANG doctor initial review of draft-ietf-lime-yang-connectionless-oam

"Carl Moberg (camoberg)" <camoberg@cisco.com> Mon, 24 April 2017 22:05 UTC

Return-Path: <camoberg@cisco.com>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E430131949 for <lime@ietfa.amsl.com>; Mon, 24 Apr 2017 15:05:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.523
X-Spam-Level:
X-Spam-Status: No, score=-14.523 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6OVjjSI5f6Zm for <lime@ietfa.amsl.com>; Mon, 24 Apr 2017 15:05:40 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B99AC1318D0 for <lime@ietf.org>; Mon, 24 Apr 2017 15:05:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2300; q=dns/txt; s=iport; t=1493071540; x=1494281140; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=9t3WOgDnY8p/8fFZTREsuYu5d4lNN9KcbKXwfGf/9hQ=; b=YxklEx1fnTSD6YWzHfzm4tc358ObvR4Bn6PZ5kKX5odsW8LVCVNDpqXs MaLzlRaollrTBQgz3YOxpZdy8LpS0CA3M70NNGHkLzih3Y/ZW3nq8VWAm DBB7Tm/+KxoHtWqxozC4UIJ/sdnbKdaPhcvl2fDiTVy1SSXqMjQB9lp8i s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D+AABadv5Y/5tdJa1dGgEBAQECAQEBA?= =?us-ascii?q?QgBAQEBg1RhgQwHjXWnUYIPLooMPxgBAgEBAQEBAQFrHQuFVlEBPkInBIovDps?= =?us-ascii?q?3ki+LHQEBAQEBAQQBAQEBAQEBAQEaBYZTggiKeYISHwWQC402AYcWgzGIPoIAh?= =?us-ascii?q?TOIZ4E9j1yEPAEfOIEGYxVEEQGCRYQRdQGIKIENAQEB?=
X-IronPort-AV: E=Sophos;i="5.37,246,1488844800"; d="scan'208";a="226644172"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2017 22:05:39 +0000
Received: from XCH-ALN-015.cisco.com (xch-aln-015.cisco.com [173.36.7.25]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id v3OM5dxI024404 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL) for <lime@ietf.org>; Mon, 24 Apr 2017 22:05:39 GMT
Received: from xch-rcd-015.cisco.com (173.37.102.25) by XCH-ALN-015.cisco.com (173.36.7.25) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 24 Apr 2017 17:05:39 -0500
Received: from xch-rcd-015.cisco.com ([173.37.102.25]) by XCH-RCD-015.cisco.com ([173.37.102.25]) with mapi id 15.00.1210.000; Mon, 24 Apr 2017 17:05:39 -0500
From: "Carl Moberg (camoberg)" <camoberg@cisco.com>
To: "lime@ietf.org" <lime@ietf.org>
Thread-Topic: YANG doctor initial review of draft-ietf-lime-yang-connectionless-oam
Thread-Index: AQHSvUbo3TQuzPqrlEKkCtj/oJ88sw==
Date: Mon, 24 Apr 2017 22:05:39 +0000
Message-ID: <696928D9-33D1-47A9-AC9D-83EEE011552C@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3273)
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.60.116.174]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4D1A20E1FCF8AF4697BD5B652621628A@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/g1YsZkf-vbC0FpO97sEA30-YR64>
Subject: [Lime] YANG doctor initial review of draft-ietf-lime-yang-connectionless-oam
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2017 22:05:42 -0000

I am the assigned YANG Doctor for the LIME YANG modules, this is the notes from my initial review of draft-ietf-lime-yang-connectionless-oam done with the authors on a call last week:

The module is intended to be implemented as a service model, per the module classification draft (https://tools.ietf.org/html/draft-ietf-netmod-yang-model-classification-05) with augments to topologies, I suggest it needs more description on the general concepts and how to use it.

I suggest to remove the 'OAM data hierarchy' section. It does not add any information.

The current version YANG module is all configuration except the 'oper' subtree. And there are no mandatory nodes (except list keys) which seems to allow for many, many combinations that likely make no sense. Please re-review and make sure this is an informed choice.

Suggest to rename tp-address-type-value to tp-address-technology-type.

Why does 'grouping tp-technology' only allow 'technology-null' or 'technology-string'/'leaf ipv4-icmp' and what is the meaning of the leaf ipv4-icmp content?

There are a couple of occasions of 'ordered-by user' that does not have a description of the meaning of the order. Please review.

Add an if-feature on path-discovery in *-methods draft.

Generally I'd suggest adding more information about the various types and which specifications you are picking them up from (e.g. RD, LSP ID, etc)

The specification defines a typedef that is a path in another module ("routing-instance-ref"). Suggest to reach out to authors of draft-ietf-rtgwg-ni-model-02 to see if they want the -ref type in that module for reuse.

Generally check whitespace and comments. Use the '-f yang' option to YANG to fix whitespace.

Downcase "IPv4-Multicast-Group-Address", and "IPv6-Multicast-Group-Address", "IP-Multicast-Group-Address"

Name of top container ('oper') not very helpful, suggest renaming to 'session-statistics'?

Spelling of grouping (and uses) cc-session-statsitics

Filename should include revision in CODE BEGINS

Don't reference drafts, pleas check RFC6087 bis and well-formed drafts for header stmts
   https://datatracker.ietf.org/doc/html/draft-ietf-netmod-rfc6087bis#section-4.9'

Regards,
--
Carl Moberg