Re: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods

Qin Wu <bill.wu@huawei.com> Fri, 01 September 2017 14:18 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 070CB1341CB for <lime@ietfa.amsl.com>; Fri, 1 Sep 2017 07:18:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.31
X-Spam-Level:
X-Spam-Status: No, score=-2.31 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XJkpZmge1Vby for <lime@ietfa.amsl.com>; Fri, 1 Sep 2017 07:18:07 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE8361341C7 for <lime@ietf.org>; Fri, 1 Sep 2017 07:18:05 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml703-cah.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DUP05431; Fri, 01 Sep 2017 14:18:03 +0000 (GMT)
Received: from NKGEML411-HUB.china.huawei.com (10.98.56.70) by lhreml703-cah.china.huawei.com (10.201.108.44) with Microsoft SMTP Server (TLS) id 14.3.301.0; Fri, 1 Sep 2017 15:18:01 +0100
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.219]) by nkgeml411-hub.china.huawei.com ([10.98.56.70]) with mapi id 14.03.0235.001; Fri, 1 Sep 2017 22:17:56 +0800
From: Qin Wu <bill.wu@huawei.com>
To: Benoit Claise <bclaise@cisco.com>, "lime@ietf.org" <lime@ietf.org>
CC: "Carl Moberg (camoberg)" <camoberg@cisco.com>, Jan Lindblad <janl@tail-f.com>
Thread-Topic: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods
Thread-Index: AQHTErQqSGzB05NL0E+O1Mp6NhA6D6KflkNw///nkoCAALLJwA==
Date: Fri, 01 Sep 2017 14:17:56 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA9AAEEFC7@nkgeml513-mbx.china.huawei.com>
References: <da8af3c8-67f2-64e3-d9b7-d592db2d5eb5@cisco.com> <43b1244d-f834-4251-b930-4f2cb66d774c@cisco.com> <B8F9A780D330094D99AF023C5877DABA9AAEB827@nkgeml513-mbx.china.huawei.com> <6e526577-160b-01c4-a67d-00d4f64b4906@cisco.com>
In-Reply-To: <6e526577-160b-01c4-a67d-00d4f64b4906@cisco.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.30.132]
Content-Type: multipart/alternative; boundary="_000_B8F9A780D330094D99AF023C5877DABA9AAEEFC7nkgeml513mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.59A96C1C.003A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.1.219, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 87a906d463fc7ba3f42c0f591bac580e
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/sOmaQ6vk-dCpxMa-RkZSzsU8vsU>
Subject: Re: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 14:18:09 -0000

See my comments inline below.
发件人: Benoit Claise [mailto:bclaise@cisco.com]
发送时间: 2017年9月1日 19:23
收件人: Qin Wu; lime@ietf.org
抄送: Carl Moberg (camoberg); Jan Lindblad
主题: Re: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods

Thanks Qin,

See in-line (I removed the addressed points).
Thank for valuable comments, your comments have been addressed in v-(06) with other comments on the list:
https://datatracker.ietf.org/doc/draft-ietf-lime-yang-connectionless-oam-methods/
Good, but I still see some warnings at http://www.claise.be/IETFYANGPageCompilation.html


-Qin
发件人: Lime [mailto:lime-bounces@ietf.org] 代表 Benoit Claise
发送时间: 2017年8月11日 23:12
收件人: lime@ietf.org<mailto:lime@ietf.org>
抄送: Carl Moberg (camoberg)
主题: [Lime] AD review: draft-ietf-lime-yang-connectionless-oam-methods

Dear all,

Here is my AD review.


- " This document presents a retrieval method YANG Data model for connectionless OAM protocols" is this right?

   rpc path-discovery {

         description

           "Generates path discovery as per RFC7276<https://tools.ietf.org/html/rfc7276>.";


   rpc continuity-check {

         if-feature coam:continuity-check;

         description

           "Generates continuity-check as per RFC7276<https://tools.ietf.org/html/rfc7276>.";
AFACT, the RPC triggers an "on-demand" (as opposed to proactive draft-ietf-lime-yang-connectionless-oam, to use the draft-ietf-lime-yang-connectionless-oam term) OAM mechanism and retrieves the results directly.
" This document presents a retrieval method YANG Data model for connectionless OAM protocols" makes it sound like "polling" the results, which could also be "proactive". You should improve the text
Please let me know how this has been addressed.
It seems that this draft is not only about a retrieval, but also an activation, in case of "on demand". I believe we should make it clear.
If we need a 5 min call (maybe I don't express myself correctly), don't hesitate to let me know.

[Qin]: Sorry t miss your message, I think we could support on-demand data retrieval and proactive( periodical) data retrieval. In CL method model, 'ietf-connectionless-oam-methods 'module defined in the normative part of method draft support on-demand activation while 'example-cl-oam-persistent-methods ' support both on-demand activation and proactive activation.

After hours spent on the two LIME drafts ...
If the continuity-check RPC is really "on-demand", why do we have the session-type-enum as input?

[Qin]: The concept is separate retrieved-data from retrieval procedure, retrieved-data is defined in CL model draft, the retrieval-procedure is defined in CL method model draft. Session-type-enum is part of retrieved-data defined CL model, that’s why we can have one data retrieval model only support on-demand activation, we can have another data-retrieval model support proactive activation. This will allow more flexibility. This has been clarified in the introduction section of method model draft. We can make it more clear by distinct model proposed in the normative part from the model proposed in the appendix.


 rpc continuity-check {

    if-feature "coam:continuity-check";

    description

      "Generates continuity-check as per RFC7276<https://tools.ietf.org/html/rfc7276>.";

    input {

      container destination-tp {

        uses coam:tp-address;

        description

          "Destination test point.";

      }

      uses coam:session-type;         <==============

      leaf source-interface {

        type if:interface-ref;

        description

          "Source interface.";

      }
From the other draft (why, btw?)

    grouping session-type {

      description

        "This object indicates the current session

         definition.";

      leaf session-type-enum {

        type enumeration {

          enum "proactive" {

            description

              "The current session is proactive";

          }

          enum "on-demand" {

            description

              "The current session is on-demand.";

          }

        }

        default "on-demand";

        description

          "Session type enum";

      }

    }
This should always be "on-demand", right?
[Qin]: See above.
Regards, Benoit