Re: [lisp] WGLC for draft-ietf-lisp-mib-05

Gregg Schudel <gschudel@cisco.com> Wed, 12 September 2012 00:38 UTC

Return-Path: <gschudel@cisco.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BBFF421E8043 for <lisp@ietfa.amsl.com>; Tue, 11 Sep 2012 17:38:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bGMHJaCR37ih for <lisp@ietfa.amsl.com>; Tue, 11 Sep 2012 17:38:24 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by ietfa.amsl.com (Postfix) with ESMTP id CB90C21E8037 for <lisp@ietf.org>; Tue, 11 Sep 2012 17:38:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2442; q=dns/txt; s=iport; t=1347410304; x=1348619904; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=nGj66IQrAJKC9Wj61gH1M7UPXYmtQtXmqzd31IK6LrA=; b=PXaB00s21x3dY/Mc98jGa9TdOZ2eqxRsvEtJe1WMz3NTBWRbTmHvMLIz yC6UTDVmTVP/Nk3uvURbegKcJJLHi+DD/QyYj+KkFdN+EpEDj5HFqGh5c 26ikUy43YymYeW0WkOYYgYr9oB1q/alURxbkx7cdl2HNZyt7cTKhZqqcW E=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EAJHYT1CtJXG+/2dsb2JhbABCA7tVgQeCIAEBAQMBEgElQAEQCxgJFg8JAwIBAgFFBg0BBQIBAR6HaAYLm0OgXI4SgyQDiCA1jQqONoFngwaBQw
X-IronPort-AV: E=Sophos;i="4.80,407,1344211200"; d="scan'208";a="120592700"
Received: from rcdn-core2-3.cisco.com ([173.37.113.190]) by rcdn-iport-2.cisco.com with ESMTP; 12 Sep 2012 00:38:23 +0000
Received: from xhc-rcd-x08.cisco.com (xhc-rcd-x08.cisco.com [173.37.183.82]) by rcdn-core2-3.cisco.com (8.14.5/8.14.5) with ESMTP id q8C0cN80007402 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 12 Sep 2012 00:38:23 GMT
Received: from gschudel-mac-2.local (10.21.71.195) by xhc-rcd-x08.cisco.com (173.37.183.82) with Microsoft SMTP Server (TLS) id 14.2.298.4; Tue, 11 Sep 2012 19:38:23 -0500
Message-ID: <504FD97D.4020804@cisco.com>
Date: Tue, 11 Sep 2012 17:38:21 -0700
From: Gregg Schudel <gschudel@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
References: <CC639168.29AE0%terry.manderson@icann.org> <3A441BB0-B467-4670-891E-FC2DA81E6834@steffann.nl> <EDC652A26FB23C4EB6384A4584434A04080C1F08@307622ANEX5.global.avaya.com>
In-Reply-To: <EDC652A26FB23C4EB6384A4584434A04080C1F08@307622ANEX5.global.avaya.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.21.71.195]
X-TM-AS-Product-Ver: SMEX-10.2.0.1135-7.000.1014-19178.000
X-TM-AS-Result: No--27.812300-8.000000-31
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
Cc: LISP mailing list list <lisp@ietf.org>
Subject: Re: [lisp] WGLC for draft-ietf-lisp-mib-05
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/lisp>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2012 00:38:24 -0000

Thank you for the comments Dan

On 9/11/12 5:59 AM, Romascanu, Dan (Dan) wrote:
> Hi,
>
> There are a few issues that need to be corrected and clarified before
> submitting this document to the IESG. There may be more, but I did not
> have the time to perform a full MIB Doctor review, this is what I found
> at a first pass reading of the document.
>
> - Runing smilint indicates a number of problems - most derive from the
> fact that indices of many table are of the SYNTAX of Integer32 with no
> range restriction

thanks - fixed. (added ranges)

> - LispAddressType TC is defined as a four-tuple with several variants -
> how can it have 0 as its lower size?

thanks - fixed.

> - Having a REFERENCE clause that says "[LISP]" is not useful. People may
> use the MIB module but not the RFC, and even if they know what the
> reference is just one high level reference is useless. To be useful to
> implementers REFERENCE clauses of specific objects must point to the
> exact paragraphs that define the origin of the MIB definition in the
> LIPS RFC

thanks - fixed. added pertinent references w/ sections.

> - Some of the Integer objects have obviously a range, but this is not
> specified - for example lispMapCacheLocatorRlocPriority or
> lispMapCacheLocatorRlocWeight

thanks - fixed. added ranges.

> - The indexation of lispIidToVrfTable seems broken - if the value of
> VPNIdOrZero is zero because a VPN ID could not be determined, how are to
> rows in such situation distinguished?

thanks - fixed. added index.

> - There is no discontinuity indicator for the (many) counter objects in
> the MIB module. See section 4.6.1.2 in RFC 4181 for some advice on this
> issue

thanks - fixing...

> - IANA Considerations - IANA must allocate a branch under mib-2 for this
> MIB module (marked xxx in the MIB module)

thanks - yes, we had this on the "to do" list. will get this going.

>
> Regards,
>
> Dan

cheers
gregg

-- 
--------------------------------------------------------------------
  .:|:.:|:.  | gregg schudel (ccie#9591) LISP technical mrkting engr
    cisco    | mobile: +1 571 332 2222   email: gschudel@cisco.com
--------------------------------------------------------------------
cisco corporate legal statement:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--------------------------------------------------------------------