[lisp] Re: Roman Danyliw's No Objection on draft-ietf-lisp-name-encoding-09: (with COMMENT)

Dino Farinacci <farinacci@gmail.com> Thu, 01 August 2024 00:52 UTC

Return-Path: <farinacci@gmail.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC729C1519B3; Wed, 31 Jul 2024 17:52:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cPc1jZDXgVol; Wed, 31 Jul 2024 17:52:03 -0700 (PDT)
Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16E19C1519A8; Wed, 31 Jul 2024 17:52:03 -0700 (PDT)
Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2cb5e0b020eso4907027a91.2; Wed, 31 Jul 2024 17:52:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722473522; x=1723078322; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fObZ4F61fxkWb43cLlRlSGmEsJMcw3DfGexYaFlTOsA=; b=C3FfkIa4LWWKkWbwABbhsenT7KB7lcWt8/v+C9cz8gOqW5NEPy6nIQEj9ntf4zmoRt gnZ+YwS7ygAl6oj2AFLoQ5tC6p8yMrEXwYz/vglBeyI6zYngIxhOcVpudLOnODOJD0BM nyo4RbiZNsZ2rCxM83AnrCMlZnvDVLCI4+bDuxi3yWn6yC9yX+zEchp6HQeySkiBcPTJ ydk7kGGVfa6Qngmdw12Q+Jr4qTn3znxYx2ID19EA9PJCy5fXtyrPsn2VjBZ3Dk3qdpPY ajN6jQ2016QJKxEkceYvlUty/K4Xbg5X/+716Sm53fAmp9rbQMnJHUxfdvjrKksvofKp k2vQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722473522; x=1723078322; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fObZ4F61fxkWb43cLlRlSGmEsJMcw3DfGexYaFlTOsA=; b=X12dtueaPzaAK+Du7E3R9sDrGNWZhBIEYjOMYqddmsn7LfBlYvpFGYHtrT/SG598az fVe9YVtHGy4TSvyAnOdzHONp14TK6of5M50C6MsBz9nOqGEJBtoL5NfA+3Fa7DznmaOI 9WsZdTZZmRDUrIr32upbEiNDut9lWBukDL61gWtzzX01TtpYGRYwEcP8kWxlngyj7wSN W2ENIjaA1jFeTuMDsGgDQulrpIHmSYs2CsgvNfZZycw6tl6TSraEYZRCQ6nFgp/1w15u J1j6JxV6tAd7KeKsbK7h6bhEZQG1DAJQBYEvyYhzNhzGieET9Ids4Xl3btT6zlzmdWFp tgFg==
X-Forwarded-Encrypted: i=1; AJvYcCWzhgqe3U2DB9ZzpiDu1CSxsOSX9fUcyCNhh9PPQUq19Nz7y5IohUuDKmc5npNq+VR3lBnmE4SSym1/JRjsPXwZ5FI8oz17UqR1bLN1EZOQQr2f28IZ0Xgh5w8QhhkifjOHrBrrk8NAtR9PIwO4grNskkhblSkhwHqXeAE=
X-Gm-Message-State: AOJu0YxYMB+QysaJ3rwLxLpqwWKG9o0/+nfUvpUo7O/Hjb6oYFlTnPWz 6vdKSYkFkzlbhfwQ9kv33IBv7y7OWNZZ/67WfZKYOD6cY1JAFCfa
X-Google-Smtp-Source: AGHT+IFOAMojdfXZ44VsHnPp0Fc4axyjTxQq7rbD/40TsUqHI9ZIBSjlMy4CqGNbn84eDJsPLJ11/w==
X-Received: by 2002:a17:90b:83:b0:2cb:5aaf:c12e with SMTP id 98e67ed59e1d1-2cfe7b88b47mr1252904a91.37.1722473522380; Wed, 31 Jul 2024 17:52:02 -0700 (PDT)
Received: from smtpclient.apple ([2605:59c8:30dd:9810:a45b:41b0:a263:7d91]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfdc4513ecsm1992288a91.20.2024.07.31.17.52.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2024 17:52:02 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
From: Dino Farinacci <farinacci@gmail.com>
In-Reply-To: <172245137457.2245112.13682097906585119481@dt-datatracker-659f84ff76-9wqgv>
Date: Wed, 31 Jul 2024 17:51:50 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <355AB739-1B13-4B1F-BE9B-FB1F0D497BA9@gmail.com>
References: <172245137457.2245112.13682097906585119481@dt-datatracker-659f84ff76-9wqgv>
To: Roman Danyliw <rdd@cert.org>
X-Mailer: Apple Mail (2.3774.600.62)
Message-ID-Hash: EIAUXFS6GZ7ROX5JXLTZS52YCHX66DMJ
X-Message-ID-Hash: EIAUXFS6GZ7ROX5JXLTZS52YCHX66DMJ
X-MailFrom: farinacci@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-lisp.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: The IESG <iesg@ietf.org>, draft-ietf-lisp-name-encoding@ietf.org, lisp-chairs@ietf.org, LISP mailing list list <lisp@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [lisp] Re: Roman Danyliw's No Objection on draft-ietf-lisp-name-encoding-09: (with COMMENT)
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/lisp/ENwPz1DFybW1587rEjIGtTLbO20>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Owner: <mailto:lisp-owner@ietf.org>
List-Post: <mailto:lisp@ietf.org>
List-Subscribe: <mailto:lisp-join@ietf.org>
List-Unsubscribe: <mailto:lisp-leave@ietf.org>

> Thank you to Jouni Korhonen for the GENART review.

And thank you Roman for your review.

> ** Section 3
>   When Distinguished Names are encoded for EIDs, the EID-Prefix length
>   of the EIDs as they appear in EID-Records for all LISP control
>   messages [RFC9301] is the length of the string in bits (including the
>   null 0 octet).
> 
> Is “EID-Prefix length” described here the same as “EID mask-len” described in
> RFC9301?  “EID-Prefix length” is not a string found in FC9301.

I will change it to "EID mask-len". Good find.

> ** Section 3
>   The string of characters are encoded in the ASCII character-set
>   definition [RFC0020].
> 
> To confirm, any RFC20 ASCII string is a valid EID?  For example, “0x01 0x02
> 0x03 0x04” would be valid?  How would a non-terminating 0x00 be handled – is
> that invalid?

Yes, it is valid. There is usually a length field wrapped around the AFI encoding either in the EID mask-len or the LCAF length.

> I concur with the SECDIR reviewer (Rich Salz) that it would be helpful to
> explain this design choice.

We are waiting for direction from the reviewers. They seem to be in conflict of what should be done. We need direction from them.

> ** Section 5.
>   An RLOC that describes an Ingress or Egress
>   Tunnel Router (xTR) behind a NAT device can be identified by its
>   router name, as in [I-D.farinacci-lisp-lispers-net-nat]
> 
> Per [I-D.farinacci-lisp-lispers-net-nat]
> (draft-farinacci-lisp-lispers-net-nat): Given that the IESG conflict review on
> this document came back as “Request not to publish”
> (https://datatracker.ietf.org/doc/conflict-review-farinacci-lisp-lispers-net-nat/)
> is the WG confident that it makes sense to mention this document here?

This is going to be revisited. The document I-D.farinacci-lisp-lispers-net-nat is not a standard or a protocol specification created by the IETF. It is an implementation report.

Dino