Re: [lisp] YANG data models in LISP: extraction and compilation feedback

"Vina Ermagan (vermagan)" <vermagan@cisco.com> Fri, 18 December 2015 05:27 UTC

Return-Path: <vermagan@cisco.com>
X-Original-To: lisp@ietfa.amsl.com
Delivered-To: lisp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 047C31B3345; Thu, 17 Dec 2015 21:27:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pTr5-p2EPC2N; Thu, 17 Dec 2015 21:27:08 -0800 (PST)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 839421B3344; Thu, 17 Dec 2015 21:27:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=11554; q=dns/txt; s=iport; t=1450416428; x=1451626028; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=mRNDGgxqi7Dd1WN0Pl2w335aa/XrGp3YgvFAzJvKu+g=; b=grIJO7YRlDDJ+0IzwA1dNCotpECEJSSaytglko1xhiBcQNjng0mK8s9L cN0V1L/7NIm3XhG6RR+x5LarmfP7kpYDD2BlEuG6qMwpIf059SzdzNPuI KBHoev9K/3nD4929ZuxyFOBgIAMP/IJyo/9pjVmVx4i1m81HpUqLDa7ci 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BFAgCDmHNW/5xdJa1egm5MUm0Guz2CG?= =?us-ascii?q?QENgWIjhWoCgTs4FAEBAQEBAQGBCoQ0AQEBBEkwEAIBCBEDAQIoBzIUCQgCBAE?= =?us-ascii?q?NBYgvDr08AQEBAQEBAQEBAQEBAQEBAQEBAQEBGIZWhH6EQjkNEYQnBY02iUcBh?= =?us-ascii?q?TiID4FcSZcEg3MBIAEBQoQEcgGDYYEIAQEB?=
X-IronPort-AV: E=Sophos; i="5.20,444,1444694400"; d="scan'208,217"; a="54516761"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2015 05:27:07 +0000
Received: from XCH-RCD-007.cisco.com (xch-rcd-007.cisco.com [173.37.102.17]) by rcdn-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id tBI5R7Bj016981 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 18 Dec 2015 05:27:07 GMT
Received: from xch-rcd-019.cisco.com (173.37.102.29) by XCH-RCD-007.cisco.com (173.37.102.17) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Thu, 17 Dec 2015 23:27:06 -0600
Received: from xch-rcd-019.cisco.com ([173.37.102.29]) by XCH-RCD-019.cisco.com ([173.37.102.29]) with mapi id 15.00.1104.009; Thu, 17 Dec 2015 23:27:06 -0600
From: "Vina Ermagan (vermagan)" <vermagan@cisco.com>
To: "Benoit Claise (bclaise)" <bclaise@cisco.com>, "lisp@ietf.org" <lisp@ietf.org>
Thread-Topic: [lisp] YANG data models in LISP: extraction and compilation feedback
Thread-Index: AQHRNBRJF9on5tG5FUiS3MnuV81WLp7QH8aA
Date: Fri, 18 Dec 2015 05:27:06 +0000
Message-ID: <D298D824.7245C%vermagan@cisco.com>
References: <566AC980.10909@cisco.com>
In-Reply-To: <566AC980.10909@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.4.3.140616
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.19.60.136]
Content-Type: multipart/alternative; boundary="_000_D298D8247245Cvermaganciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/lisp/RSxJhUkGzXVjR3aeEb-YEw-sVaw>
Cc: "draft-ietf-lisp-yang@ietf.org" <draft-ietf-lisp-yang@ietf.org>, "yang-coord@ietf.org" <yang-coord@ietf.org>
Subject: Re: [lisp] YANG data models in LISP: extraction and compilation feedback
X-BeenThere: lisp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: List for the discussion of the Locator/ID Separation Protocol <lisp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lisp>, <mailto:lisp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lisp/>
List-Post: <mailto:lisp@ietf.org>
List-Help: <mailto:lisp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lisp>, <mailto:lisp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2015 05:27:11 -0000

Hi Beniot,

Thanks for the notification. The errors below should be fixed in the new revision draft-ietf-lisp-yang-01 published today. I also tested the new version with yangvalidator, and all seems to be fine.

Thank you,
Vina

From: "Benoit Claise (bclaise)" <bclaise@cisco.com<mailto:bclaise@cisco.com>>
Date: Friday, December 11, 2015 5:02 AM
To: "lisp@ietf.org<mailto:lisp@ietf.org>" <lisp@ietf.org<mailto:lisp@ietf.org>>
Cc: "draft-ietf-lisp-yang@ietf.org<mailto:draft-ietf-lisp-yang@ietf.org>" <draft-ietf-lisp-yang@ietf.org<mailto:draft-ietf-lisp-yang@ietf.org>>, "yang-coord@ietf.org<mailto:yang-coord@ietf.org>" <yang-coord@ietf.org<mailto:yang-coord@ietf.org>>
Subject: [lisp] YANG data models in LISP: extraction and compilation feedback

Dear all,

I looked at the YANG model in the LISP WG document, from a compilation point of view (NOT a YANG design point of view):
    https://tools.ietf.org/html/draft-ietf-lisp-yang-00<http://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-network-topo/>

First of, we can't extract your YANG models from the draft.

Here are the extraction error messages:
xym.py draft-ietf-lisp-yang-00.txt
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 138 - Yang module 'ietf-lisp' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 1193 - Yang module 'lisp-itr' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 1630 - Yang module 'lisp-etr' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 2363 - Yang module 'lisp-map-server' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 2638 - Yang module 'lisp-map-resolver' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 3291 - Yang module 'lisp-pitr' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 3548 - Yang module 'lisp-petr' with no <CODE BEGINS> and not starting with 'example-'
ERROR: 'draft-ietf-lisp-yang-00.txt', Line 3651 - Yang module 'lisp-address-types' with no <CODE BEGINS> and not starting with 'example-'

As mentioned in https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-05, the correct way to use <CODE BEGINS> <CODE ENDS> is


   The "<CODE BEGINS>" tag SHOULD be followed by a string identifying
   the file name specified in Section 5.2 of
   [I-D.ietf-netmod-rfc6020bis<https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-05#ref-I-D.ietf-netmod-rfc6020bis>]s>].  The following example is for the
   '2010-01-18' revision of the 'ietf-foo' module:

     <CODE BEGINS> file "ietf-foo@2010-01-18.yang"<mailto:ietf-foo@2010-01-18.yang>
       module ietf-foo {
         // ...
         revision 2010-01-18 {
           description "Latest revision";
           reference "RFC XXXX";
         }
         // ...
       }
     <CODE ENDS>

Note that the example YANG models should use the "example-" prefix, and no <CODE BEGINS> <CODE ENDS>


Now, if I extract those modules anyway, you have some compilation errors:
pyang --ietf *.yang
lisp-address-types.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
lisp-etr.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
lisp-itr.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
lisp-map-resolver.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
lisp-map-server.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
lisp-petr.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
lisp-pitr.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"

Once you correct the extraction issues, the YANG models, along with some remaining compilation errors, will appear at <http://www.claise.be/IETFYANGPageCompilation.html> http://www.claise.be/IETFYANGPageCompilation.html

Finally, note that www.yangvalidator.com<http://www.yangvalidator.com> is your friend.

Regards, Benoit